You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2022/11/03 12:19:08 UTC

[plc4x] branch develop updated: refactor(plc4go/bacnet): remove useless code

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git


The following commit(s) were added to refs/heads/develop by this push:
     new 46cc1e13e refactor(plc4go/bacnet): remove useless code
46cc1e13e is described below

commit 46cc1e13e3e73cdf296f9bbe414922109b106fe1
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Thu Nov 3 13:18:57 2022 +0100

    refactor(plc4go/bacnet): remove useless code
---
 plc4go/internal/bacnetip/Connection.go | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/plc4go/internal/bacnetip/Connection.go b/plc4go/internal/bacnetip/Connection.go
index e6a854e07..e1929be8a 100644
--- a/plc4go/internal/bacnetip/Connection.go
+++ b/plc4go/internal/bacnetip/Connection.go
@@ -136,10 +136,6 @@ type InvokeIdGenerator struct {
 func (t *InvokeIdGenerator) getAndIncrement() uint8 {
 	t.lock.Lock()
 	defer t.lock.Unlock()
-	// If we've reached the max value for a 16 bit transaction identifier, reset back to 1
-	if t.currentInvokeId > 0xFF {
-		t.currentInvokeId = 0
-	}
 	result := t.currentInvokeId
 	t.currentInvokeId += 1
 	return result