You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "Daniel Gornstein (JIRA)" <ji...@apache.org> on 2012/10/03 16:26:07 UTC
[jira] [Created] (RAVE-806) Show stack trace error or fiendly error
message page depending on jsDebugMode
Daniel Gornstein created RAVE-806:
-------------------------------------
Summary: Show stack trace error or fiendly error message page depending on jsDebugMode
Key: RAVE-806
URL: https://issues.apache.org/jira/browse/RAVE-806
Project: Rave
Issue Type: Improvement
Reporter: Daniel Gornstein
Priority: Minor
Attachments: friendlyErrorMessagePage(Rave-806).patch
If jsDebugMode is on show the stack trace error as rave currently works.
If jsDebugMode is off show a friendly error message page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (RAVE-806) Show stack trace error or fiendly
error message page depending on jsDebugMode
Posted by Aaron Gooch <eo...@gmail.com>.
+1
Aaron
On Oct 4, 2012 1:17 PM, "Anthony Carlucci (JIRA)" <ji...@apache.org> wrote:
>
>
> [
https://issues.apache.org/jira/browse/RAVE-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469521#comment-13469521]
>
> Anthony Carlucci commented on RAVE-806:
> ---------------------------------------
>
> I can still see the usefulness in having the stack trace available no
matter what the jsDebugMode flag is set. For example, in a production
environment it will be assumed that flag will be off. However, that might
be the most useful environment to be able to have the stack trace available
for tracking down issues from an enterprise support perspective.
>
> As an alternate solution, I would suggest that we always have the stack
trace always available on the error page, hidden by default, with a "see
more details" button/link that could render it.
>
> Thoughts by the community?
>
> > Show stack trace error or fiendly error message page depending on
jsDebugMode
> >
-----------------------------------------------------------------------------
> >
> > Key: RAVE-806
> > URL: https://issues.apache.org/jira/browse/RAVE-806
> > Project: Rave
> > Issue Type: Improvement
> > Reporter: Daniel Gornstein
> > Priority: Minor
> > Attachments: friendlyErrorMessagePage(Rave-806).patch
> >
> >
> > If jsDebugMode is on show the stack trace error as rave currently works.
> > If jsDebugMode is off show a friendly error message page
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (RAVE-806) Show stack trace error or fiendly
error message page depending on jsDebugMode
Posted by Aaron Gooch <eo...@gmail.com>.
Jumped the gun... We do want to display Friendly message regardless of
setting.
On Oct 4, 2012 1:17 PM, "Anthony Carlucci (JIRA)" <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/RAVE-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469521#comment-13469521]
>
> Anthony Carlucci commented on RAVE-806:
> ---------------------------------------
>
> I can still see the usefulness in having the stack trace available no
> matter what the jsDebugMode flag is set. For example, in a production
> environment it will be assumed that flag will be off. However, that might
> be the most useful environment to be able to have the stack trace available
> for tracking down issues from an enterprise support perspective.
>
> As an alternate solution, I would suggest that we always have the stack
> trace always available on the error page, hidden by default, with a "see
> more details" button/link that could render it.
>
> Thoughts by the community?
>
> > Show stack trace error or fiendly error message page depending on
> jsDebugMode
> >
> -----------------------------------------------------------------------------
> >
> > Key: RAVE-806
> > URL: https://issues.apache.org/jira/browse/RAVE-806
> > Project: Rave
> > Issue Type: Improvement
> > Reporter: Daniel Gornstein
> > Priority: Minor
> > Attachments: friendlyErrorMessagePage(Rave-806).patch
> >
> >
> > If jsDebugMode is on show the stack trace error as rave currently works.
> > If jsDebugMode is off show a friendly error message page
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
[jira] [Updated] (RAVE-806) Show stack trace error or fiendly error
message page depending on jsDebugMode
Posted by "Daniel Gornstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Gornstein updated RAVE-806:
----------------------------------
Attachment: friendlyErrorMessagePage(Rave-806)-2.patch
A new patch which allows setting a preference to show or hide the technical details (stack trace) on the error page.
> Show stack trace error or fiendly error message page depending on jsDebugMode
> -----------------------------------------------------------------------------
>
> Key: RAVE-806
> URL: https://issues.apache.org/jira/browse/RAVE-806
> Project: Rave
> Issue Type: Improvement
> Reporter: Daniel Gornstein
> Priority: Minor
> Attachments: friendlyErrorMessagePage(Rave-806)-2.patch, friendlyErrorMessagePage(Rave-806).patch
>
>
> If jsDebugMode is on show the stack trace error as rave currently works.
> If jsDebugMode is off show a friendly error message page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-806) Show stack trace error or fiendly
error message page depending on jsDebugMode
Posted by "Matt Franklin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469687#comment-13469687 ]
Matt Franklin commented on RAVE-806:
------------------------------------
I agree that in an extranet/internet deployment we don't want the stacktrace shown; especially for exceptions caused by custom code on top of Rave. I think we really only need 2 though: Friendly with button to see stack trace and friendly with no stack trace.
> Show stack trace error or fiendly error message page depending on jsDebugMode
> -----------------------------------------------------------------------------
>
> Key: RAVE-806
> URL: https://issues.apache.org/jira/browse/RAVE-806
> Project: Rave
> Issue Type: Improvement
> Reporter: Daniel Gornstein
> Priority: Minor
> Attachments: friendlyErrorMessagePage(Rave-806).patch
>
>
> If jsDebugMode is on show the stack trace error as rave currently works.
> If jsDebugMode is off show a friendly error message page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-806) Show stack trace error or fiendly
error message page depending on jsDebugMode
Posted by "Chris Geer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469657#comment-13469657 ]
Chris Geer commented on RAVE-806:
---------------------------------
I disagree slightly. I prefer the ability to not send the client a stack trace at all since that exposes some very detailed system information to users you may not want having that. I'm not able to ever show a stack trace to a user for that reason.
Maybe we need three options: 1) Stack Trace, 2) Friendly with hidden stack trace, 3) Just friendly with no stack trace.
> Show stack trace error or fiendly error message page depending on jsDebugMode
> -----------------------------------------------------------------------------
>
> Key: RAVE-806
> URL: https://issues.apache.org/jira/browse/RAVE-806
> Project: Rave
> Issue Type: Improvement
> Reporter: Daniel Gornstein
> Priority: Minor
> Attachments: friendlyErrorMessagePage(Rave-806).patch
>
>
> If jsDebugMode is on show the stack trace error as rave currently works.
> If jsDebugMode is off show a friendly error message page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-806) Show stack trace error or fiendly error
message page depending on jsDebugMode
Posted by "Daniel Gornstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Gornstein updated RAVE-806:
----------------------------------
Attachment: friendlyErrorMessagePage(Rave-806)-3.patch
Per Tony's request added in a junit test for the ShowStackTraceTag
> Show stack trace error or fiendly error message page depending on jsDebugMode
> -----------------------------------------------------------------------------
>
> Key: RAVE-806
> URL: https://issues.apache.org/jira/browse/RAVE-806
> Project: Rave
> Issue Type: Improvement
> Reporter: Daniel Gornstein
> Priority: Minor
> Attachments: friendlyErrorMessagePage(Rave-806)-2.patch, friendlyErrorMessagePage(Rave-806)-3.patch, friendlyErrorMessagePage(Rave-806).patch
>
>
> If jsDebugMode is on show the stack trace error as rave currently works.
> If jsDebugMode is off show a friendly error message page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-806) Show stack trace error or fiendly error
message page depending on jsDebugMode
Posted by "Daniel Gornstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Gornstein updated RAVE-806:
----------------------------------
Attachment: friendlyErrorMessagePage(Rave-806).patch
> Show stack trace error or fiendly error message page depending on jsDebugMode
> -----------------------------------------------------------------------------
>
> Key: RAVE-806
> URL: https://issues.apache.org/jira/browse/RAVE-806
> Project: Rave
> Issue Type: Improvement
> Reporter: Daniel Gornstein
> Priority: Minor
> Attachments: friendlyErrorMessagePage(Rave-806).patch
>
>
> If jsDebugMode is on show the stack trace error as rave currently works.
> If jsDebugMode is off show a friendly error message page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (RAVE-806) Show stack trace error or fiendly
error message page depending on jsDebugMode
Posted by "Anthony Carlucci (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Carlucci resolved RAVE-806.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.17
Patch applied, thanks Dan!
> Show stack trace error or fiendly error message page depending on jsDebugMode
> -----------------------------------------------------------------------------
>
> Key: RAVE-806
> URL: https://issues.apache.org/jira/browse/RAVE-806
> Project: Rave
> Issue Type: Improvement
> Reporter: Daniel Gornstein
> Priority: Minor
> Fix For: 0.17
>
> Attachments: friendlyErrorMessagePage(Rave-806)-2.patch, friendlyErrorMessagePage(Rave-806)-3.patch, friendlyErrorMessagePage(Rave-806).patch
>
>
> If jsDebugMode is on show the stack trace error as rave currently works.
> If jsDebugMode is off show a friendly error message page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-806) Show stack trace error or fiendly
error message page depending on jsDebugMode
Posted by "Daniel Gornstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470238#comment-13470238 ]
Daniel Gornstein commented on RAVE-806:
---------------------------------------
Should I make it based off another preference in the admin section such as jsDebugMode and defaultWidgetHeight? I would agree that only the two are needed.
> Show stack trace error or fiendly error message page depending on jsDebugMode
> -----------------------------------------------------------------------------
>
> Key: RAVE-806
> URL: https://issues.apache.org/jira/browse/RAVE-806
> Project: Rave
> Issue Type: Improvement
> Reporter: Daniel Gornstein
> Priority: Minor
> Attachments: friendlyErrorMessagePage(Rave-806).patch
>
>
> If jsDebugMode is on show the stack trace error as rave currently works.
> If jsDebugMode is off show a friendly error message page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-806) Show stack trace error or fiendly
error message page depending on jsDebugMode
Posted by "Jasha Joachimsthal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470245#comment-13470245 ]
Jasha Joachimsthal commented on RAVE-806:
-----------------------------------------
For now that's okay. If the number of these preference grows, we may need to make categories like preferences for devops (jdebug) and preferences for webmasters (#items per page).
> Show stack trace error or fiendly error message page depending on jsDebugMode
> -----------------------------------------------------------------------------
>
> Key: RAVE-806
> URL: https://issues.apache.org/jira/browse/RAVE-806
> Project: Rave
> Issue Type: Improvement
> Reporter: Daniel Gornstein
> Priority: Minor
> Attachments: friendlyErrorMessagePage(Rave-806).patch
>
>
> If jsDebugMode is on show the stack trace error as rave currently works.
> If jsDebugMode is off show a friendly error message page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-806) Show stack trace error or fiendly
error message page depending on jsDebugMode
Posted by "Anthony Carlucci (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469521#comment-13469521 ]
Anthony Carlucci commented on RAVE-806:
---------------------------------------
I can still see the usefulness in having the stack trace available no matter what the jsDebugMode flag is set. For example, in a production environment it will be assumed that flag will be off. However, that might be the most useful environment to be able to have the stack trace available for tracking down issues from an enterprise support perspective.
As an alternate solution, I would suggest that we always have the stack trace always available on the error page, hidden by default, with a "see more details" button/link that could render it.
Thoughts by the community?
> Show stack trace error or fiendly error message page depending on jsDebugMode
> -----------------------------------------------------------------------------
>
> Key: RAVE-806
> URL: https://issues.apache.org/jira/browse/RAVE-806
> Project: Rave
> Issue Type: Improvement
> Reporter: Daniel Gornstein
> Priority: Minor
> Attachments: friendlyErrorMessagePage(Rave-806).patch
>
>
> If jsDebugMode is on show the stack trace error as rave currently works.
> If jsDebugMode is off show a friendly error message page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira