You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/25 06:25:16 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28015: [SPARK-31244][K8S][TEST] Use Minio instead of Ceph in K8S DepsTestsSuite

dongjoon-hyun commented on a change in pull request #28015: [SPARK-31244][K8S][TEST] Use Minio instead of Ceph in K8S DepsTestsSuite
URL: https://github.com/apache/spark/pull/28015#discussion_r397631338
 
 

 ##########
 File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala
 ##########
 @@ -35,17 +35,16 @@ import org.apache.spark.deploy.k8s.integrationtest.backend.minikube.Minikube
 private[spark] trait DepsTestsSuite { k8sSuite: KubernetesSuite =>
   import KubernetesSuite.k8sTestTag
 
-  val cName = "ceph-nano"
+  val cName = "minio"
   val svcName = s"$cName-s3"
-  val bucket = "spark"
-
-  private def getCephContainer(): Container = {
-    val envVars = Map ( "NETWORK_AUTO_DETECT" -> "4",
-      "RGW_FRONTEND_PORT" -> "8000",
-      "SREE_PORT" -> "5001",
-      "CEPH_DEMO_UID" -> "nano",
-      "CEPH_DAEMON" -> "demo",
-      "DEBUG" -> "verbose"
+  val BUCKET = "spark"
+  val ACCESS_KEY = "minio"
+  val SECRET_KEY = "miniostorage"
 
 Review comment:
   This came from the official usage example of `minio`.
   ```
   $ docker run -it --rm minio/minio server
   NAME:
     minio server - start object storage server
   
   ...
     2. Start distributed minio server on an 32 node setup with 32 drives each, run following command on all the nodes
        $ export MINIO_ACCESS_KEY=minio
        $ export MINIO_SECRET_KEY=miniostorage
   ...
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org