You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhli1142015 (via GitHub)" <gi...@apache.org> on 2025/10/01 08:50:14 UTC

Re: [PR] [GLUTEN-9057][VL] Avoid flatten unnecessary vector in ColumnarBatch.select [incubator-gluten]

zhli1142015 commented on code in PR #9058:
URL: https://github.com/apache/incubator-gluten/pull/9058#discussion_r2393881087


##########
cpp/velox/operators/serializer/VeloxColumnarToRowConverter.cc:
##########
@@ -70,7 +70,7 @@ void VeloxColumnarToRowConverter::refreshStates(facebook::velox::RowVectorPtr ro
 
 void VeloxColumnarToRowConverter::convert(std::shared_ptr<ColumnarBatch> cb, int64_t startRow) {
   auto veloxBatch = VeloxColumnarBatch::from(veloxPool_.get(), cb);
-  refreshStates(veloxBatch->getRowVector(), startRow);

Review Comment:
   Get it, thx



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org