[GitHub] [arrow] pitrou commented on a diff in pull request #36383: GH-36173: [C++] Add lone high and low code-point test case for UTF8StringToUTF16

["pitrou (via GitHub)" <gi...@apache.org>]

pitrou commented on code in PR #36383:
URL: https://github.com/apache/arrow/pull/36383#discussion_r1246813056


##########
cpp/src/arrow/util/utf8_util_test.cc:
##########
@@ -416,6 +416,12 @@ TEST(UTF8StringToUTF16, Basics) {
 
   CheckInvalid("\xff");
   CheckInvalid("h\xc3");
+
+  // lone high-code point
+  CheckInvalid("\xed\xa0\x80");
+
+  // lone low-code point
+  CheckInvalid("\xed\0xb0\x81");

Review Comment:
   I think this is incorrect
   ```suggestion
     CheckInvalid("\xed\xb0\x81");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org