You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/16 23:19:32 UTC

[GitHub] [tvm] vinx13 removed a comment on pull request #10582: [TIR][CodeGen] Process buffer elem_offset in target codegen

vinx13 removed a comment on pull request #10582:
URL: https://github.com/apache/tvm/pull/10582#issuecomment-1069734941


   `buffer->elem_offset` is already processed in `FlattenBuffer / StorageFlatten`, it is added to the buffer indices (https://github.com/apache/tvm/blob/main/src/tir/ir/buffer.cc#L307). Since subsequent passes can still declare buffer with `elem_offset`, I agree they still need to be handled. One option is to change `GetFlattenBuffer`(https://github.com/apache/tvm/blob/main/src/tir/ir/buffer.cc#L334)  to have the output buffer elem_offset erased to ensure `elem_offset` are not being processed more than once.
   
   cc @Lunderberg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org