You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kamesh Jayachandran <ka...@collab.net> on 2006/12/08 12:31:52 UTC
Re: svn commit: r22601 - in trunk/subversion/bindings/java/javahl:
native src/org/tigris/subversion/javahl src/org/tigris/subversion/javahl/tests
> Modified: trunk/subversion/bindings/java/javahl/native/SVNClient.cpp
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/java/javahl/native/SVNClient.cpp?pathrev=22601&r1=22600&r2=22601
> ==============================================================================
> --- trunk/subversion/bindings/java/javahl/native/SVNClient.cpp (original)
> +++ trunk/subversion/bindings/java/javahl/native/SVNClient.cpp Thu Dec 7 16:29:34 2006
> @@ -23,6 +23,7 @@
> +void
> +SVNClient::diffSummarize(const char *target1, Revision &revision1,
> + const char *target2, Revision &revision2,
> + bool recurse, bool ignoreAncestry,
> + DiffSummaryReceiver &receiver)
> +{
>
Spurious tabs...
> + err = svn_client_diff_summarize(path1.c_str(), revision1.revision(),
> + path2.c_str(), revision2.revision(),
> + recurse ? TRUE : FALSE,
> + ignoreAncestry ? TRUE : FALSE,
> + DiffSummaryReceiver::summarize, &receiver,
> + ctx, requestPool.pool());
>
Spurious tabs...
> Modified: trunk/subversion/bindings/java/javahl/native/org_tigris_subversion_javahl_SVNClient.cpp
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/java/javahl/native/org_tigris_subversion_javahl_SVNClient.cpp?pathrev=22601&r1=22600&r2=22601
> ==============================================================================
> --- trunk/subversion/bindings/java/javahl/native/org_tigris_subversion_javahl_SVNClient.cpp (original)
> +++ trunk/subversion/bindings/java/javahl/native/org_tigris_subversion_javahl_SVNClient.cpp Thu Dec 7 16:29:34 2006
> @@ -32,6 +32,7 @@
> +/*
> + * Class: org_tigris_subversion_javahl_SVNClient
> + * Method: diffSummarize
> + * Signature: (Ljava/lang/String;Lorg/tigris/subversion/javahl/Revision;Ljava/lang/String;Lorg/tigris/subversion/javahl/Revision;ZZLorg/tigris/subversion/javahl/DiffSummaryReceiver;)V
> + */
>
I am bit lost here should signature not capture jrecurse and
jignoreancestry? (Or already does it by ZZ?)
> + cl->diffSummarize(target1, revision1, target2, revision2, (bool) jrecurse,
> + (bool) jignoreAncestry, receiver);
>
Spurious tabs ....
> +}
>
> /*
> * Class: org_tigris_subversion_javahl_SVNClient
>
> Modified: trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClient.java
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClient.java?pathrev=22601&r1=22600&r2=22601
> ==============================================================================
> --- trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClient.java (original)
> +++ trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClient.java Thu Dec 7 16:29:34 2006
> @@ -670,6 +670,32 @@
> boolean force) throws ClientException;
>
> /**
> + * modified between two revisions, but still have the same
> + * contents.
> + * @param receiver As each is difference found, this callback is
>
@param receiver As each difference *is* found, this callback is
> Modified: trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientInterface.java
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientInterface.java?pathrev=22601&r1=22600&r2=22601
> ==============================================================================
> --- trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientInterface.java (original)
> +++ trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientInterface.java Thu Dec 7 16:29:34 2006
> @@ -587,6 +587,32 @@
> throws ClientException;
>
> /**
> + * modified between two revisions, but still have the same
> + * contents.
> + * @param receiver As each is difference found, this callback is
>
* @param receiver As each difference *is* found, this callback is
> Modified: trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientSynchronized.java
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientSynchronized.java?pathrev=22601&r1=22600&r2=22601
> ==============================================================================
> --- trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientSynchronized.java (original)
> +++ trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientSynchronized.java Thu Dec 7 16:29:34 2006
> @@ -873,6 +873,39 @@
> }
>
> /**
> + * modified between two revisions, but still have the same
> + * contents.
> + * @param receiver As each is difference found, this callback is
>
* @param receiver As each difference is found, this callback is
With regards
Kamesh Jayachandran
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r22601 - in trunk/subversion/bindings/java/javahl: native src/org/tigris/subversion/javahl src/org/tigris/subversion/javahl/tests
Posted by Daniel Rall <dl...@collab.net>.
On Fri, 08 Dec 2006, Kamesh Jayachandran wrote:
...
> >+ * Class: org_tigris_subversion_javahl_SVNClient
> >+ * Method: diffSummarize
> >+ * Signature:
> >(Ljava/lang/String;Lorg/tigris/subversion/javahl/Revision;Ljava/lang/String;Lorg/tigris/subversion/javahl/Revision;ZZLorg/tigris/subversion/javahl/DiffSummaryReceiver;)V
> >+ */
>
> I am bit lost here should signature not capture jrecurse and
> jignoreancestry? (Or already does it by ZZ?)
Yes, the JNI format specifier "Z" maps to Java's "boolean" type.
Thanks Kamesh, fixed the rest of it on trunk in r22621.