You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2021/05/01 06:24:17 UTC
Review Request 73327: RANGER-3270: updated RangerBasePlugin with
configurations to optionally disable dynamic refreshing of
policies/tags/roles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73327/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3270
https://issues.apache.org/jira/browse/RANGER-3270
Repository: ranger
Description
-------
added following policyengine configurations to optionally disable dynamic refreshing of policies/tags/roles:
- disable.policy.refresher
- disable.tag.retriever
By default, these options are set to retain current behvior.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java f457460cd
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java 6444fe952
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerService.java 8bd4586f6
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java 1ac45f175
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java 1f6aed975
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java 15b8fc76f
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java a7c4c97a1
Diff: https://reviews.apache.org/r/73327/diff/1/
Testing
-------
- unit tests pass successfully
Thanks,
Madhan Neethiraj
Re: Review Request 73327: RANGER-3270: updated RangerBasePlugin with
configurations to optionally disable dynamic refreshing of
policies/tags/roles
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73327/#review222928
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
Lines 201 (patched)
<https://reviews.apache.org/r/73327/#comment312094>
why we disable policy refresher by checking "disableTagRetriever"? Is it on purpose?
Also should we do a WARNING that policy refresh / Tag refresh is disabled for a plugin?
- Ramesh Mani
On May 1, 2021, 6:24 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73327/
> -----------------------------------------------------------
>
> (Updated May 1, 2021, 6:24 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3270
> https://issues.apache.org/jira/browse/RANGER-3270
>
>
> Repository: ranger
>
>
> Description
> -------
>
> added following policyengine configurations to optionally disable dynamic refreshing of policies/tags/roles:
> - disable.policy.refresher
> - disable.tag.retriever
>
> By default, these options are set to retain current behvior.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java f457460cd
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java 6444fe952
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerService.java 8bd4586f6
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java 1ac45f175
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java 1f6aed975
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java 15b8fc76f
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java a7c4c97a1
>
>
> Diff: https://reviews.apache.org/r/73327/diff/1/
>
>
> Testing
> -------
>
> - unit tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 73327: RANGER-3270: updated RangerBasePlugin with
configurations to optionally disable dynamic refreshing of
policies/tags/roles
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73327/#review222951
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On May 5, 2021, 3:47 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73327/
> -----------------------------------------------------------
>
> (Updated May 5, 2021, 3:47 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3270
> https://issues.apache.org/jira/browse/RANGER-3270
>
>
> Repository: ranger
>
>
> Description
> -------
>
> added following policyengine configurations to optionally disable dynamic refreshing of policies/tags/roles:
> - disable.policy.refresher
> - disable.tag.retriever
>
> By default, these options are set to retain current behvior.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java f457460cd
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java 6444fe952
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerService.java 8bd4586f6
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java 1ac45f175
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java 1f6aed975
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java 3a0649715
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java a1247bc01
>
>
> Diff: https://reviews.apache.org/r/73327/diff/2/
>
>
> Testing
> -------
>
> - unit tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 73327: RANGER-3270: updated RangerBasePlugin with
configurations to optionally disable dynamic refreshing of
policies/tags/roles
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73327/
-----------------------------------------------------------
(Updated May 5, 2021, 3:47 p.m.)
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
updates to address review comments
Bugs: RANGER-3270
https://issues.apache.org/jira/browse/RANGER-3270
Repository: ranger
Description
-------
added following policyengine configurations to optionally disable dynamic refreshing of policies/tags/roles:
- disable.policy.refresher
- disable.tag.retriever
By default, these options are set to retain current behvior.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java f457460cd
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java 6444fe952
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerService.java 8bd4586f6
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java 1ac45f175
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java 1f6aed975
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java 3a0649715
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java a1247bc01
Diff: https://reviews.apache.org/r/73327/diff/2/
Changes: https://reviews.apache.org/r/73327/diff/1-2/
Testing
-------
- unit tests pass successfully
Thanks,
Madhan Neethiraj
Re: Review Request 73327: RANGER-3270: updated RangerBasePlugin with
configurations to optionally disable dynamic refreshing of
policies/tags/roles
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73327/#review222927
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
Line 681 (original), 723 (patched)
<https://reviews.apache.org/r/73327/#comment312093>
Please add a null pointer check for refresher here and elsewhere in this class.
- Abhay Kulkarni
On May 1, 2021, 6:24 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73327/
> -----------------------------------------------------------
>
> (Updated May 1, 2021, 6:24 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3270
> https://issues.apache.org/jira/browse/RANGER-3270
>
>
> Repository: ranger
>
>
> Description
> -------
>
> added following policyengine configurations to optionally disable dynamic refreshing of policies/tags/roles:
> - disable.policy.refresher
> - disable.tag.retriever
>
> By default, these options are set to retain current behvior.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java f457460cd
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java 6444fe952
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerService.java 8bd4586f6
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java 1ac45f175
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java 1f6aed975
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java 15b8fc76f
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java a7c4c97a1
>
>
> Diff: https://reviews.apache.org/r/73327/diff/1/
>
>
> Testing
> -------
>
> - unit tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>