[incubator-iceberg] branch master updated: Support calling FileAppender.length during write (#215)

[bl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

blue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new 8bb535e  Support calling FileAppender.length during write (#215)
8bb535e is described below

commit 8bb535ef2f6858e9c157db57ae32892207f77d1d
Author: Daniel Weeks <dw...@apache.org>
AuthorDate: Sat Jun 15 10:57:03 2019 -0700

    Support calling FileAppender.length during write (#215)
---
 api/src/main/java/org/apache/iceberg/io/FileAppender.java              | 2 +-
 core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java       | 3 ---
 .../src/main/java/org/apache/iceberg/parquet/ParquetWriteAdapter.java  | 2 --
 3 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/api/src/main/java/org/apache/iceberg/io/FileAppender.java b/api/src/main/java/org/apache/iceberg/io/FileAppender.java
index 5c6cef2..c02b0ee 100644
--- a/api/src/main/java/org/apache/iceberg/io/FileAppender.java
+++ b/api/src/main/java/org/apache/iceberg/io/FileAppender.java
@@ -43,7 +43,7 @@ public interface FileAppender<D> extends Closeable {
   Metrics metrics();
 
   /**
-   * @return the length of this file. Only valid after the file is closed.
+   * @return the length of this file.
    */
   long length();
 
diff --git a/core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java b/core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java
index 91d12ff..8cc0712 100644
--- a/core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java
+++ b/core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java
@@ -19,7 +19,6 @@
 
 package org.apache.iceberg.avro;
 
-import com.google.common.base.Preconditions;
 import java.io.IOException;
 import java.util.Map;
 import java.util.function.Function;
@@ -62,8 +61,6 @@ class AvroFileAppender<D> implements FileAppender<D> {
 
   @Override
   public long length() {
-    Preconditions.checkState(writer == null,
-        "Cannot return length while appending to an open file.");
     if (stream != null) {
       try {
         return stream.getPos();
diff --git a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriteAdapter.java b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriteAdapter.java
index 292eb89..db51788 100644
--- a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriteAdapter.java
+++ b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriteAdapter.java
@@ -53,8 +53,6 @@ public class ParquetWriteAdapter<D> implements FileAppender<D> {
 
   @Override
   public long length() {
-    Preconditions.checkState(writer == null,
-        "Cannot return length while appending to an open file.");
     return writer.getDataSize();
   }