You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "volosied (via GitHub)" <gi...@apache.org> on 2023/10/11 20:12:18 UTC
[PR] Draft - Spec 1263: Add rowStatePreserved property to UIRepeat (via new class UIIterate) [myfaces]
volosied opened a new pull request, #629:
URL: https://github.com/apache/myfaces/pull/629
`https://github.com/jakartaee/faces/issues/1263`
First attempt at this. Might not be the right approach, but I thought to get feedback.
It's still buggy bug with the one test I've been using, but no regressions seem to occur (thankfully).
I tried to place all similar methods from UIData and UIRepeat into the UIIterate method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Draft - Spec 1263: Add rowStatePreserved property to UIRepeat (via new class UIIterate) [myfaces]
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #629:
URL: https://github.com/apache/myfaces/pull/629#issuecomment-1759761299
I think I'd rather just add the new field rather than make a whole new class. Current UIIterate work will be saved on the `spec1263-uiiterate` branch. I'll update this just to add rowStatePreserved to UIRepeat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Draft - Spec 1263: Add rowStatePreserved property to UIRepeat (via new class UIIterate) [myfaces]
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #629:
URL: https://github.com/apache/myfaces/pull/629#issuecomment-1759779763
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spec 1263: Add rowStatePreserved property to UIRepeat [myfaces]
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko merged PR #629:
URL: https://github.com/apache/myfaces/pull/629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Draft - Spec 1263: Add rowStatePreserved property to UIRepeat (via new class UIIterate) [myfaces]
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #629:
URL: https://github.com/apache/myfaces/pull/629#issuecomment-1759864375
Updated the PR, but I reused many methods from UIData. This shows the necessity to create a super class to share all the overlapping methods, perhaps it can be accomplished in 5.0.
All's that is left to add a junit test and pass the TCK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Draft - Spec 1263: Add rowStatePreserved property to UIRepeat (via new class UIIterate) [myfaces]
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #629:
URL: https://github.com/apache/myfaces/pull/629#issuecomment-1759887857
+1
we need a base class in 5.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org