You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2023/02/20 02:49:09 UTC
Re: Review Request 74310: RANGER-4100: Efficient computation of the smallest set of evaluators returned by search of multiple Trie trees
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74310/
-----------------------------------------------------------
(Updated Feb. 20, 2023, 2:49 a.m.)
Review request for ranger, madhan and Madhan Neethiraj.
Changes
-------
Addressed review comments
Summary (updated)
-----------------
RANGER-4100: Efficient computation of the smallest set of evaluators returned by search of multiple Trie trees
Bugs: RANGER-4100
https://issues.apache.org/jira/browse/RANGER-4100
Repository: ranger
Description (updated)
-------
As The algorithm that computes the intersection of evaluators returned when multiple trie structures are searched depends on the order in which the trie structures are searched. This is sub-optimal, when the evaluators returned by trie structure that is searched earlier happens to be a bigger set then the evaluators by the search of later trie structures.
This Jira updates the intersection computation to be more optimal and not dependent for performance on the order of search of the trie structures.
However, the hierarchy of RangerPolicyEvaluator, RangerResourceEvaluator, RangerPolicyResourceEvaluator has changed in the master branch. I found it hard to use this templatized version in all places where this functionality is needed (PolicyEngine, RangerTagEnricher, RangerPolicyRepository, RangerSecurityZoneValidator, and elsewhere)
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java bbea4cec6
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerSecurityZoneValidator.java f1045ad60
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java f44570623
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceEvaluatorsRetriever.java PRE-CREATION
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 89e678bf9
Diff: https://reviews.apache.org/r/74310/diff/3/
Changes: https://reviews.apache.org/r/74310/diff/2-3/
Testing (updated)
-------
Compiles clean and passes all unit tests.
Thanks,
Abhay Kulkarni
Re: Review Request 74310: RANGER-4100: Efficient computation of the smallest set of evaluators returned by search of multiple Trie trees
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74310/#review225200
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 20, 2023, 2:49 a.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74310/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2023, 2:49 a.m.)
>
>
> Review request for ranger, madhan and Madhan Neethiraj.
>
>
> Bugs: RANGER-4100
> https://issues.apache.org/jira/browse/RANGER-4100
>
>
> Repository: ranger
>
>
> Description
> -------
>
> As The algorithm that computes the intersection of evaluators returned when multiple trie structures are searched depends on the order in which the trie structures are searched. This is sub-optimal, when the evaluators returned by trie structure that is searched earlier happens to be a bigger set then the evaluators by the search of later trie structures.
>
> This Jira updates the intersection computation to be more optimal and not dependent for performance on the order of search of the trie structures.
>
> However, the hierarchy of RangerPolicyEvaluator, RangerResourceEvaluator, RangerPolicyResourceEvaluator has changed in the master branch. I found it hard to use this templatized version in all places where this functionality is needed (PolicyEngine, RangerTagEnricher, RangerPolicyRepository, RangerSecurityZoneValidator, and elsewhere)
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java bbea4cec6
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerSecurityZoneValidator.java f1045ad60
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java f44570623
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceEvaluatorsRetriever.java PRE-CREATION
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 89e678bf9
>
>
> Diff: https://reviews.apache.org/r/74310/diff/3/
>
>
> Testing
> -------
>
> Compiles clean and passes all unit tests.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>