You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2015/12/07 19:41:11 UTC

[jira] [Comment Edited] (LUCENE-6917) Move NumericField out of core to backwards-codecs

    [ https://issues.apache.org/jira/browse/LUCENE-6917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045451#comment-15045451 ] 

David Smiley edited comment on LUCENE-6917 at 12/7/15 6:40 PM:
---------------------------------------------------------------

bq. Because this is the simplest cutover I could do for now. For BBoxStrategy, it would be a major change (you must reindex) to switch from postings to DimensionalValues

Since this is for 6.0, a major release, so this is acceptable.

bq.  I think we should switch over consumers of LegacyNumeric* in follow-on issues?

Okay, if that's how you want to do it.  But I figured the effort (albeit not "large") in using LegacyNumeric could have instead been directed on using DimensionalValues, and in the end there will be less effort to move fully over.  For example adding dependency on backwards-codecs only to then take it away in another issue.  Your call.  Maybe I'm misjudging what's involved in switching to DimensionalValues but I hope it's easy.


was (Author: dsmiley):
bq. Because this is the simplest cutover I could do for now. For
BBoxStrategy, it would be a major change (you must reindex) to
switch from postings to DimensionalValues

Since this is for 6.0, a major release, so this is acceptable.

bq.  I think we should
switch over consumers of LegacyNumeric* in follow-on
issues?

Okay, if that's how you want to do it.  But I figured the effort (albeit not "large") in using LegacyNumeric could have instead been directed on using DimensionalValues, and in the end there will be less effort to move fully over.  For example adding dependency on backwards-codecs only to then take it away in another issue.  Your call.  Maybe I'm misjudging what's involved in switching to DimensionalValues but I hope it's easy.

> Move NumericField out of core to backwards-codecs
> -------------------------------------------------
>
>                 Key: LUCENE-6917
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6917
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 6.0
>
>         Attachments: LUCENE-6917.patch
>
>
> DimensionalValues seems to be better across the board (indexing time, indexing size, search-speed, search-time heap required) than NumericField, at least in my testing so far.
> I think for 6.0 we should move {{IntField}}, {{LongField}}, {{FloatField}}, {{DoubleField}} and {{NumericRangeQuery}} to {{backward-codecs}}, and rename with {{Legacy}} prefix?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org