[jira] [Commented] (QUICKSTEP-114) Upgrade cpplint

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/QUICKSTEP-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300488#comment-16300488 ] 

ASF GitHub Bot commented on QUICKSTEP-114:
------------------------------------------

GitHub user hbdeshmukh opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/328

    QUICKSTEP-114 Upgrade cpplint

    - Added several missing headers.
    - Modified the lint_everything file to add the command line flags.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hbdeshmukh/incubator-quickstep cpplint-upgrade

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/328.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #328
    
----
commit a53696633c5138607109375ee84eba96682fb3f3
Author: Harshad Deshmukh <hb...@...>
Date:   2017-12-19T18:56:36Z

    Upgrade cpplint
    
    - Added several missing headers.
    - Modified the lint_everything file to add the command line flags.

----


> Upgrade cpplint
> ---------------
>
>                 Key: QUICKSTEP-114
>                 URL: https://issues.apache.org/jira/browse/QUICKSTEP-114
>             Project: Apache Quickstep
>          Issue Type: Bug
>            Reporter: Harshad Deshmukh
>            Assignee: Harshad Deshmukh
>            Priority: Minor
>         Attachments: lint-errors.log
>
>
> The cpplint python file is outdated. We rely for the cpplint from https://github.com/google/styleguide here. There are couple of issues with using the style guide from this location: 
> 1. There is no official release.
> 2. The project is not really a python project, there are bunch of HTML, XML files and images which we don't want. We are only interested in the python file.
> Hence we have to manually download the cpplint python file, which is what we have been using until now. To keep track of the version, we can patch the python file with the commit ID. 
> The update means that several of the files will need to be fixed to remove the style errors. The attached file has all these errors. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)