You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2021/03/03 08:06:02 UTC

[camel-kafka-connector] 02/11: Remove unnecessary close calls which are handled by try-with-resources

This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-kafka-connector.git

commit b73b0246df5c18ecc86ba72fdb28b1e294aeb8d6
Author: Otavio Rodolfo Piske <op...@redhat.com>
AuthorDate: Wed Feb 24 11:33:05 2021 +0100

    Remove unnecessary close calls which are handled by try-with-resources
---
 .../kafkaconnector/transforms/SinkPojoToSchemaAndStructTransform.java    | 1 -
 .../java/org/apache/camel/kafkaconnector/maven/utils/MavenUtils.java     | 1 -
 2 files changed, 2 deletions(-)

diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/transforms/SinkPojoToSchemaAndStructTransform.java b/core/src/main/java/org/apache/camel/kafkaconnector/transforms/SinkPojoToSchemaAndStructTransform.java
index b9a59cb..0ccc6fc 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/transforms/SinkPojoToSchemaAndStructTransform.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/transforms/SinkPojoToSchemaAndStructTransform.java
@@ -80,7 +80,6 @@ public class SinkPojoToSchemaAndStructTransform<R extends ConnectRecord<R>> impl
                 encoder.flush();
 
                 byte[] avroData = out.toByteArray();
-                out.close();
                 pojo = objectReader
                         .with(new AvroSchema(avroGenericRecord.getSchema()))
                         .readValue(avroData);
diff --git a/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/MavenUtils.java b/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/MavenUtils.java
index 0a560a7..91a77cd 100644
--- a/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/MavenUtils.java
+++ b/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/MavenUtils.java
@@ -125,7 +125,6 @@ public final class MavenUtils {
                 String oldContent = IOUtils.toString(fr);
                 if (!newContent.equals(oldContent)) {
                     log.debug("Writing new file " + file.getAbsolutePath());
-                    fr.close();
                 } else {
                     log.debug("File " + file.getAbsolutePath() + " has been left unchanged");
                     write = false;