You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@quickstep.apache.org by "Harshad Deshmukh (JIRA)" <ji...@apache.org> on 2016/08/19 03:54:20 UTC
[jira] [Created] (QUICKSTEP-42) Separating WorkOrder proto messages
in individual files
Harshad Deshmukh created QUICKSTEP-42:
-----------------------------------------
Summary: Separating WorkOrder proto messages in individual files
Key: QUICKSTEP-42
URL: https://issues.apache.org/jira/browse/QUICKSTEP-42
Project: Apache Quickstep
Issue Type: Improvement
Components: Relational Operators
Reporter: Harshad Deshmukh
Assignee: Zuyu Zhang
Background: The protocol buffer representation of WorkOrder messages are stored in a single file (relational_operators/WorkOrder.proto). The file contains the message types for every WorkOrder types, which consists of the serializable parameters from the WorkOrder class. Each such parameter has been assigned a unique integer. At the time of filing this issue there are 338 such parameters in the entire file.
Issue: To add a single field in a message type, in the first WorkOrder class message, a developer has to renumber (in the worst case) 338 such parameters. This is a major annoyance from the development point of view.
Possible fixes:
1. I am not quite familiar with protobuf, so I am not sure about this option. Is the numbering of the members necessary? If not, removing the integers assigned to each parameter should be the best option.
2. Removing global ordering of integers. The parameters within each message type has its local numbering, which is independent of the global numbering. Again, I am not sure if this is viable.
3. Moving each message type to its own file, thereby eliminating the need of a global numbering scheme.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)