[GitHub] [pulsar] rdhabalia commented on issue #4523: [pulsar-client] fix protobuf dependency with shaded pulsar-client

[GitBox <gi...@apache.org>]

rdhabalia commented on issue #4523: [pulsar-client] fix protobuf dependency with shaded pulsar-client
URL: https://github.com/apache/pulsar/pull/4523#issuecomment-501557268
 
 
   >  If protobuf-shaded is not added, the shaded client should be always not usable, no?
   
   it doesn't work when we try to exclude all transitive dependencies from it. pulsar-client is a shaded jar so, we don't want to fetch any transitive dependencies from it. So, it throws above RunTimeException when we exclude all the dependencies from it because it excludes protobuf and client-api as well..
   
   ```
     <dependency>
   	<groupId>${cms.groupId}</groupId>
   	<artifactId>pulsar-client</artifactId>
   	<exclusions>
   		<exclusion>
   			<!-- Exclude all dependencies since we're fetching the shaded jar -->
   			<groupId>*</groupId>
   			<artifactId>*</artifactId>
   		</exclusion>
   	</exclusions>
   </dependency>                  
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services