[GitHub] [rocketmq] schnell18 commented on issue #3257: Ignore irrelevant commit log files on startup

[GitBox <gi...@apache.org>]

schnell18 commented on issue #3257:
URL: https://github.com/apache/rocketmq/issues/3257#issuecomment-898884407


   Thank you very much for quick reponse. We had this problem on a 4.6.0 production environment and I also reproduced this problem on 4.8.0. I also looked at the code on master branch. It has same issue.
   
   This problem caused our application lost data due to failure to start the broker w/ empty files under commit log directory. Then the not-so-well-informed admin created an empty commit log directory and make the broker use that. The broker starts up finally. However, almost all our application topics were lost. It took us a few days to recover the messy data caused by this accident. 
   
   RocketMQ is quite reliable and it is definitely unlikely to corrupt the commit log by itself. 
   And commit log file names are 20-digit w/ zero padding. There is no reason to consider irrelevant files, for instance 'the-bad-empty-file-fails-rocketmq-startup', as legitimate commit log and fails the startup. It makes sensible to igore files does not match the commit log name pattern and only fail on real commit log corruption.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org