[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #2012: Qualified wildcard

[GitBox <gi...@apache.org>]

xudong963 commented on a change in pull request #2012:
URL: https://github.com/apache/arrow-datafusion/pull/2012#discussion_r830490270



##########
File path: datafusion-expr/src/expr.rs
##########
@@ -696,6 +700,9 @@ fn create_name(e: &Expr, input_schema: &DFSchema) -> Result<String> {
         Expr::Wildcard => Err(DataFusionError::Internal(
             "Create name does not support wildcard".to_string(),
         )),
+        Expr::QualifiedWildcard { .. } => Err(DataFusionError::Internal(

Review comment:
       Maybe we can create a name for `QualifiedWildcard`?

##########
File path: datafusion-expr/src/expr.rs
##########
@@ -228,6 +228,9 @@ pub enum Expr {
     },
     /// Represents a reference to all fields in a schema.
     Wildcard,
+    QualifiedWildcard {

Review comment:
       It will be better to add extra annotation for `QualifiedWildcard`

##########
File path: datafusion/src/physical_plan/planner.rs
##########
@@ -206,6 +206,9 @@ fn create_physical_name(e: &Expr, is_first_expr: bool) -> Result<String> {
         Expr::Wildcard => Err(DataFusionError::Internal(
             "Create physical name does not support wildcard".to_string(),
         )),
+        Expr::QualifiedWildcard { .. } => Err(DataFusionError::Internal(

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org