[GitHub] [spark] attilapiros commented on a change in pull request #24308: [SPARK-27397][Core] Take care of OpenJ9 JVM in Spark

[GitBox <gi...@apache.org>]

attilapiros commented on a change in pull request #24308: [SPARK-27397][Core] Take care of OpenJ9 JVM in Spark
URL: https://github.com/apache/spark/pull/24308#discussion_r273208974
 
 

 ##########
 File path: launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java
 ##########
 @@ -124,6 +124,9 @@ static JavaVendor getJavaVendor() {
     if (vendorString.contains("OpenJDK")) {
       return JavaVendor.OpenJDK;
     }
+    if (vendorString.contains("OpenJ9")) {
 
 Review comment:
   Do you know who uses this `getJavaVendor` method?
   
   As it is package private so only classes from the same package could access this.
   Could it be a 3rd party tool should use the same package name: `org.apache.spark.launcher`?
   
   As in the entire Spark code there is no usage for it:
   ```
   $ find . -type f -exec grep "getJavaVendor" \{} \; -print
     static JavaVendor getJavaVendor() {
   ./launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org