Re: [jira] Commented: (PIVOT-243) Add Startup Property in KitchenSink Tutorial to load a custom json file for the Skin Colors to use

[Sandro Martini <sa...@gmail.com>]

Hi Todd,
thanks for the help (I didn't looked right at upper classes :-) ), and
I wrote a simple description in JIRA to help me remember what to do
...

Now it's ready, but one question:
- i put the code at the beginning of the startup method, but maybe
this could go before the open of the display ... is it a right place,
so leave where it is ?
- if the given file is not found, at the moment i write an error
message to the console, but do you think we could show it in an Alert
instead (to show also this approach) ?
- loading the other TerraTheme_test.json (already in wtk sources)
doesn't give too much visual differences from the standard colors, so
what do you think if I'd add my test for dark colors in the same dir
of KitchenSink ?

Bye

Re: [jira] Commented: (PIVOT-243) Add Startup Property in KitchenSink Tutorial to load a custom json file for the Skin Colors to use

[Sandro Martini <sa...@gmail.com>]

Hi Todd,
thanks for the hints ... I'll commit in a few minutes.

Tell me if you like this feature.
In the code i put also a comment on how to do to use it, and for
users, the json file is commented so it's more clear what palette
colors are used by the TerraTheme..

Bye

Re: [jira] Commented: (PIVOT-243) Add Startup Property in KitchenSink Tutorial to load a custom json file for the Skin Colors to use

[Todd Volkert <tv...@gmail.com>]

> - i put the code at the beginning of the startup method, but maybe
> this could go before the open of the display ... is it a right place,
> so leave where it is ?
>

Yep - I'd leave it at the beginning of startup.


> - if the given file is not found, at the moment i write an error
> message to the console, but do you think we could show it in an Alert
> instead (to show also this approach) ?
>

The application already shows the use of Alert, so I'd leave it as a
sys-out, but I could go either way.


> - loading the other TerraTheme_test.json (already in wtk sources)
> doesn't give too much visual differences from the standard colors, so
> what do you think if I'd add my test for dark colors in the same dir
> of KitchenSink ?
>

The test should probably eventually move anyway, so I'd add yours next to
the kitchen sink.