You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/04 12:49:58 UTC

[GitHub] [pulsar-helm-chart] EladDolev opened a new pull request #61: anti-affinity rules refactor and default image tags

EladDolev opened a new pull request #61:
URL: https://github.com/apache/pulsar-helm-chart/pull/61


   Fixes default anit-affinity type not being used
   
   ### Motivation
   
   make life easier, fix broken stuff and add the ability to set `topologyKey`
   
   ### Modifications
   
   - add a default image specifications for pulsar components
   - a small refactor to anti-affinity rules, add `topologyKey`, and have defaults work
   - use `publishNotReadyAddresses` correctly, expose it as a parameter, and remove deprecated alpha annotation
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] EladDolev commented on pull request #61: anti-affinity rules refactor and default image tags

Posted by GitBox <gi...@apache.org>.
EladDolev commented on pull request #61:
URL: https://github.com/apache/pulsar-helm-chart/pull/61#issuecomment-687125170


   Hey friends
   
   Thinking of adding the ability to set Pod Topology Spread Constraints and enable them by default
   https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/
   
   Also thinking of updating labels according to best practices
   https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
   https://helm.sh/docs/chart_best_practices/labels/
   
   I can do it on this PR, or create another one
   These are breaking changes BTW


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] sijie commented on pull request #61: anti-affinity rules refactor and default image tags

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #61:
URL: https://github.com/apache/pulsar-helm-chart/pull/61#issuecomment-696283389


   @EladDolev Regarding the breaking changes, it would be good to do it in a separate PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] sijie commented on pull request #61: anti-affinity rules refactor and default image tags

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #61:
URL: https://github.com/apache/pulsar-helm-chart/pull/61#issuecomment-696283389


   @EladDolev Regarding the breaking changes, it would be good to do it in a separate PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #61: anti-affinity rules refactor and default image tags

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #61:
URL: https://github.com/apache/pulsar-helm-chart/pull/61#issuecomment-1015120620


   @EladDolev good work!
   
   > use publishNotReadyAddresses correctly, expose it as a parameter, and remove deprecated alpha annotation
   
   this change would be valuable. Please send it as a separate PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org