You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/28 23:21:27 UTC

[GitHub] [superset] serenajiang opened a new issue #18222: Big Number does not handle DECIMAL metrics

serenajiang opened a new issue #18222:
URL: https://github.com/apache/superset/issues/18222


   If the metric for a big number chart has the type DECIMAL, the chart displays an error: `No data after filtering or data is NULL for the latest time record`
   
   From inspecting the request result for `/api/v1/chart/data`, it seems like this occurs because the decimal is analyzed as a string.
   
   #### How to reproduce the bug
   1. Run query in sqllab: `SELECT CAST(1 AS DECIMAL) AS x, DATE('2022-01-27') AS ds`
   2. Explore chart
   3. Select big number chart, use `SUM(x)` as metric
   4. Run. 
   
   ### Expected results
   
   Chart shows big number with value `1`. Data returned from `/api/v1/chart/data` is `[{SUM(x): 1}]`
   ### Actual results
   Error is shown. Data returned from `/api/v1/chart/data` is `[{SUM(x): "1"}]`
   
   #### Screenshots
   
   ![image](https://user-images.githubusercontent.com/14146019/151634523-9cf3780c-babe-4151-89f8-e01ea4864085.png)
   
   
   ### Environment
   Up to date with apache/master as of 2022-01-26
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [X] I have reproduced the issue with at least the latest released version of superset.
   - [X] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] serenajiang commented on issue #18222: Big Number does not handle DECIMAL metrics

Posted by GitBox <gi...@apache.org>.
serenajiang commented on issue #18222:
URL: https://github.com/apache/superset/issues/18222#issuecomment-1061093350


   I put out a PR in PyHive: https://github.com/dropbox/PyHive/pull/430


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] serenajiang commented on issue #18222: Big Number does not handle DECIMAL metrics

Posted by GitBox <gi...@apache.org>.
serenajiang commented on issue #18222:
URL: https://github.com/apache/superset/issues/18222#issuecomment-1029293843


   @jinghua-qa We deployed master yesterday and I am still able to reproduce this issue :/ Perhaps it is specific to certain SQL engines?
   
   In Presto, the column `x` is identified as a numeric column in explore with data type `DECIMAL(38, 0)`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] jinghua-qa commented on issue #18222: Big Number does not handle DECIMAL metrics

Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on issue #18222:
URL: https://github.com/apache/superset/issues/18222#issuecomment-1029252727


   I can not reproduce in the latest superset master
   
   https://user-images.githubusercontent.com/81597121/152401153-98d97cc7-da11-4102-a7d5-9a860294044b.mov
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] serenajiang closed issue #18222: Big Number does not handle DECIMAL metrics

Posted by GitBox <gi...@apache.org>.
serenajiang closed issue #18222:
URL: https://github.com/apache/superset/issues/18222


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org