You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "DaVincii (via GitHub)" <gi...@apache.org> on 2023/06/23 06:43:21 UTC
[GitHub] [iceberg] DaVincii opened a new issue, #7888: Migrate Files using TestRule in dell package to Junit5
DaVincii opened a new issue, #7888:
URL: https://github.com/apache/iceberg/issues/7888
### Feature Request / Improvement
Some of the files which uses @Rule, @ClassRule or extend TestRule in dell package needs to be migrated to Junit5. These are:
1. EcsS3MockRule
2. TestEcsSeekableInputStream
### Query engine
Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Migrate Files using TestRule in dell package to Junit5 [iceberg]
Posted by "ashutosh-roy (via GitHub)" <gi...@apache.org>.
ashutosh-roy commented on issue #7888:
URL: https://github.com/apache/iceberg/issues/7888#issuecomment-1745440116
Hi @DaVincii, Please provide your feedbacks on the PR for this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Migrate Files using TestRule in dell package to Junit5 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra closed issue #7888: Migrate Files using TestRule in dell package to Junit5
URL: https://github.com/apache/iceberg/issues/7888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Migrate Files using TestRule in dell package to Junit5 [iceberg]
Posted by "DaVincii (via GitHub)" <gi...@apache.org>.
DaVincii commented on issue #7888:
URL: https://github.com/apache/iceberg/issues/7888#issuecomment-1751624255
> Hi @DaVincii, Please provide your feedbacks on the PR for this issue.
Hi @ashutosh-roy, updates looks fine to me but Eduard Tudenhoefner(https://github.com/nastra) would be the best person to accept them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Migrate Files using TestRule in dell package to Junit5 [iceberg]
Posted by "ashutosh-roy (via GitHub)" <gi...@apache.org>.
ashutosh-roy commented on issue #7888:
URL: https://github.com/apache/iceberg/issues/7888#issuecomment-1751713675
Hi @nastra, Please provide your feedbacks on the PR for this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org