You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2017/05/04 08:16:23 UTC

[Bug 61068] New: remove warning of file already exists

https://bz.apache.org/bugzilla/show_bug.cgi?id=61068

            Bug ID: 61068
           Summary: remove warning of file already exists
           Product: JMeter
           Version: 3.2
          Hardware: PC
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: orimarko@gmail.com
  Target Milestone: ---

in jmeter 3.2 I started get a warning when running in GUI mode

for every file I write to there's a popup alert warning of file already exists

Please remove this warning or allow to choose remember my decision

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61068] remove warning of file already exists

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61068

--- Comment #7 from Felix Schumacher <fe...@internetallee.de> ---
(In reply to Philippe Mouawad from comment #4)
> Hi Felix,
> I think it's what you have in mind, but I thought writing it might help us
> find issues:
> 
> 1/ add an option : 'remember my choice for the next popups of this run':
> => User checks the option and clicks his choice
> JMeter remembers this behaviour for next popups
> 
Option 1 was - for me - add a property, that sets the default behaviour. That
would be one of "append", "delete", "ask".


Option 2 was to ask the user the first time and give them an option to apply
the currently used one for further decisions in that JMeter run.

> 2a/ on next run, if user has checked the option, it is still checked and the
> button that he selected previously is focused, so enter key starts the test
> applying his choice
> 
> 2b/ on next run if he hasn't checked the option, same bahaviour as 1/

Option 3 was a combination, where we could remember the choice by setting the
property chosen in 1.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61068] Introduce property "resultcollector.action_if_file_exists" to control the popup "File already exists" when starting a test

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61068

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|remove warning of file      |Introduce property
                   |already exists              |"resultcollector.action_if_
                   |                            |file_exists" to control the
                   |                            |popup "File already exists"
                   |                            |when starting a test

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61068] remove warning of file already exists

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61068

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om

--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hi Felix,
In gui mode, if you have many view results tree, when starting test, a popup
will trigger for every occurence.

Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61068] remove warning of file already exists

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61068

--- Comment #5 from maxime.chassagneux@gmail.com ---
Hi Felix, Philippe

For me, add a properties in jmeter.properties to disable the warning popup is 
good enough because a check box to remember the decision has too much choice :
for one run ? for on jmeter session ? all the time ? how rollback  this choose
? 
But it's as you wish, I can implement the fix as I push this commit first if
you want too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61068] remove warning of file already exists

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61068

Felix Schumacher <fe...@internetallee.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #1 from Felix Schumacher <fe...@internetallee.de> ---
Can you explain a bit more, when the popup occurs?
I think this bug is connected to 58164. The implemented solution right now for
that bug is to use command line parameter "-f" to delete all files that would
get written.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61068] remove warning of file already exists

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61068

orimarko <or...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #6 from orimarko <or...@gmail.com> ---
Behavior before 3.2 was to append to file by default

IMHO I think we should keep behavior as before, 

Append to file by default and allow for each listener to override file  

I think by adding another checkbox per listener - override file

If it's too much trouble I suggest a new property with override/append to
prevent warning popup

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61068] remove warning of file already exists

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61068

--- Comment #8 from Felix Schumacher <fe...@internetallee.de> ---
(In reply to maxime.chassagneux from comment #5)
> Hi Felix, Philippe
> 
> For me, add a properties in jmeter.properties to disable the warning popup
> is  good enough because a check box to remember the decision has too much
> choice : for one run ? for on jmeter session ? all the time ? how rollback 
> this choose ? 
> But it's as you wish, I can implement the fix as I push this commit first if
> you want too.

I think we should start by adding the property, that gets consulted before
displaying the dialog to the user. If it is "ask", the dialog gets displayed,
otherwise the action specified in the property will be chosen.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61068] remove warning of file already exists

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61068

--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hi Felix,
I think it's what you have in mind, but I thought writing it might help us find
issues:

1/ add an option : 'remember my choice for the next popups of this run':
=> User checks the option and clicks his choice
JMeter remembers this behaviour for next popups

2a/ on next run, if user has checked the option, it is still checked and the
button that he selected previously is focused, so enter key starts the test
applying his choice

2b/ on next run if he hasn't checked the option, same bahaviour as 1/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61068] remove warning of file already exists

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61068

orimarko <or...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61068] Introduce property "resultcollector.action_if_file_exists" to control the popup "File already exists" when starting a test

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61068

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
           Hardware|PC                          |All

--- Comment #9 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Jul 23 13:57:20 2017
New Revision: 1802724

URL: http://svn.apache.org/viewvc?rev=1802724&view=rev
Log:
Bug 61068 - Introduce property "resultcollector.action_if_file_exists" to
control the popup "File already exists" when starting a test
Bugzilla Id: 61068

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/AbstractAction.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/properties_reference.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61068] Introduce property "resultcollector.action_if_file_exists" to control the popup "File already exists" when starting a test

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61068

--- Comment #10 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Jul 23 14:04:17 2017
New Revision: 1802727

URL: http://svn.apache.org/viewvc?rev=1802727&view=rev
Log:
Bug 61068 - Introduce property "resultcollector.action_if_file_exists" to
control the popup "File already exists" when starting a test
Mention property in popup
Bugzilla Id: 61068

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61068] remove warning of file already exists

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61068

--- Comment #3 from Felix Schumacher <fe...@internetallee.de> ---
Created attachment 34999
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34999&action=edit
Dialog asking to overwrite results will be shown on each run

Ok, I see the dialog. I have attached a short test plan, that demonstrates the
behaviour on the second run. It will display two dialogs - one after another -
that ask how to continue with the result files.

Should we
a) add an option to pre-select a default behaviour?
b) add a gui option to remember the last selected behaviour for the next
dialogs?
c) a) and b)?

-- 
You are receiving this mail because:
You are the assignee for the bug.