You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/01/18 22:35:44 UTC
[GitHub] [nifi] bbende opened a new pull request #5668: NIFI-9570 Separate classpath for NiFi Registry sensitive property pro…
bbende opened a new pull request #5668:
URL: https://github.com/apache/nifi/pull/5668
…viders
This PR creates `lib/spp` under NiFi Registry's lib directory to isolate all of the sensitive property provider dependencies, and also separates `NiFiRegistryPropertiesLoader` into it's own module. It then uses a similar approach from `NiFi` to load `NiFiRegistryPropertiesLoader` via reflection in `NiFiRegistry` using a special ClassLoader that has `lib/spp` resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #5668: NIFI-9570 Separate classpath for NiFi Registry sensitive property pro…
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #5668:
URL: https://github.com/apache/nifi/pull/5668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #5668: NIFI-9570 Separate classpath for NiFi Registry sensitive property pro…
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #5668:
URL: https://github.com/apache/nifi/pull/5668#issuecomment-1020139776
@exceptionfactory pushed a new commit that cleans up the test resources... from the original resources, the bootstrap ones were needed only by nifi-registry-properties and the nifi-registry.properties ones were needed only by nifi-registry-properties-loader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #5668: NIFI-9570 Separate classpath for NiFi Registry sensitive property pro…
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on pull request #5668:
URL: https://github.com/apache/nifi/pull/5668#issuecomment-1018860318
Thanks for the improvement @bbende! The pull request appears to include a number of test properties files, are all of those necessary as part of this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #5668: NIFI-9570 Separate classpath for NiFi Registry sensitive property pro…
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #5668:
URL: https://github.com/apache/nifi/pull/5668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #5668: NIFI-9570 Separate classpath for NiFi Registry sensitive property pro…
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #5668:
URL: https://github.com/apache/nifi/pull/5668#issuecomment-1018885544
@exceptionfactory thanks for taking a look... as part of splitting apart the properties and properties loader, there was also a test class for properties loader that used several of these files. At the time I was mostly trying to get the tests passing and just duplicated the resources, so we can probably narrow it down a little bit, a bunch of them are used though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #5668: NIFI-9570 Separate classpath for NiFi Registry sensitive property pro…
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on pull request #5668:
URL: https://github.com/apache/nifi/pull/5668#issuecomment-1018886341
Thanks @bbende, if there is an opportunity to cut down the number of test cases and corresponding properties files, that would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org