You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@issues.apache.org on 2011/01/26 10:16:04 UTC

[Bug 6540] New: wildcard in unwhitelist_from example is incorrect

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6540

           Summary: wildcard in unwhitelist_from example is incorrect
           Product: Spamassassin
           Version: 3.3.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Documentation
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: lemke@jam-software.com


Just seen there's a wildcard used for an example in the unwhitelist_from
documentation. Am I right that this is not allowed for unwhitelist_from so the
example should be removed from the documentation?

http://spamassassin.apache.org/full/3.3.x/doc/Mail_SpamAssassin_Conf.html

Daniel

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6540] wildcard in unwhitelist_from example is incorrect

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6540

--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2011-01-26 08:36:03 EST ---
> Just seen there's a wildcard used for an example in the unwhitelist_from
> documentation. Am I right that this is not allowed for unwhitelist_from
> so the example should be removed from the documentation?

No, the example is alright. A wildcard in unwhitelist_from only matches
literally a wildcard in the whitelist_from list. This makes it possibly
to remove a previously entered wildcard entry from the list.

I'll attach a documentation update, I hope this would make it more clear.

But examining the code I noticed that whitelist_from lowercases its
argument and stores it this way in the list, while the unwhitelist
counterpart forgets to lowercase its argument. Same applies to
unwhitelist_from_rcvd. The attached patch should fix it.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6540] [review] wildcard in unwhitelist_from example is incorrect

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6540

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@pccc.com
  Status Whiteboard|needs 2 votes               |needs 1 votes

--- Comment #3 from Kevin A. McGrail <km...@pccc.com> 2011-03-24 10:59:02 EDT ---
(In reply to comment #2)
> Created an attachment (id=4844)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4844) [details]
> lowercase address in unwhitelist_*, documentation clarification
> 
> trunk:
>   Bug 6540: lowercase address in unwhitelist_*, documentation clarification
> Sending lib/Mail/SpamAssassin/Conf/Parser.pm
> Sending lib/Mail/SpamAssassin/Conf.pm
> Committed revision 1063713.

+1

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6540] wildcard in unwhitelist_from example is incorrect

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6540

--- Comment #2 from Mark Martinec <Ma...@ijs.si> 2011-01-26 08:42:12 EST ---
Created an attachment (id=4844)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4844)
lowercase address in unwhitelist_*, documentation clarification

trunk:
  Bug 6540: lowercase address in unwhitelist_*, documentation clarification
Sending lib/Mail/SpamAssassin/Conf/Parser.pm
Sending lib/Mail/SpamAssassin/Conf.pm
Committed revision 1063713.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6540] [review] wildcard in unwhitelist_from example is incorrect

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6540

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.4.0
            Summary|wildcard in                 |[review] wildcard in
                   |unwhitelist_from example is |unwhitelist_from example is
                   |incorrect                   |incorrect
  Status Whiteboard|                            |needs 2 votes

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6540] [review] wildcard in unwhitelist_from example is incorrect

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6540

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
  Status Whiteboard|needs 1 votes               |

--- Comment #4 from Mark Martinec <Ma...@ijs.si> 2011-05-23 23:13:10 UTC ---
Closing. In trunk, target 3.4.0.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.