You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/04/19 14:46:53 UTC
[26/43] hbase-site git commit: Published site at
556b22374423ff087c0583d02ae4298d4d4f2e6b.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/ede30993/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactingMemStore.InMemoryFlushRunnable.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactingMemStore.InMemoryFlushRunnable.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactingMemStore.InMemoryFlushRunnable.html
index 22e7059..01b8a09 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactingMemStore.InMemoryFlushRunnable.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactingMemStore.InMemoryFlushRunnable.html
@@ -362,235 +362,231 @@
<span class="sourceLineNo">354</span> }<a name="line.354"></a>
<span class="sourceLineNo">355</span><a name="line.355"></a>
<span class="sourceLineNo">356</span> @Override<a name="line.356"></a>
-<span class="sourceLineNo">357</span> /*<a name="line.357"></a>
-<span class="sourceLineNo">358</span> * Scanners are ordered from 0 (oldest) to newest in increasing order.<a name="line.358"></a>
-<span class="sourceLineNo">359</span> */<a name="line.359"></a>
-<span class="sourceLineNo">360</span> public List<KeyValueScanner> getScanners(long readPt) throws IOException {<a name="line.360"></a>
-<span class="sourceLineNo">361</span> MutableSegment activeTmp = active;<a name="line.361"></a>
-<span class="sourceLineNo">362</span> List<? extends Segment> pipelineList = pipeline.getSegments();<a name="line.362"></a>
-<span class="sourceLineNo">363</span> List<? extends Segment> snapshotList = snapshot.getAllSegments();<a name="line.363"></a>
-<span class="sourceLineNo">364</span> long order = 1L + pipelineList.size() + snapshotList.size();<a name="line.364"></a>
-<span class="sourceLineNo">365</span> // The list of elements in pipeline + the active element + the snapshot segment<a name="line.365"></a>
-<span class="sourceLineNo">366</span> // The order is the Segment ordinal<a name="line.366"></a>
-<span class="sourceLineNo">367</span> List<KeyValueScanner> list = createList((int) order);<a name="line.367"></a>
-<span class="sourceLineNo">368</span> order = addToScanners(activeTmp, readPt, order, list);<a name="line.368"></a>
-<span class="sourceLineNo">369</span> order = addToScanners(pipelineList, readPt, order, list);<a name="line.369"></a>
-<span class="sourceLineNo">370</span> addToScanners(snapshotList, readPt, order, list);<a name="line.370"></a>
-<span class="sourceLineNo">371</span> return list;<a name="line.371"></a>
-<span class="sourceLineNo">372</span> }<a name="line.372"></a>
-<span class="sourceLineNo">373</span><a name="line.373"></a>
-<span class="sourceLineNo">374</span> @VisibleForTesting<a name="line.374"></a>
-<span class="sourceLineNo">375</span> protected List<KeyValueScanner> createList(int capacity) {<a name="line.375"></a>
-<span class="sourceLineNo">376</span> return new ArrayList<>(capacity);<a name="line.376"></a>
-<span class="sourceLineNo">377</span> }<a name="line.377"></a>
-<span class="sourceLineNo">378</span><a name="line.378"></a>
-<span class="sourceLineNo">379</span> /**<a name="line.379"></a>
-<span class="sourceLineNo">380</span> * Check whether anything need to be done based on the current active set size.<a name="line.380"></a>
-<span class="sourceLineNo">381</span> * The method is invoked upon every addition to the active set.<a name="line.381"></a>
-<span class="sourceLineNo">382</span> * For CompactingMemStore, flush the active set to the read-only memory if it's<a name="line.382"></a>
-<span class="sourceLineNo">383</span> * size is above threshold<a name="line.383"></a>
-<span class="sourceLineNo">384</span> */<a name="line.384"></a>
-<span class="sourceLineNo">385</span> @Override<a name="line.385"></a>
-<span class="sourceLineNo">386</span> protected void checkActiveSize() {<a name="line.386"></a>
-<span class="sourceLineNo">387</span> if (shouldFlushInMemory()) {<a name="line.387"></a>
-<span class="sourceLineNo">388</span> /* The thread is dispatched to flush-in-memory. This cannot be done<a name="line.388"></a>
-<span class="sourceLineNo">389</span> * on the same thread, because for flush-in-memory we require updatesLock<a name="line.389"></a>
-<span class="sourceLineNo">390</span> * in exclusive mode while this method (checkActiveSize) is invoked holding updatesLock<a name="line.390"></a>
-<span class="sourceLineNo">391</span> * in the shared mode. */<a name="line.391"></a>
-<span class="sourceLineNo">392</span> InMemoryFlushRunnable runnable = new InMemoryFlushRunnable();<a name="line.392"></a>
-<span class="sourceLineNo">393</span> if (LOG.isTraceEnabled()) {<a name="line.393"></a>
-<span class="sourceLineNo">394</span> LOG.trace(<a name="line.394"></a>
-<span class="sourceLineNo">395</span> "Dispatching the MemStore in-memory flush for store " + store.getColumnFamilyName());<a name="line.395"></a>
-<span class="sourceLineNo">396</span> }<a name="line.396"></a>
-<span class="sourceLineNo">397</span> getPool().execute(runnable);<a name="line.397"></a>
-<span class="sourceLineNo">398</span> }<a name="line.398"></a>
-<span class="sourceLineNo">399</span> }<a name="line.399"></a>
-<span class="sourceLineNo">400</span><a name="line.400"></a>
-<span class="sourceLineNo">401</span> // internally used method, externally visible only for tests<a name="line.401"></a>
-<span class="sourceLineNo">402</span> // when invoked directly from tests it must be verified that the caller doesn't hold updatesLock,<a name="line.402"></a>
-<span class="sourceLineNo">403</span> // otherwise there is a deadlock<a name="line.403"></a>
-<span class="sourceLineNo">404</span> @VisibleForTesting<a name="line.404"></a>
-<span class="sourceLineNo">405</span> void flushInMemory() throws IOException {<a name="line.405"></a>
-<span class="sourceLineNo">406</span> // setting the inMemoryFlushInProgress flag again for the case this method is invoked<a name="line.406"></a>
-<span class="sourceLineNo">407</span> // directly (only in tests) in the common path setting from true to true is idempotent<a name="line.407"></a>
-<span class="sourceLineNo">408</span> inMemoryFlushInProgress.set(true);<a name="line.408"></a>
-<span class="sourceLineNo">409</span> try {<a name="line.409"></a>
-<span class="sourceLineNo">410</span> // Phase I: Update the pipeline<a name="line.410"></a>
-<span class="sourceLineNo">411</span> getRegionServices().blockUpdates();<a name="line.411"></a>
-<span class="sourceLineNo">412</span> try {<a name="line.412"></a>
-<span class="sourceLineNo">413</span> LOG.trace("IN-MEMORY FLUSH: Pushing active segment into compaction pipeline");<a name="line.413"></a>
-<span class="sourceLineNo">414</span> pushActiveToPipeline(this.active);<a name="line.414"></a>
-<span class="sourceLineNo">415</span> } finally {<a name="line.415"></a>
-<span class="sourceLineNo">416</span> getRegionServices().unblockUpdates();<a name="line.416"></a>
-<span class="sourceLineNo">417</span> }<a name="line.417"></a>
-<span class="sourceLineNo">418</span><a name="line.418"></a>
-<span class="sourceLineNo">419</span> // Used by tests<a name="line.419"></a>
-<span class="sourceLineNo">420</span> if (!allowCompaction.get()) {<a name="line.420"></a>
-<span class="sourceLineNo">421</span> return;<a name="line.421"></a>
-<span class="sourceLineNo">422</span> }<a name="line.422"></a>
-<span class="sourceLineNo">423</span> // Phase II: Compact the pipeline<a name="line.423"></a>
-<span class="sourceLineNo">424</span> try {<a name="line.424"></a>
-<span class="sourceLineNo">425</span> // Speculative compaction execution, may be interrupted if flush is forced while<a name="line.425"></a>
-<span class="sourceLineNo">426</span> // compaction is in progress<a name="line.426"></a>
-<span class="sourceLineNo">427</span> compactor.start();<a name="line.427"></a>
-<span class="sourceLineNo">428</span> } catch (IOException e) {<a name="line.428"></a>
-<span class="sourceLineNo">429</span> LOG.warn("Unable to run in-memory compaction on {}/{}; exception={}",<a name="line.429"></a>
-<span class="sourceLineNo">430</span> getRegionServices().getRegionInfo().getEncodedName(), getFamilyName(), e);<a name="line.430"></a>
-<span class="sourceLineNo">431</span> }<a name="line.431"></a>
-<span class="sourceLineNo">432</span> } finally {<a name="line.432"></a>
-<span class="sourceLineNo">433</span> inMemoryFlushInProgress.set(false);<a name="line.433"></a>
-<span class="sourceLineNo">434</span> LOG.trace("IN-MEMORY FLUSH: end");<a name="line.434"></a>
-<span class="sourceLineNo">435</span> }<a name="line.435"></a>
-<span class="sourceLineNo">436</span> }<a name="line.436"></a>
-<span class="sourceLineNo">437</span><a name="line.437"></a>
-<span class="sourceLineNo">438</span> private Segment getLastSegment() {<a name="line.438"></a>
-<span class="sourceLineNo">439</span> Segment localActive = getActive();<a name="line.439"></a>
-<span class="sourceLineNo">440</span> Segment tail = pipeline.getTail();<a name="line.440"></a>
-<span class="sourceLineNo">441</span> return tail == null ? localActive : tail;<a name="line.441"></a>
+<span class="sourceLineNo">357</span> public List<KeyValueScanner> getScanners(long readPt) throws IOException {<a name="line.357"></a>
+<span class="sourceLineNo">358</span> MutableSegment activeTmp = active;<a name="line.358"></a>
+<span class="sourceLineNo">359</span> List<? extends Segment> pipelineList = pipeline.getSegments();<a name="line.359"></a>
+<span class="sourceLineNo">360</span> List<? extends Segment> snapshotList = snapshot.getAllSegments();<a name="line.360"></a>
+<span class="sourceLineNo">361</span> long numberOfSegments = 1L + pipelineList.size() + snapshotList.size();<a name="line.361"></a>
+<span class="sourceLineNo">362</span> // The list of elements in pipeline + the active element + the snapshot segment<a name="line.362"></a>
+<span class="sourceLineNo">363</span> List<KeyValueScanner> list = createList((int) numberOfSegments);<a name="line.363"></a>
+<span class="sourceLineNo">364</span> addToScanners(activeTmp, readPt, list);<a name="line.364"></a>
+<span class="sourceLineNo">365</span> addToScanners(pipelineList, readPt, list);<a name="line.365"></a>
+<span class="sourceLineNo">366</span> addToScanners(snapshotList, readPt, list);<a name="line.366"></a>
+<span class="sourceLineNo">367</span> return list;<a name="line.367"></a>
+<span class="sourceLineNo">368</span> }<a name="line.368"></a>
+<span class="sourceLineNo">369</span><a name="line.369"></a>
+<span class="sourceLineNo">370</span> @VisibleForTesting<a name="line.370"></a>
+<span class="sourceLineNo">371</span> protected List<KeyValueScanner> createList(int capacity) {<a name="line.371"></a>
+<span class="sourceLineNo">372</span> return new ArrayList<>(capacity);<a name="line.372"></a>
+<span class="sourceLineNo">373</span> }<a name="line.373"></a>
+<span class="sourceLineNo">374</span><a name="line.374"></a>
+<span class="sourceLineNo">375</span> /**<a name="line.375"></a>
+<span class="sourceLineNo">376</span> * Check whether anything need to be done based on the current active set size.<a name="line.376"></a>
+<span class="sourceLineNo">377</span> * The method is invoked upon every addition to the active set.<a name="line.377"></a>
+<span class="sourceLineNo">378</span> * For CompactingMemStore, flush the active set to the read-only memory if it's<a name="line.378"></a>
+<span class="sourceLineNo">379</span> * size is above threshold<a name="line.379"></a>
+<span class="sourceLineNo">380</span> */<a name="line.380"></a>
+<span class="sourceLineNo">381</span> @Override<a name="line.381"></a>
+<span class="sourceLineNo">382</span> protected void checkActiveSize() {<a name="line.382"></a>
+<span class="sourceLineNo">383</span> if (shouldFlushInMemory()) {<a name="line.383"></a>
+<span class="sourceLineNo">384</span> /* The thread is dispatched to flush-in-memory. This cannot be done<a name="line.384"></a>
+<span class="sourceLineNo">385</span> * on the same thread, because for flush-in-memory we require updatesLock<a name="line.385"></a>
+<span class="sourceLineNo">386</span> * in exclusive mode while this method (checkActiveSize) is invoked holding updatesLock<a name="line.386"></a>
+<span class="sourceLineNo">387</span> * in the shared mode. */<a name="line.387"></a>
+<span class="sourceLineNo">388</span> InMemoryFlushRunnable runnable = new InMemoryFlushRunnable();<a name="line.388"></a>
+<span class="sourceLineNo">389</span> if (LOG.isTraceEnabled()) {<a name="line.389"></a>
+<span class="sourceLineNo">390</span> LOG.trace(<a name="line.390"></a>
+<span class="sourceLineNo">391</span> "Dispatching the MemStore in-memory flush for store " + store.getColumnFamilyName());<a name="line.391"></a>
+<span class="sourceLineNo">392</span> }<a name="line.392"></a>
+<span class="sourceLineNo">393</span> getPool().execute(runnable);<a name="line.393"></a>
+<span class="sourceLineNo">394</span> }<a name="line.394"></a>
+<span class="sourceLineNo">395</span> }<a name="line.395"></a>
+<span class="sourceLineNo">396</span><a name="line.396"></a>
+<span class="sourceLineNo">397</span> // internally used method, externally visible only for tests<a name="line.397"></a>
+<span class="sourceLineNo">398</span> // when invoked directly from tests it must be verified that the caller doesn't hold updatesLock,<a name="line.398"></a>
+<span class="sourceLineNo">399</span> // otherwise there is a deadlock<a name="line.399"></a>
+<span class="sourceLineNo">400</span> @VisibleForTesting<a name="line.400"></a>
+<span class="sourceLineNo">401</span> void flushInMemory() throws IOException {<a name="line.401"></a>
+<span class="sourceLineNo">402</span> // setting the inMemoryFlushInProgress flag again for the case this method is invoked<a name="line.402"></a>
+<span class="sourceLineNo">403</span> // directly (only in tests) in the common path setting from true to true is idempotent<a name="line.403"></a>
+<span class="sourceLineNo">404</span> inMemoryFlushInProgress.set(true);<a name="line.404"></a>
+<span class="sourceLineNo">405</span> try {<a name="line.405"></a>
+<span class="sourceLineNo">406</span> // Phase I: Update the pipeline<a name="line.406"></a>
+<span class="sourceLineNo">407</span> getRegionServices().blockUpdates();<a name="line.407"></a>
+<span class="sourceLineNo">408</span> try {<a name="line.408"></a>
+<span class="sourceLineNo">409</span> LOG.trace("IN-MEMORY FLUSH: Pushing active segment into compaction pipeline");<a name="line.409"></a>
+<span class="sourceLineNo">410</span> pushActiveToPipeline(this.active);<a name="line.410"></a>
+<span class="sourceLineNo">411</span> } finally {<a name="line.411"></a>
+<span class="sourceLineNo">412</span> getRegionServices().unblockUpdates();<a name="line.412"></a>
+<span class="sourceLineNo">413</span> }<a name="line.413"></a>
+<span class="sourceLineNo">414</span><a name="line.414"></a>
+<span class="sourceLineNo">415</span> // Used by tests<a name="line.415"></a>
+<span class="sourceLineNo">416</span> if (!allowCompaction.get()) {<a name="line.416"></a>
+<span class="sourceLineNo">417</span> return;<a name="line.417"></a>
+<span class="sourceLineNo">418</span> }<a name="line.418"></a>
+<span class="sourceLineNo">419</span> // Phase II: Compact the pipeline<a name="line.419"></a>
+<span class="sourceLineNo">420</span> try {<a name="line.420"></a>
+<span class="sourceLineNo">421</span> // Speculative compaction execution, may be interrupted if flush is forced while<a name="line.421"></a>
+<span class="sourceLineNo">422</span> // compaction is in progress<a name="line.422"></a>
+<span class="sourceLineNo">423</span> compactor.start();<a name="line.423"></a>
+<span class="sourceLineNo">424</span> } catch (IOException e) {<a name="line.424"></a>
+<span class="sourceLineNo">425</span> LOG.warn("Unable to run in-memory compaction on {}/{}; exception={}",<a name="line.425"></a>
+<span class="sourceLineNo">426</span> getRegionServices().getRegionInfo().getEncodedName(), getFamilyName(), e);<a name="line.426"></a>
+<span class="sourceLineNo">427</span> }<a name="line.427"></a>
+<span class="sourceLineNo">428</span> } finally {<a name="line.428"></a>
+<span class="sourceLineNo">429</span> inMemoryFlushInProgress.set(false);<a name="line.429"></a>
+<span class="sourceLineNo">430</span> LOG.trace("IN-MEMORY FLUSH: end");<a name="line.430"></a>
+<span class="sourceLineNo">431</span> }<a name="line.431"></a>
+<span class="sourceLineNo">432</span> }<a name="line.432"></a>
+<span class="sourceLineNo">433</span><a name="line.433"></a>
+<span class="sourceLineNo">434</span> private Segment getLastSegment() {<a name="line.434"></a>
+<span class="sourceLineNo">435</span> Segment localActive = getActive();<a name="line.435"></a>
+<span class="sourceLineNo">436</span> Segment tail = pipeline.getTail();<a name="line.436"></a>
+<span class="sourceLineNo">437</span> return tail == null ? localActive : tail;<a name="line.437"></a>
+<span class="sourceLineNo">438</span> }<a name="line.438"></a>
+<span class="sourceLineNo">439</span><a name="line.439"></a>
+<span class="sourceLineNo">440</span> private byte[] getFamilyNameInBytes() {<a name="line.440"></a>
+<span class="sourceLineNo">441</span> return store.getColumnFamilyDescriptor().getName();<a name="line.441"></a>
<span class="sourceLineNo">442</span> }<a name="line.442"></a>
<span class="sourceLineNo">443</span><a name="line.443"></a>
-<span class="sourceLineNo">444</span> private byte[] getFamilyNameInBytes() {<a name="line.444"></a>
-<span class="sourceLineNo">445</span> return store.getColumnFamilyDescriptor().getName();<a name="line.445"></a>
+<span class="sourceLineNo">444</span> private ThreadPoolExecutor getPool() {<a name="line.444"></a>
+<span class="sourceLineNo">445</span> return getRegionServices().getInMemoryCompactionPool();<a name="line.445"></a>
<span class="sourceLineNo">446</span> }<a name="line.446"></a>
<span class="sourceLineNo">447</span><a name="line.447"></a>
-<span class="sourceLineNo">448</span> private ThreadPoolExecutor getPool() {<a name="line.448"></a>
-<span class="sourceLineNo">449</span> return getRegionServices().getInMemoryCompactionPool();<a name="line.449"></a>
-<span class="sourceLineNo">450</span> }<a name="line.450"></a>
-<span class="sourceLineNo">451</span><a name="line.451"></a>
-<span class="sourceLineNo">452</span> @VisibleForTesting<a name="line.452"></a>
-<span class="sourceLineNo">453</span> protected boolean shouldFlushInMemory() {<a name="line.453"></a>
-<span class="sourceLineNo">454</span> if (this.active.keySize() > inmemoryFlushSize) { // size above flush threshold<a name="line.454"></a>
-<span class="sourceLineNo">455</span> if (inWalReplay) { // when replaying edits from WAL there is no need in in-memory flush<a name="line.455"></a>
-<span class="sourceLineNo">456</span> return false; // regardless the size<a name="line.456"></a>
-<span class="sourceLineNo">457</span> }<a name="line.457"></a>
-<span class="sourceLineNo">458</span> // the inMemoryFlushInProgress is CASed to be true here in order to mutual exclude<a name="line.458"></a>
-<span class="sourceLineNo">459</span> // the insert of the active into the compaction pipeline<a name="line.459"></a>
-<span class="sourceLineNo">460</span> return (inMemoryFlushInProgress.compareAndSet(false,true));<a name="line.460"></a>
-<span class="sourceLineNo">461</span> }<a name="line.461"></a>
-<span class="sourceLineNo">462</span> return false;<a name="line.462"></a>
-<span class="sourceLineNo">463</span> }<a name="line.463"></a>
-<span class="sourceLineNo">464</span><a name="line.464"></a>
-<span class="sourceLineNo">465</span> /**<a name="line.465"></a>
-<span class="sourceLineNo">466</span> * The request to cancel the compaction asynchronous task (caused by in-memory flush)<a name="line.466"></a>
-<span class="sourceLineNo">467</span> * The compaction may still happen if the request was sent too late<a name="line.467"></a>
-<span class="sourceLineNo">468</span> * Non-blocking request<a name="line.468"></a>
-<span class="sourceLineNo">469</span> */<a name="line.469"></a>
-<span class="sourceLineNo">470</span> private void stopCompaction() {<a name="line.470"></a>
-<span class="sourceLineNo">471</span> if (inMemoryFlushInProgress.get()) {<a name="line.471"></a>
-<span class="sourceLineNo">472</span> compactor.stop();<a name="line.472"></a>
-<span class="sourceLineNo">473</span> }<a name="line.473"></a>
-<span class="sourceLineNo">474</span> }<a name="line.474"></a>
-<span class="sourceLineNo">475</span><a name="line.475"></a>
-<span class="sourceLineNo">476</span> protected void pushActiveToPipeline(MutableSegment active) {<a name="line.476"></a>
-<span class="sourceLineNo">477</span> if (!active.isEmpty()) {<a name="line.477"></a>
-<span class="sourceLineNo">478</span> pipeline.pushHead(active);<a name="line.478"></a>
-<span class="sourceLineNo">479</span> resetActive();<a name="line.479"></a>
-<span class="sourceLineNo">480</span> }<a name="line.480"></a>
-<span class="sourceLineNo">481</span> }<a name="line.481"></a>
-<span class="sourceLineNo">482</span><a name="line.482"></a>
-<span class="sourceLineNo">483</span> private void pushTailToSnapshot() {<a name="line.483"></a>
-<span class="sourceLineNo">484</span> VersionedSegmentsList segments = pipeline.getVersionedTail();<a name="line.484"></a>
-<span class="sourceLineNo">485</span> pushToSnapshot(segments.getStoreSegments());<a name="line.485"></a>
-<span class="sourceLineNo">486</span> // In Swap: don't close segments (they are in snapshot now) and don't update the region size<a name="line.486"></a>
-<span class="sourceLineNo">487</span> pipeline.swap(segments,null,false, false);<a name="line.487"></a>
-<span class="sourceLineNo">488</span> }<a name="line.488"></a>
-<span class="sourceLineNo">489</span><a name="line.489"></a>
-<span class="sourceLineNo">490</span> private void pushPipelineToSnapshot() {<a name="line.490"></a>
-<span class="sourceLineNo">491</span> int iterationsCnt = 0;<a name="line.491"></a>
-<span class="sourceLineNo">492</span> boolean done = false;<a name="line.492"></a>
-<span class="sourceLineNo">493</span> while (!done) {<a name="line.493"></a>
-<span class="sourceLineNo">494</span> iterationsCnt++;<a name="line.494"></a>
-<span class="sourceLineNo">495</span> VersionedSegmentsList segments = pipeline.getVersionedList();<a name="line.495"></a>
-<span class="sourceLineNo">496</span> pushToSnapshot(segments.getStoreSegments());<a name="line.496"></a>
-<span class="sourceLineNo">497</span> // swap can return false in case the pipeline was updated by ongoing compaction<a name="line.497"></a>
-<span class="sourceLineNo">498</span> // and the version increase, the chance of it happenning is very low<a name="line.498"></a>
-<span class="sourceLineNo">499</span> // In Swap: don't close segments (they are in snapshot now) and don't update the region size<a name="line.499"></a>
-<span class="sourceLineNo">500</span> done = pipeline.swap(segments, null, false, false);<a name="line.500"></a>
-<span class="sourceLineNo">501</span> if (iterationsCnt>2) {<a name="line.501"></a>
-<span class="sourceLineNo">502</span> // practically it is impossible that this loop iterates more than two times<a name="line.502"></a>
-<span class="sourceLineNo">503</span> // (because the compaction is stopped and none restarts it while in snapshot request),<a name="line.503"></a>
-<span class="sourceLineNo">504</span> // however stopping here for the case of the infinite loop causing by any error<a name="line.504"></a>
-<span class="sourceLineNo">505</span> LOG.warn("Multiple unsuccessful attempts to push the compaction pipeline to snapshot," +<a name="line.505"></a>
-<span class="sourceLineNo">506</span> " while flushing to disk.");<a name="line.506"></a>
-<span class="sourceLineNo">507</span> this.snapshot = SegmentFactory.instance().createImmutableSegment(getComparator());<a name="line.507"></a>
-<span class="sourceLineNo">508</span> break;<a name="line.508"></a>
-<span class="sourceLineNo">509</span> }<a name="line.509"></a>
-<span class="sourceLineNo">510</span> }<a name="line.510"></a>
-<span class="sourceLineNo">511</span> }<a name="line.511"></a>
-<span class="sourceLineNo">512</span><a name="line.512"></a>
-<span class="sourceLineNo">513</span> private void pushToSnapshot(List<ImmutableSegment> segments) {<a name="line.513"></a>
-<span class="sourceLineNo">514</span> if(segments.isEmpty()) return;<a name="line.514"></a>
-<span class="sourceLineNo">515</span> if(segments.size() == 1 && !segments.get(0).isEmpty()) {<a name="line.515"></a>
-<span class="sourceLineNo">516</span> this.snapshot = segments.get(0);<a name="line.516"></a>
-<span class="sourceLineNo">517</span> return;<a name="line.517"></a>
-<span class="sourceLineNo">518</span> } else { // create composite snapshot<a name="line.518"></a>
-<span class="sourceLineNo">519</span> this.snapshot =<a name="line.519"></a>
-<span class="sourceLineNo">520</span> SegmentFactory.instance().createCompositeImmutableSegment(getComparator(), segments);<a name="line.520"></a>
-<span class="sourceLineNo">521</span> }<a name="line.521"></a>
+<span class="sourceLineNo">448</span> @VisibleForTesting<a name="line.448"></a>
+<span class="sourceLineNo">449</span> protected boolean shouldFlushInMemory() {<a name="line.449"></a>
+<span class="sourceLineNo">450</span> if (this.active.keySize() > inmemoryFlushSize) { // size above flush threshold<a name="line.450"></a>
+<span class="sourceLineNo">451</span> if (inWalReplay) { // when replaying edits from WAL there is no need in in-memory flush<a name="line.451"></a>
+<span class="sourceLineNo">452</span> return false; // regardless the size<a name="line.452"></a>
+<span class="sourceLineNo">453</span> }<a name="line.453"></a>
+<span class="sourceLineNo">454</span> // the inMemoryFlushInProgress is CASed to be true here in order to mutual exclude<a name="line.454"></a>
+<span class="sourceLineNo">455</span> // the insert of the active into the compaction pipeline<a name="line.455"></a>
+<span class="sourceLineNo">456</span> return (inMemoryFlushInProgress.compareAndSet(false,true));<a name="line.456"></a>
+<span class="sourceLineNo">457</span> }<a name="line.457"></a>
+<span class="sourceLineNo">458</span> return false;<a name="line.458"></a>
+<span class="sourceLineNo">459</span> }<a name="line.459"></a>
+<span class="sourceLineNo">460</span><a name="line.460"></a>
+<span class="sourceLineNo">461</span> /**<a name="line.461"></a>
+<span class="sourceLineNo">462</span> * The request to cancel the compaction asynchronous task (caused by in-memory flush)<a name="line.462"></a>
+<span class="sourceLineNo">463</span> * The compaction may still happen if the request was sent too late<a name="line.463"></a>
+<span class="sourceLineNo">464</span> * Non-blocking request<a name="line.464"></a>
+<span class="sourceLineNo">465</span> */<a name="line.465"></a>
+<span class="sourceLineNo">466</span> private void stopCompaction() {<a name="line.466"></a>
+<span class="sourceLineNo">467</span> if (inMemoryFlushInProgress.get()) {<a name="line.467"></a>
+<span class="sourceLineNo">468</span> compactor.stop();<a name="line.468"></a>
+<span class="sourceLineNo">469</span> }<a name="line.469"></a>
+<span class="sourceLineNo">470</span> }<a name="line.470"></a>
+<span class="sourceLineNo">471</span><a name="line.471"></a>
+<span class="sourceLineNo">472</span> protected void pushActiveToPipeline(MutableSegment active) {<a name="line.472"></a>
+<span class="sourceLineNo">473</span> if (!active.isEmpty()) {<a name="line.473"></a>
+<span class="sourceLineNo">474</span> pipeline.pushHead(active);<a name="line.474"></a>
+<span class="sourceLineNo">475</span> resetActive();<a name="line.475"></a>
+<span class="sourceLineNo">476</span> }<a name="line.476"></a>
+<span class="sourceLineNo">477</span> }<a name="line.477"></a>
+<span class="sourceLineNo">478</span><a name="line.478"></a>
+<span class="sourceLineNo">479</span> private void pushTailToSnapshot() {<a name="line.479"></a>
+<span class="sourceLineNo">480</span> VersionedSegmentsList segments = pipeline.getVersionedTail();<a name="line.480"></a>
+<span class="sourceLineNo">481</span> pushToSnapshot(segments.getStoreSegments());<a name="line.481"></a>
+<span class="sourceLineNo">482</span> // In Swap: don't close segments (they are in snapshot now) and don't update the region size<a name="line.482"></a>
+<span class="sourceLineNo">483</span> pipeline.swap(segments,null,false, false);<a name="line.483"></a>
+<span class="sourceLineNo">484</span> }<a name="line.484"></a>
+<span class="sourceLineNo">485</span><a name="line.485"></a>
+<span class="sourceLineNo">486</span> private void pushPipelineToSnapshot() {<a name="line.486"></a>
+<span class="sourceLineNo">487</span> int iterationsCnt = 0;<a name="line.487"></a>
+<span class="sourceLineNo">488</span> boolean done = false;<a name="line.488"></a>
+<span class="sourceLineNo">489</span> while (!done) {<a name="line.489"></a>
+<span class="sourceLineNo">490</span> iterationsCnt++;<a name="line.490"></a>
+<span class="sourceLineNo">491</span> VersionedSegmentsList segments = pipeline.getVersionedList();<a name="line.491"></a>
+<span class="sourceLineNo">492</span> pushToSnapshot(segments.getStoreSegments());<a name="line.492"></a>
+<span class="sourceLineNo">493</span> // swap can return false in case the pipeline was updated by ongoing compaction<a name="line.493"></a>
+<span class="sourceLineNo">494</span> // and the version increase, the chance of it happenning is very low<a name="line.494"></a>
+<span class="sourceLineNo">495</span> // In Swap: don't close segments (they are in snapshot now) and don't update the region size<a name="line.495"></a>
+<span class="sourceLineNo">496</span> done = pipeline.swap(segments, null, false, false);<a name="line.496"></a>
+<span class="sourceLineNo">497</span> if (iterationsCnt>2) {<a name="line.497"></a>
+<span class="sourceLineNo">498</span> // practically it is impossible that this loop iterates more than two times<a name="line.498"></a>
+<span class="sourceLineNo">499</span> // (because the compaction is stopped and none restarts it while in snapshot request),<a name="line.499"></a>
+<span class="sourceLineNo">500</span> // however stopping here for the case of the infinite loop causing by any error<a name="line.500"></a>
+<span class="sourceLineNo">501</span> LOG.warn("Multiple unsuccessful attempts to push the compaction pipeline to snapshot," +<a name="line.501"></a>
+<span class="sourceLineNo">502</span> " while flushing to disk.");<a name="line.502"></a>
+<span class="sourceLineNo">503</span> this.snapshot = SegmentFactory.instance().createImmutableSegment(getComparator());<a name="line.503"></a>
+<span class="sourceLineNo">504</span> break;<a name="line.504"></a>
+<span class="sourceLineNo">505</span> }<a name="line.505"></a>
+<span class="sourceLineNo">506</span> }<a name="line.506"></a>
+<span class="sourceLineNo">507</span> }<a name="line.507"></a>
+<span class="sourceLineNo">508</span><a name="line.508"></a>
+<span class="sourceLineNo">509</span> private void pushToSnapshot(List<ImmutableSegment> segments) {<a name="line.509"></a>
+<span class="sourceLineNo">510</span> if(segments.isEmpty()) return;<a name="line.510"></a>
+<span class="sourceLineNo">511</span> if(segments.size() == 1 && !segments.get(0).isEmpty()) {<a name="line.511"></a>
+<span class="sourceLineNo">512</span> this.snapshot = segments.get(0);<a name="line.512"></a>
+<span class="sourceLineNo">513</span> return;<a name="line.513"></a>
+<span class="sourceLineNo">514</span> } else { // create composite snapshot<a name="line.514"></a>
+<span class="sourceLineNo">515</span> this.snapshot =<a name="line.515"></a>
+<span class="sourceLineNo">516</span> SegmentFactory.instance().createCompositeImmutableSegment(getComparator(), segments);<a name="line.516"></a>
+<span class="sourceLineNo">517</span> }<a name="line.517"></a>
+<span class="sourceLineNo">518</span> }<a name="line.518"></a>
+<span class="sourceLineNo">519</span><a name="line.519"></a>
+<span class="sourceLineNo">520</span> private RegionServicesForStores getRegionServices() {<a name="line.520"></a>
+<span class="sourceLineNo">521</span> return regionServices;<a name="line.521"></a>
<span class="sourceLineNo">522</span> }<a name="line.522"></a>
<span class="sourceLineNo">523</span><a name="line.523"></a>
-<span class="sourceLineNo">524</span> private RegionServicesForStores getRegionServices() {<a name="line.524"></a>
-<span class="sourceLineNo">525</span> return regionServices;<a name="line.525"></a>
-<span class="sourceLineNo">526</span> }<a name="line.526"></a>
-<span class="sourceLineNo">527</span><a name="line.527"></a>
-<span class="sourceLineNo">528</span> /**<a name="line.528"></a>
-<span class="sourceLineNo">529</span> * The in-memory-flusher thread performs the flush asynchronously.<a name="line.529"></a>
-<span class="sourceLineNo">530</span> * There is at most one thread per memstore instance.<a name="line.530"></a>
-<span class="sourceLineNo">531</span> * It takes the updatesLock exclusively, pushes active into the pipeline, releases updatesLock<a name="line.531"></a>
-<span class="sourceLineNo">532</span> * and compacts the pipeline.<a name="line.532"></a>
-<span class="sourceLineNo">533</span> */<a name="line.533"></a>
-<span class="sourceLineNo">534</span> private class InMemoryFlushRunnable implements Runnable {<a name="line.534"></a>
-<span class="sourceLineNo">535</span><a name="line.535"></a>
-<span class="sourceLineNo">536</span> @Override<a name="line.536"></a>
-<span class="sourceLineNo">537</span> public void run() {<a name="line.537"></a>
-<span class="sourceLineNo">538</span> try {<a name="line.538"></a>
-<span class="sourceLineNo">539</span> flushInMemory();<a name="line.539"></a>
-<span class="sourceLineNo">540</span> } catch (IOException e) {<a name="line.540"></a>
-<span class="sourceLineNo">541</span> LOG.warn("Unable to run memstore compaction. region "<a name="line.541"></a>
-<span class="sourceLineNo">542</span> + getRegionServices().getRegionInfo().getRegionNameAsString()<a name="line.542"></a>
-<span class="sourceLineNo">543</span> + "store: "+ getFamilyName(), e);<a name="line.543"></a>
-<span class="sourceLineNo">544</span> }<a name="line.544"></a>
-<span class="sourceLineNo">545</span> }<a name="line.545"></a>
-<span class="sourceLineNo">546</span> }<a name="line.546"></a>
-<span class="sourceLineNo">547</span><a name="line.547"></a>
-<span class="sourceLineNo">548</span> @VisibleForTesting<a name="line.548"></a>
-<span class="sourceLineNo">549</span> boolean isMemStoreFlushingInMemory() {<a name="line.549"></a>
-<span class="sourceLineNo">550</span> return inMemoryFlushInProgress.get();<a name="line.550"></a>
-<span class="sourceLineNo">551</span> }<a name="line.551"></a>
-<span class="sourceLineNo">552</span><a name="line.552"></a>
-<span class="sourceLineNo">553</span> /**<a name="line.553"></a>
-<span class="sourceLineNo">554</span> * @param cell Find the row that comes after this one. If null, we return the<a name="line.554"></a>
-<span class="sourceLineNo">555</span> * first.<a name="line.555"></a>
-<span class="sourceLineNo">556</span> * @return Next row or null if none found.<a name="line.556"></a>
-<span class="sourceLineNo">557</span> */<a name="line.557"></a>
-<span class="sourceLineNo">558</span> Cell getNextRow(final Cell cell) {<a name="line.558"></a>
-<span class="sourceLineNo">559</span> Cell lowest = null;<a name="line.559"></a>
-<span class="sourceLineNo">560</span> List<Segment> segments = getSegments();<a name="line.560"></a>
-<span class="sourceLineNo">561</span> for (Segment segment : segments) {<a name="line.561"></a>
-<span class="sourceLineNo">562</span> if (lowest == null) {<a name="line.562"></a>
-<span class="sourceLineNo">563</span> lowest = getNextRow(cell, segment.getCellSet());<a name="line.563"></a>
-<span class="sourceLineNo">564</span> } else {<a name="line.564"></a>
-<span class="sourceLineNo">565</span> lowest = getLowest(lowest, getNextRow(cell, segment.getCellSet()));<a name="line.565"></a>
-<span class="sourceLineNo">566</span> }<a name="line.566"></a>
-<span class="sourceLineNo">567</span> }<a name="line.567"></a>
-<span class="sourceLineNo">568</span> return lowest;<a name="line.568"></a>
-<span class="sourceLineNo">569</span> }<a name="line.569"></a>
-<span class="sourceLineNo">570</span><a name="line.570"></a>
-<span class="sourceLineNo">571</span> @VisibleForTesting<a name="line.571"></a>
-<span class="sourceLineNo">572</span> long getInmemoryFlushSize() {<a name="line.572"></a>
-<span class="sourceLineNo">573</span> return inmemoryFlushSize;<a name="line.573"></a>
-<span class="sourceLineNo">574</span> }<a name="line.574"></a>
-<span class="sourceLineNo">575</span><a name="line.575"></a>
-<span class="sourceLineNo">576</span> // debug method<a name="line.576"></a>
-<span class="sourceLineNo">577</span> public void debug() {<a name="line.577"></a>
-<span class="sourceLineNo">578</span> String msg = "active size=" + this.active.keySize();<a name="line.578"></a>
-<span class="sourceLineNo">579</span> msg += " in-memory flush size is "+ inmemoryFlushSize;<a name="line.579"></a>
-<span class="sourceLineNo">580</span> msg += " allow compaction is "+ (allowCompaction.get() ? "true" : "false");<a name="line.580"></a>
-<span class="sourceLineNo">581</span> msg += " inMemoryFlushInProgress is "+ (inMemoryFlushInProgress.get() ? "true" : "false");<a name="line.581"></a>
-<span class="sourceLineNo">582</span> LOG.debug(msg);<a name="line.582"></a>
-<span class="sourceLineNo">583</span> }<a name="line.583"></a>
-<span class="sourceLineNo">584</span><a name="line.584"></a>
-<span class="sourceLineNo">585</span>}<a name="line.585"></a>
+<span class="sourceLineNo">524</span> /**<a name="line.524"></a>
+<span class="sourceLineNo">525</span> * The in-memory-flusher thread performs the flush asynchronously.<a name="line.525"></a>
+<span class="sourceLineNo">526</span> * There is at most one thread per memstore instance.<a name="line.526"></a>
+<span class="sourceLineNo">527</span> * It takes the updatesLock exclusively, pushes active into the pipeline, releases updatesLock<a name="line.527"></a>
+<span class="sourceLineNo">528</span> * and compacts the pipeline.<a name="line.528"></a>
+<span class="sourceLineNo">529</span> */<a name="line.529"></a>
+<span class="sourceLineNo">530</span> private class InMemoryFlushRunnable implements Runnable {<a name="line.530"></a>
+<span class="sourceLineNo">531</span><a name="line.531"></a>
+<span class="sourceLineNo">532</span> @Override<a name="line.532"></a>
+<span class="sourceLineNo">533</span> public void run() {<a name="line.533"></a>
+<span class="sourceLineNo">534</span> try {<a name="line.534"></a>
+<span class="sourceLineNo">535</span> flushInMemory();<a name="line.535"></a>
+<span class="sourceLineNo">536</span> } catch (IOException e) {<a name="line.536"></a>
+<span class="sourceLineNo">537</span> LOG.warn("Unable to run memstore compaction. region "<a name="line.537"></a>
+<span class="sourceLineNo">538</span> + getRegionServices().getRegionInfo().getRegionNameAsString()<a name="line.538"></a>
+<span class="sourceLineNo">539</span> + "store: "+ getFamilyName(), e);<a name="line.539"></a>
+<span class="sourceLineNo">540</span> }<a name="line.540"></a>
+<span class="sourceLineNo">541</span> }<a name="line.541"></a>
+<span class="sourceLineNo">542</span> }<a name="line.542"></a>
+<span class="sourceLineNo">543</span><a name="line.543"></a>
+<span class="sourceLineNo">544</span> @VisibleForTesting<a name="line.544"></a>
+<span class="sourceLineNo">545</span> boolean isMemStoreFlushingInMemory() {<a name="line.545"></a>
+<span class="sourceLineNo">546</span> return inMemoryFlushInProgress.get();<a name="line.546"></a>
+<span class="sourceLineNo">547</span> }<a name="line.547"></a>
+<span class="sourceLineNo">548</span><a name="line.548"></a>
+<span class="sourceLineNo">549</span> /**<a name="line.549"></a>
+<span class="sourceLineNo">550</span> * @param cell Find the row that comes after this one. If null, we return the<a name="line.550"></a>
+<span class="sourceLineNo">551</span> * first.<a name="line.551"></a>
+<span class="sourceLineNo">552</span> * @return Next row or null if none found.<a name="line.552"></a>
+<span class="sourceLineNo">553</span> */<a name="line.553"></a>
+<span class="sourceLineNo">554</span> Cell getNextRow(final Cell cell) {<a name="line.554"></a>
+<span class="sourceLineNo">555</span> Cell lowest = null;<a name="line.555"></a>
+<span class="sourceLineNo">556</span> List<Segment> segments = getSegments();<a name="line.556"></a>
+<span class="sourceLineNo">557</span> for (Segment segment : segments) {<a name="line.557"></a>
+<span class="sourceLineNo">558</span> if (lowest == null) {<a name="line.558"></a>
+<span class="sourceLineNo">559</span> lowest = getNextRow(cell, segment.getCellSet());<a name="line.559"></a>
+<span class="sourceLineNo">560</span> } else {<a name="line.560"></a>
+<span class="sourceLineNo">561</span> lowest = getLowest(lowest, getNextRow(cell, segment.getCellSet()));<a name="line.561"></a>
+<span class="sourceLineNo">562</span> }<a name="line.562"></a>
+<span class="sourceLineNo">563</span> }<a name="line.563"></a>
+<span class="sourceLineNo">564</span> return lowest;<a name="line.564"></a>
+<span class="sourceLineNo">565</span> }<a name="line.565"></a>
+<span class="sourceLineNo">566</span><a name="line.566"></a>
+<span class="sourceLineNo">567</span> @VisibleForTesting<a name="line.567"></a>
+<span class="sourceLineNo">568</span> long getInmemoryFlushSize() {<a name="line.568"></a>
+<span class="sourceLineNo">569</span> return inmemoryFlushSize;<a name="line.569"></a>
+<span class="sourceLineNo">570</span> }<a name="line.570"></a>
+<span class="sourceLineNo">571</span><a name="line.571"></a>
+<span class="sourceLineNo">572</span> // debug method<a name="line.572"></a>
+<span class="sourceLineNo">573</span> public void debug() {<a name="line.573"></a>
+<span class="sourceLineNo">574</span> String msg = "active size=" + this.active.keySize();<a name="line.574"></a>
+<span class="sourceLineNo">575</span> msg += " in-memory flush size is "+ inmemoryFlushSize;<a name="line.575"></a>
+<span class="sourceLineNo">576</span> msg += " allow compaction is "+ (allowCompaction.get() ? "true" : "false");<a name="line.576"></a>
+<span class="sourceLineNo">577</span> msg += " inMemoryFlushInProgress is "+ (inMemoryFlushInProgress.get() ? "true" : "false");<a name="line.577"></a>
+<span class="sourceLineNo">578</span> LOG.debug(msg);<a name="line.578"></a>
+<span class="sourceLineNo">579</span> }<a name="line.579"></a>
+<span class="sourceLineNo">580</span><a name="line.580"></a>
+<span class="sourceLineNo">581</span>}<a name="line.581"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/ede30993/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactingMemStore.IndexType.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactingMemStore.IndexType.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactingMemStore.IndexType.html
index 22e7059..01b8a09 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactingMemStore.IndexType.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactingMemStore.IndexType.html
@@ -362,235 +362,231 @@
<span class="sourceLineNo">354</span> }<a name="line.354"></a>
<span class="sourceLineNo">355</span><a name="line.355"></a>
<span class="sourceLineNo">356</span> @Override<a name="line.356"></a>
-<span class="sourceLineNo">357</span> /*<a name="line.357"></a>
-<span class="sourceLineNo">358</span> * Scanners are ordered from 0 (oldest) to newest in increasing order.<a name="line.358"></a>
-<span class="sourceLineNo">359</span> */<a name="line.359"></a>
-<span class="sourceLineNo">360</span> public List<KeyValueScanner> getScanners(long readPt) throws IOException {<a name="line.360"></a>
-<span class="sourceLineNo">361</span> MutableSegment activeTmp = active;<a name="line.361"></a>
-<span class="sourceLineNo">362</span> List<? extends Segment> pipelineList = pipeline.getSegments();<a name="line.362"></a>
-<span class="sourceLineNo">363</span> List<? extends Segment> snapshotList = snapshot.getAllSegments();<a name="line.363"></a>
-<span class="sourceLineNo">364</span> long order = 1L + pipelineList.size() + snapshotList.size();<a name="line.364"></a>
-<span class="sourceLineNo">365</span> // The list of elements in pipeline + the active element + the snapshot segment<a name="line.365"></a>
-<span class="sourceLineNo">366</span> // The order is the Segment ordinal<a name="line.366"></a>
-<span class="sourceLineNo">367</span> List<KeyValueScanner> list = createList((int) order);<a name="line.367"></a>
-<span class="sourceLineNo">368</span> order = addToScanners(activeTmp, readPt, order, list);<a name="line.368"></a>
-<span class="sourceLineNo">369</span> order = addToScanners(pipelineList, readPt, order, list);<a name="line.369"></a>
-<span class="sourceLineNo">370</span> addToScanners(snapshotList, readPt, order, list);<a name="line.370"></a>
-<span class="sourceLineNo">371</span> return list;<a name="line.371"></a>
-<span class="sourceLineNo">372</span> }<a name="line.372"></a>
-<span class="sourceLineNo">373</span><a name="line.373"></a>
-<span class="sourceLineNo">374</span> @VisibleForTesting<a name="line.374"></a>
-<span class="sourceLineNo">375</span> protected List<KeyValueScanner> createList(int capacity) {<a name="line.375"></a>
-<span class="sourceLineNo">376</span> return new ArrayList<>(capacity);<a name="line.376"></a>
-<span class="sourceLineNo">377</span> }<a name="line.377"></a>
-<span class="sourceLineNo">378</span><a name="line.378"></a>
-<span class="sourceLineNo">379</span> /**<a name="line.379"></a>
-<span class="sourceLineNo">380</span> * Check whether anything need to be done based on the current active set size.<a name="line.380"></a>
-<span class="sourceLineNo">381</span> * The method is invoked upon every addition to the active set.<a name="line.381"></a>
-<span class="sourceLineNo">382</span> * For CompactingMemStore, flush the active set to the read-only memory if it's<a name="line.382"></a>
-<span class="sourceLineNo">383</span> * size is above threshold<a name="line.383"></a>
-<span class="sourceLineNo">384</span> */<a name="line.384"></a>
-<span class="sourceLineNo">385</span> @Override<a name="line.385"></a>
-<span class="sourceLineNo">386</span> protected void checkActiveSize() {<a name="line.386"></a>
-<span class="sourceLineNo">387</span> if (shouldFlushInMemory()) {<a name="line.387"></a>
-<span class="sourceLineNo">388</span> /* The thread is dispatched to flush-in-memory. This cannot be done<a name="line.388"></a>
-<span class="sourceLineNo">389</span> * on the same thread, because for flush-in-memory we require updatesLock<a name="line.389"></a>
-<span class="sourceLineNo">390</span> * in exclusive mode while this method (checkActiveSize) is invoked holding updatesLock<a name="line.390"></a>
-<span class="sourceLineNo">391</span> * in the shared mode. */<a name="line.391"></a>
-<span class="sourceLineNo">392</span> InMemoryFlushRunnable runnable = new InMemoryFlushRunnable();<a name="line.392"></a>
-<span class="sourceLineNo">393</span> if (LOG.isTraceEnabled()) {<a name="line.393"></a>
-<span class="sourceLineNo">394</span> LOG.trace(<a name="line.394"></a>
-<span class="sourceLineNo">395</span> "Dispatching the MemStore in-memory flush for store " + store.getColumnFamilyName());<a name="line.395"></a>
-<span class="sourceLineNo">396</span> }<a name="line.396"></a>
-<span class="sourceLineNo">397</span> getPool().execute(runnable);<a name="line.397"></a>
-<span class="sourceLineNo">398</span> }<a name="line.398"></a>
-<span class="sourceLineNo">399</span> }<a name="line.399"></a>
-<span class="sourceLineNo">400</span><a name="line.400"></a>
-<span class="sourceLineNo">401</span> // internally used method, externally visible only for tests<a name="line.401"></a>
-<span class="sourceLineNo">402</span> // when invoked directly from tests it must be verified that the caller doesn't hold updatesLock,<a name="line.402"></a>
-<span class="sourceLineNo">403</span> // otherwise there is a deadlock<a name="line.403"></a>
-<span class="sourceLineNo">404</span> @VisibleForTesting<a name="line.404"></a>
-<span class="sourceLineNo">405</span> void flushInMemory() throws IOException {<a name="line.405"></a>
-<span class="sourceLineNo">406</span> // setting the inMemoryFlushInProgress flag again for the case this method is invoked<a name="line.406"></a>
-<span class="sourceLineNo">407</span> // directly (only in tests) in the common path setting from true to true is idempotent<a name="line.407"></a>
-<span class="sourceLineNo">408</span> inMemoryFlushInProgress.set(true);<a name="line.408"></a>
-<span class="sourceLineNo">409</span> try {<a name="line.409"></a>
-<span class="sourceLineNo">410</span> // Phase I: Update the pipeline<a name="line.410"></a>
-<span class="sourceLineNo">411</span> getRegionServices().blockUpdates();<a name="line.411"></a>
-<span class="sourceLineNo">412</span> try {<a name="line.412"></a>
-<span class="sourceLineNo">413</span> LOG.trace("IN-MEMORY FLUSH: Pushing active segment into compaction pipeline");<a name="line.413"></a>
-<span class="sourceLineNo">414</span> pushActiveToPipeline(this.active);<a name="line.414"></a>
-<span class="sourceLineNo">415</span> } finally {<a name="line.415"></a>
-<span class="sourceLineNo">416</span> getRegionServices().unblockUpdates();<a name="line.416"></a>
-<span class="sourceLineNo">417</span> }<a name="line.417"></a>
-<span class="sourceLineNo">418</span><a name="line.418"></a>
-<span class="sourceLineNo">419</span> // Used by tests<a name="line.419"></a>
-<span class="sourceLineNo">420</span> if (!allowCompaction.get()) {<a name="line.420"></a>
-<span class="sourceLineNo">421</span> return;<a name="line.421"></a>
-<span class="sourceLineNo">422</span> }<a name="line.422"></a>
-<span class="sourceLineNo">423</span> // Phase II: Compact the pipeline<a name="line.423"></a>
-<span class="sourceLineNo">424</span> try {<a name="line.424"></a>
-<span class="sourceLineNo">425</span> // Speculative compaction execution, may be interrupted if flush is forced while<a name="line.425"></a>
-<span class="sourceLineNo">426</span> // compaction is in progress<a name="line.426"></a>
-<span class="sourceLineNo">427</span> compactor.start();<a name="line.427"></a>
-<span class="sourceLineNo">428</span> } catch (IOException e) {<a name="line.428"></a>
-<span class="sourceLineNo">429</span> LOG.warn("Unable to run in-memory compaction on {}/{}; exception={}",<a name="line.429"></a>
-<span class="sourceLineNo">430</span> getRegionServices().getRegionInfo().getEncodedName(), getFamilyName(), e);<a name="line.430"></a>
-<span class="sourceLineNo">431</span> }<a name="line.431"></a>
-<span class="sourceLineNo">432</span> } finally {<a name="line.432"></a>
-<span class="sourceLineNo">433</span> inMemoryFlushInProgress.set(false);<a name="line.433"></a>
-<span class="sourceLineNo">434</span> LOG.trace("IN-MEMORY FLUSH: end");<a name="line.434"></a>
-<span class="sourceLineNo">435</span> }<a name="line.435"></a>
-<span class="sourceLineNo">436</span> }<a name="line.436"></a>
-<span class="sourceLineNo">437</span><a name="line.437"></a>
-<span class="sourceLineNo">438</span> private Segment getLastSegment() {<a name="line.438"></a>
-<span class="sourceLineNo">439</span> Segment localActive = getActive();<a name="line.439"></a>
-<span class="sourceLineNo">440</span> Segment tail = pipeline.getTail();<a name="line.440"></a>
-<span class="sourceLineNo">441</span> return tail == null ? localActive : tail;<a name="line.441"></a>
+<span class="sourceLineNo">357</span> public List<KeyValueScanner> getScanners(long readPt) throws IOException {<a name="line.357"></a>
+<span class="sourceLineNo">358</span> MutableSegment activeTmp = active;<a name="line.358"></a>
+<span class="sourceLineNo">359</span> List<? extends Segment> pipelineList = pipeline.getSegments();<a name="line.359"></a>
+<span class="sourceLineNo">360</span> List<? extends Segment> snapshotList = snapshot.getAllSegments();<a name="line.360"></a>
+<span class="sourceLineNo">361</span> long numberOfSegments = 1L + pipelineList.size() + snapshotList.size();<a name="line.361"></a>
+<span class="sourceLineNo">362</span> // The list of elements in pipeline + the active element + the snapshot segment<a name="line.362"></a>
+<span class="sourceLineNo">363</span> List<KeyValueScanner> list = createList((int) numberOfSegments);<a name="line.363"></a>
+<span class="sourceLineNo">364</span> addToScanners(activeTmp, readPt, list);<a name="line.364"></a>
+<span class="sourceLineNo">365</span> addToScanners(pipelineList, readPt, list);<a name="line.365"></a>
+<span class="sourceLineNo">366</span> addToScanners(snapshotList, readPt, list);<a name="line.366"></a>
+<span class="sourceLineNo">367</span> return list;<a name="line.367"></a>
+<span class="sourceLineNo">368</span> }<a name="line.368"></a>
+<span class="sourceLineNo">369</span><a name="line.369"></a>
+<span class="sourceLineNo">370</span> @VisibleForTesting<a name="line.370"></a>
+<span class="sourceLineNo">371</span> protected List<KeyValueScanner> createList(int capacity) {<a name="line.371"></a>
+<span class="sourceLineNo">372</span> return new ArrayList<>(capacity);<a name="line.372"></a>
+<span class="sourceLineNo">373</span> }<a name="line.373"></a>
+<span class="sourceLineNo">374</span><a name="line.374"></a>
+<span class="sourceLineNo">375</span> /**<a name="line.375"></a>
+<span class="sourceLineNo">376</span> * Check whether anything need to be done based on the current active set size.<a name="line.376"></a>
+<span class="sourceLineNo">377</span> * The method is invoked upon every addition to the active set.<a name="line.377"></a>
+<span class="sourceLineNo">378</span> * For CompactingMemStore, flush the active set to the read-only memory if it's<a name="line.378"></a>
+<span class="sourceLineNo">379</span> * size is above threshold<a name="line.379"></a>
+<span class="sourceLineNo">380</span> */<a name="line.380"></a>
+<span class="sourceLineNo">381</span> @Override<a name="line.381"></a>
+<span class="sourceLineNo">382</span> protected void checkActiveSize() {<a name="line.382"></a>
+<span class="sourceLineNo">383</span> if (shouldFlushInMemory()) {<a name="line.383"></a>
+<span class="sourceLineNo">384</span> /* The thread is dispatched to flush-in-memory. This cannot be done<a name="line.384"></a>
+<span class="sourceLineNo">385</span> * on the same thread, because for flush-in-memory we require updatesLock<a name="line.385"></a>
+<span class="sourceLineNo">386</span> * in exclusive mode while this method (checkActiveSize) is invoked holding updatesLock<a name="line.386"></a>
+<span class="sourceLineNo">387</span> * in the shared mode. */<a name="line.387"></a>
+<span class="sourceLineNo">388</span> InMemoryFlushRunnable runnable = new InMemoryFlushRunnable();<a name="line.388"></a>
+<span class="sourceLineNo">389</span> if (LOG.isTraceEnabled()) {<a name="line.389"></a>
+<span class="sourceLineNo">390</span> LOG.trace(<a name="line.390"></a>
+<span class="sourceLineNo">391</span> "Dispatching the MemStore in-memory flush for store " + store.getColumnFamilyName());<a name="line.391"></a>
+<span class="sourceLineNo">392</span> }<a name="line.392"></a>
+<span class="sourceLineNo">393</span> getPool().execute(runnable);<a name="line.393"></a>
+<span class="sourceLineNo">394</span> }<a name="line.394"></a>
+<span class="sourceLineNo">395</span> }<a name="line.395"></a>
+<span class="sourceLineNo">396</span><a name="line.396"></a>
+<span class="sourceLineNo">397</span> // internally used method, externally visible only for tests<a name="line.397"></a>
+<span class="sourceLineNo">398</span> // when invoked directly from tests it must be verified that the caller doesn't hold updatesLock,<a name="line.398"></a>
+<span class="sourceLineNo">399</span> // otherwise there is a deadlock<a name="line.399"></a>
+<span class="sourceLineNo">400</span> @VisibleForTesting<a name="line.400"></a>
+<span class="sourceLineNo">401</span> void flushInMemory() throws IOException {<a name="line.401"></a>
+<span class="sourceLineNo">402</span> // setting the inMemoryFlushInProgress flag again for the case this method is invoked<a name="line.402"></a>
+<span class="sourceLineNo">403</span> // directly (only in tests) in the common path setting from true to true is idempotent<a name="line.403"></a>
+<span class="sourceLineNo">404</span> inMemoryFlushInProgress.set(true);<a name="line.404"></a>
+<span class="sourceLineNo">405</span> try {<a name="line.405"></a>
+<span class="sourceLineNo">406</span> // Phase I: Update the pipeline<a name="line.406"></a>
+<span class="sourceLineNo">407</span> getRegionServices().blockUpdates();<a name="line.407"></a>
+<span class="sourceLineNo">408</span> try {<a name="line.408"></a>
+<span class="sourceLineNo">409</span> LOG.trace("IN-MEMORY FLUSH: Pushing active segment into compaction pipeline");<a name="line.409"></a>
+<span class="sourceLineNo">410</span> pushActiveToPipeline(this.active);<a name="line.410"></a>
+<span class="sourceLineNo">411</span> } finally {<a name="line.411"></a>
+<span class="sourceLineNo">412</span> getRegionServices().unblockUpdates();<a name="line.412"></a>
+<span class="sourceLineNo">413</span> }<a name="line.413"></a>
+<span class="sourceLineNo">414</span><a name="line.414"></a>
+<span class="sourceLineNo">415</span> // Used by tests<a name="line.415"></a>
+<span class="sourceLineNo">416</span> if (!allowCompaction.get()) {<a name="line.416"></a>
+<span class="sourceLineNo">417</span> return;<a name="line.417"></a>
+<span class="sourceLineNo">418</span> }<a name="line.418"></a>
+<span class="sourceLineNo">419</span> // Phase II: Compact the pipeline<a name="line.419"></a>
+<span class="sourceLineNo">420</span> try {<a name="line.420"></a>
+<span class="sourceLineNo">421</span> // Speculative compaction execution, may be interrupted if flush is forced while<a name="line.421"></a>
+<span class="sourceLineNo">422</span> // compaction is in progress<a name="line.422"></a>
+<span class="sourceLineNo">423</span> compactor.start();<a name="line.423"></a>
+<span class="sourceLineNo">424</span> } catch (IOException e) {<a name="line.424"></a>
+<span class="sourceLineNo">425</span> LOG.warn("Unable to run in-memory compaction on {}/{}; exception={}",<a name="line.425"></a>
+<span class="sourceLineNo">426</span> getRegionServices().getRegionInfo().getEncodedName(), getFamilyName(), e);<a name="line.426"></a>
+<span class="sourceLineNo">427</span> }<a name="line.427"></a>
+<span class="sourceLineNo">428</span> } finally {<a name="line.428"></a>
+<span class="sourceLineNo">429</span> inMemoryFlushInProgress.set(false);<a name="line.429"></a>
+<span class="sourceLineNo">430</span> LOG.trace("IN-MEMORY FLUSH: end");<a name="line.430"></a>
+<span class="sourceLineNo">431</span> }<a name="line.431"></a>
+<span class="sourceLineNo">432</span> }<a name="line.432"></a>
+<span class="sourceLineNo">433</span><a name="line.433"></a>
+<span class="sourceLineNo">434</span> private Segment getLastSegment() {<a name="line.434"></a>
+<span class="sourceLineNo">435</span> Segment localActive = getActive();<a name="line.435"></a>
+<span class="sourceLineNo">436</span> Segment tail = pipeline.getTail();<a name="line.436"></a>
+<span class="sourceLineNo">437</span> return tail == null ? localActive : tail;<a name="line.437"></a>
+<span class="sourceLineNo">438</span> }<a name="line.438"></a>
+<span class="sourceLineNo">439</span><a name="line.439"></a>
+<span class="sourceLineNo">440</span> private byte[] getFamilyNameInBytes() {<a name="line.440"></a>
+<span class="sourceLineNo">441</span> return store.getColumnFamilyDescriptor().getName();<a name="line.441"></a>
<span class="sourceLineNo">442</span> }<a name="line.442"></a>
<span class="sourceLineNo">443</span><a name="line.443"></a>
-<span class="sourceLineNo">444</span> private byte[] getFamilyNameInBytes() {<a name="line.444"></a>
-<span class="sourceLineNo">445</span> return store.getColumnFamilyDescriptor().getName();<a name="line.445"></a>
+<span class="sourceLineNo">444</span> private ThreadPoolExecutor getPool() {<a name="line.444"></a>
+<span class="sourceLineNo">445</span> return getRegionServices().getInMemoryCompactionPool();<a name="line.445"></a>
<span class="sourceLineNo">446</span> }<a name="line.446"></a>
<span class="sourceLineNo">447</span><a name="line.447"></a>
-<span class="sourceLineNo">448</span> private ThreadPoolExecutor getPool() {<a name="line.448"></a>
-<span class="sourceLineNo">449</span> return getRegionServices().getInMemoryCompactionPool();<a name="line.449"></a>
-<span class="sourceLineNo">450</span> }<a name="line.450"></a>
-<span class="sourceLineNo">451</span><a name="line.451"></a>
-<span class="sourceLineNo">452</span> @VisibleForTesting<a name="line.452"></a>
-<span class="sourceLineNo">453</span> protected boolean shouldFlushInMemory() {<a name="line.453"></a>
-<span class="sourceLineNo">454</span> if (this.active.keySize() > inmemoryFlushSize) { // size above flush threshold<a name="line.454"></a>
-<span class="sourceLineNo">455</span> if (inWalReplay) { // when replaying edits from WAL there is no need in in-memory flush<a name="line.455"></a>
-<span class="sourceLineNo">456</span> return false; // regardless the size<a name="line.456"></a>
-<span class="sourceLineNo">457</span> }<a name="line.457"></a>
-<span class="sourceLineNo">458</span> // the inMemoryFlushInProgress is CASed to be true here in order to mutual exclude<a name="line.458"></a>
-<span class="sourceLineNo">459</span> // the insert of the active into the compaction pipeline<a name="line.459"></a>
-<span class="sourceLineNo">460</span> return (inMemoryFlushInProgress.compareAndSet(false,true));<a name="line.460"></a>
-<span class="sourceLineNo">461</span> }<a name="line.461"></a>
-<span class="sourceLineNo">462</span> return false;<a name="line.462"></a>
-<span class="sourceLineNo">463</span> }<a name="line.463"></a>
-<span class="sourceLineNo">464</span><a name="line.464"></a>
-<span class="sourceLineNo">465</span> /**<a name="line.465"></a>
-<span class="sourceLineNo">466</span> * The request to cancel the compaction asynchronous task (caused by in-memory flush)<a name="line.466"></a>
-<span class="sourceLineNo">467</span> * The compaction may still happen if the request was sent too late<a name="line.467"></a>
-<span class="sourceLineNo">468</span> * Non-blocking request<a name="line.468"></a>
-<span class="sourceLineNo">469</span> */<a name="line.469"></a>
-<span class="sourceLineNo">470</span> private void stopCompaction() {<a name="line.470"></a>
-<span class="sourceLineNo">471</span> if (inMemoryFlushInProgress.get()) {<a name="line.471"></a>
-<span class="sourceLineNo">472</span> compactor.stop();<a name="line.472"></a>
-<span class="sourceLineNo">473</span> }<a name="line.473"></a>
-<span class="sourceLineNo">474</span> }<a name="line.474"></a>
-<span class="sourceLineNo">475</span><a name="line.475"></a>
-<span class="sourceLineNo">476</span> protected void pushActiveToPipeline(MutableSegment active) {<a name="line.476"></a>
-<span class="sourceLineNo">477</span> if (!active.isEmpty()) {<a name="line.477"></a>
-<span class="sourceLineNo">478</span> pipeline.pushHead(active);<a name="line.478"></a>
-<span class="sourceLineNo">479</span> resetActive();<a name="line.479"></a>
-<span class="sourceLineNo">480</span> }<a name="line.480"></a>
-<span class="sourceLineNo">481</span> }<a name="line.481"></a>
-<span class="sourceLineNo">482</span><a name="line.482"></a>
-<span class="sourceLineNo">483</span> private void pushTailToSnapshot() {<a name="line.483"></a>
-<span class="sourceLineNo">484</span> VersionedSegmentsList segments = pipeline.getVersionedTail();<a name="line.484"></a>
-<span class="sourceLineNo">485</span> pushToSnapshot(segments.getStoreSegments());<a name="line.485"></a>
-<span class="sourceLineNo">486</span> // In Swap: don't close segments (they are in snapshot now) and don't update the region size<a name="line.486"></a>
-<span class="sourceLineNo">487</span> pipeline.swap(segments,null,false, false);<a name="line.487"></a>
-<span class="sourceLineNo">488</span> }<a name="line.488"></a>
-<span class="sourceLineNo">489</span><a name="line.489"></a>
-<span class="sourceLineNo">490</span> private void pushPipelineToSnapshot() {<a name="line.490"></a>
-<span class="sourceLineNo">491</span> int iterationsCnt = 0;<a name="line.491"></a>
-<span class="sourceLineNo">492</span> boolean done = false;<a name="line.492"></a>
-<span class="sourceLineNo">493</span> while (!done) {<a name="line.493"></a>
-<span class="sourceLineNo">494</span> iterationsCnt++;<a name="line.494"></a>
-<span class="sourceLineNo">495</span> VersionedSegmentsList segments = pipeline.getVersionedList();<a name="line.495"></a>
-<span class="sourceLineNo">496</span> pushToSnapshot(segments.getStoreSegments());<a name="line.496"></a>
-<span class="sourceLineNo">497</span> // swap can return false in case the pipeline was updated by ongoing compaction<a name="line.497"></a>
-<span class="sourceLineNo">498</span> // and the version increase, the chance of it happenning is very low<a name="line.498"></a>
-<span class="sourceLineNo">499</span> // In Swap: don't close segments (they are in snapshot now) and don't update the region size<a name="line.499"></a>
-<span class="sourceLineNo">500</span> done = pipeline.swap(segments, null, false, false);<a name="line.500"></a>
-<span class="sourceLineNo">501</span> if (iterationsCnt>2) {<a name="line.501"></a>
-<span class="sourceLineNo">502</span> // practically it is impossible that this loop iterates more than two times<a name="line.502"></a>
-<span class="sourceLineNo">503</span> // (because the compaction is stopped and none restarts it while in snapshot request),<a name="line.503"></a>
-<span class="sourceLineNo">504</span> // however stopping here for the case of the infinite loop causing by any error<a name="line.504"></a>
-<span class="sourceLineNo">505</span> LOG.warn("Multiple unsuccessful attempts to push the compaction pipeline to snapshot," +<a name="line.505"></a>
-<span class="sourceLineNo">506</span> " while flushing to disk.");<a name="line.506"></a>
-<span class="sourceLineNo">507</span> this.snapshot = SegmentFactory.instance().createImmutableSegment(getComparator());<a name="line.507"></a>
-<span class="sourceLineNo">508</span> break;<a name="line.508"></a>
-<span class="sourceLineNo">509</span> }<a name="line.509"></a>
-<span class="sourceLineNo">510</span> }<a name="line.510"></a>
-<span class="sourceLineNo">511</span> }<a name="line.511"></a>
-<span class="sourceLineNo">512</span><a name="line.512"></a>
-<span class="sourceLineNo">513</span> private void pushToSnapshot(List<ImmutableSegment> segments) {<a name="line.513"></a>
-<span class="sourceLineNo">514</span> if(segments.isEmpty()) return;<a name="line.514"></a>
-<span class="sourceLineNo">515</span> if(segments.size() == 1 && !segments.get(0).isEmpty()) {<a name="line.515"></a>
-<span class="sourceLineNo">516</span> this.snapshot = segments.get(0);<a name="line.516"></a>
-<span class="sourceLineNo">517</span> return;<a name="line.517"></a>
-<span class="sourceLineNo">518</span> } else { // create composite snapshot<a name="line.518"></a>
-<span class="sourceLineNo">519</span> this.snapshot =<a name="line.519"></a>
-<span class="sourceLineNo">520</span> SegmentFactory.instance().createCompositeImmutableSegment(getComparator(), segments);<a name="line.520"></a>
-<span class="sourceLineNo">521</span> }<a name="line.521"></a>
+<span class="sourceLineNo">448</span> @VisibleForTesting<a name="line.448"></a>
+<span class="sourceLineNo">449</span> protected boolean shouldFlushInMemory() {<a name="line.449"></a>
+<span class="sourceLineNo">450</span> if (this.active.keySize() > inmemoryFlushSize) { // size above flush threshold<a name="line.450"></a>
+<span class="sourceLineNo">451</span> if (inWalReplay) { // when replaying edits from WAL there is no need in in-memory flush<a name="line.451"></a>
+<span class="sourceLineNo">452</span> return false; // regardless the size<a name="line.452"></a>
+<span class="sourceLineNo">453</span> }<a name="line.453"></a>
+<span class="sourceLineNo">454</span> // the inMemoryFlushInProgress is CASed to be true here in order to mutual exclude<a name="line.454"></a>
+<span class="sourceLineNo">455</span> // the insert of the active into the compaction pipeline<a name="line.455"></a>
+<span class="sourceLineNo">456</span> return (inMemoryFlushInProgress.compareAndSet(false,true));<a name="line.456"></a>
+<span class="sourceLineNo">457</span> }<a name="line.457"></a>
+<span class="sourceLineNo">458</span> return false;<a name="line.458"></a>
+<span class="sourceLineNo">459</span> }<a name="line.459"></a>
+<span class="sourceLineNo">460</span><a name="line.460"></a>
+<span class="sourceLineNo">461</span> /**<a name="line.461"></a>
+<span class="sourceLineNo">462</span> * The request to cancel the compaction asynchronous task (caused by in-memory flush)<a name="line.462"></a>
+<span class="sourceLineNo">463</span> * The compaction may still happen if the request was sent too late<a name="line.463"></a>
+<span class="sourceLineNo">464</span> * Non-blocking request<a name="line.464"></a>
+<span class="sourceLineNo">465</span> */<a name="line.465"></a>
+<span class="sourceLineNo">466</span> private void stopCompaction() {<a name="line.466"></a>
+<span class="sourceLineNo">467</span> if (inMemoryFlushInProgress.get()) {<a name="line.467"></a>
+<span class="sourceLineNo">468</span> compactor.stop();<a name="line.468"></a>
+<span class="sourceLineNo">469</span> }<a name="line.469"></a>
+<span class="sourceLineNo">470</span> }<a name="line.470"></a>
+<span class="sourceLineNo">471</span><a name="line.471"></a>
+<span class="sourceLineNo">472</span> protected void pushActiveToPipeline(MutableSegment active) {<a name="line.472"></a>
+<span class="sourceLineNo">473</span> if (!active.isEmpty()) {<a name="line.473"></a>
+<span class="sourceLineNo">474</span> pipeline.pushHead(active);<a name="line.474"></a>
+<span class="sourceLineNo">475</span> resetActive();<a name="line.475"></a>
+<span class="sourceLineNo">476</span> }<a name="line.476"></a>
+<span class="sourceLineNo">477</span> }<a name="line.477"></a>
+<span class="sourceLineNo">478</span><a name="line.478"></a>
+<span class="sourceLineNo">479</span> private void pushTailToSnapshot() {<a name="line.479"></a>
+<span class="sourceLineNo">480</span> VersionedSegmentsList segments = pipeline.getVersionedTail();<a name="line.480"></a>
+<span class="sourceLineNo">481</span> pushToSnapshot(segments.getStoreSegments());<a name="line.481"></a>
+<span class="sourceLineNo">482</span> // In Swap: don't close segments (they are in snapshot now) and don't update the region size<a name="line.482"></a>
+<span class="sourceLineNo">483</span> pipeline.swap(segments,null,false, false);<a name="line.483"></a>
+<span class="sourceLineNo">484</span> }<a name="line.484"></a>
+<span class="sourceLineNo">485</span><a name="line.485"></a>
+<span class="sourceLineNo">486</span> private void pushPipelineToSnapshot() {<a name="line.486"></a>
+<span class="sourceLineNo">487</span> int iterationsCnt = 0;<a name="line.487"></a>
+<span class="sourceLineNo">488</span> boolean done = false;<a name="line.488"></a>
+<span class="sourceLineNo">489</span> while (!done) {<a name="line.489"></a>
+<span class="sourceLineNo">490</span> iterationsCnt++;<a name="line.490"></a>
+<span class="sourceLineNo">491</span> VersionedSegmentsList segments = pipeline.getVersionedList();<a name="line.491"></a>
+<span class="sourceLineNo">492</span> pushToSnapshot(segments.getStoreSegments());<a name="line.492"></a>
+<span class="sourceLineNo">493</span> // swap can return false in case the pipeline was updated by ongoing compaction<a name="line.493"></a>
+<span class="sourceLineNo">494</span> // and the version increase, the chance of it happenning is very low<a name="line.494"></a>
+<span class="sourceLineNo">495</span> // In Swap: don't close segments (they are in snapshot now) and don't update the region size<a name="line.495"></a>
+<span class="sourceLineNo">496</span> done = pipeline.swap(segments, null, false, false);<a name="line.496"></a>
+<span class="sourceLineNo">497</span> if (iterationsCnt>2) {<a name="line.497"></a>
+<span class="sourceLineNo">498</span> // practically it is impossible that this loop iterates more than two times<a name="line.498"></a>
+<span class="sourceLineNo">499</span> // (because the compaction is stopped and none restarts it while in snapshot request),<a name="line.499"></a>
+<span class="sourceLineNo">500</span> // however stopping here for the case of the infinite loop causing by any error<a name="line.500"></a>
+<span class="sourceLineNo">501</span> LOG.warn("Multiple unsuccessful attempts to push the compaction pipeline to snapshot," +<a name="line.501"></a>
+<span class="sourceLineNo">502</span> " while flushing to disk.");<a name="line.502"></a>
+<span class="sourceLineNo">503</span> this.snapshot = SegmentFactory.instance().createImmutableSegment(getComparator());<a name="line.503"></a>
+<span class="sourceLineNo">504</span> break;<a name="line.504"></a>
+<span class="sourceLineNo">505</span> }<a name="line.505"></a>
+<span class="sourceLineNo">506</span> }<a name="line.506"></a>
+<span class="sourceLineNo">507</span> }<a name="line.507"></a>
+<span class="sourceLineNo">508</span><a name="line.508"></a>
+<span class="sourceLineNo">509</span> private void pushToSnapshot(List<ImmutableSegment> segments) {<a name="line.509"></a>
+<span class="sourceLineNo">510</span> if(segments.isEmpty()) return;<a name="line.510"></a>
+<span class="sourceLineNo">511</span> if(segments.size() == 1 && !segments.get(0).isEmpty()) {<a name="line.511"></a>
+<span class="sourceLineNo">512</span> this.snapshot = segments.get(0);<a name="line.512"></a>
+<span class="sourceLineNo">513</span> return;<a name="line.513"></a>
+<span class="sourceLineNo">514</span> } else { // create composite snapshot<a name="line.514"></a>
+<span class="sourceLineNo">515</span> this.snapshot =<a name="line.515"></a>
+<span class="sourceLineNo">516</span> SegmentFactory.instance().createCompositeImmutableSegment(getComparator(), segments);<a name="line.516"></a>
+<span class="sourceLineNo">517</span> }<a name="line.517"></a>
+<span class="sourceLineNo">518</span> }<a name="line.518"></a>
+<span class="sourceLineNo">519</span><a name="line.519"></a>
+<span class="sourceLineNo">520</span> private RegionServicesForStores getRegionServices() {<a name="line.520"></a>
+<span class="sourceLineNo">521</span> return regionServices;<a name="line.521"></a>
<span class="sourceLineNo">522</span> }<a name="line.522"></a>
<span class="sourceLineNo">523</span><a name="line.523"></a>
-<span class="sourceLineNo">524</span> private RegionServicesForStores getRegionServices() {<a name="line.524"></a>
-<span class="sourceLineNo">525</span> return regionServices;<a name="line.525"></a>
-<span class="sourceLineNo">526</span> }<a name="line.526"></a>
-<span class="sourceLineNo">527</span><a name="line.527"></a>
-<span class="sourceLineNo">528</span> /**<a name="line.528"></a>
-<span class="sourceLineNo">529</span> * The in-memory-flusher thread performs the flush asynchronously.<a name="line.529"></a>
-<span class="sourceLineNo">530</span> * There is at most one thread per memstore instance.<a name="line.530"></a>
-<span class="sourceLineNo">531</span> * It takes the updatesLock exclusively, pushes active into the pipeline, releases updatesLock<a name="line.531"></a>
-<span class="sourceLineNo">532</span> * and compacts the pipeline.<a name="line.532"></a>
-<span class="sourceLineNo">533</span> */<a name="line.533"></a>
-<span class="sourceLineNo">534</span> private class InMemoryFlushRunnable implements Runnable {<a name="line.534"></a>
-<span class="sourceLineNo">535</span><a name="line.535"></a>
-<span class="sourceLineNo">536</span> @Override<a name="line.536"></a>
-<span class="sourceLineNo">537</span> public void run() {<a name="line.537"></a>
-<span class="sourceLineNo">538</span> try {<a name="line.538"></a>
-<span class="sourceLineNo">539</span> flushInMemory();<a name="line.539"></a>
-<span class="sourceLineNo">540</span> } catch (IOException e) {<a name="line.540"></a>
-<span class="sourceLineNo">541</span> LOG.warn("Unable to run memstore compaction. region "<a name="line.541"></a>
-<span class="sourceLineNo">542</span> + getRegionServices().getRegionInfo().getRegionNameAsString()<a name="line.542"></a>
-<span class="sourceLineNo">543</span> + "store: "+ getFamilyName(), e);<a name="line.543"></a>
-<span class="sourceLineNo">544</span> }<a name="line.544"></a>
-<span class="sourceLineNo">545</span> }<a name="line.545"></a>
-<span class="sourceLineNo">546</span> }<a name="line.546"></a>
-<span class="sourceLineNo">547</span><a name="line.547"></a>
-<span class="sourceLineNo">548</span> @VisibleForTesting<a name="line.548"></a>
-<span class="sourceLineNo">549</span> boolean isMemStoreFlushingInMemory() {<a name="line.549"></a>
-<span class="sourceLineNo">550</span> return inMemoryFlushInProgress.get();<a name="line.550"></a>
-<span class="sourceLineNo">551</span> }<a name="line.551"></a>
-<span class="sourceLineNo">552</span><a name="line.552"></a>
-<span class="sourceLineNo">553</span> /**<a name="line.553"></a>
-<span class="sourceLineNo">554</span> * @param cell Find the row that comes after this one. If null, we return the<a name="line.554"></a>
-<span class="sourceLineNo">555</span> * first.<a name="line.555"></a>
-<span class="sourceLineNo">556</span> * @return Next row or null if none found.<a name="line.556"></a>
-<span class="sourceLineNo">557</span> */<a name="line.557"></a>
-<span class="sourceLineNo">558</span> Cell getNextRow(final Cell cell) {<a name="line.558"></a>
-<span class="sourceLineNo">559</span> Cell lowest = null;<a name="line.559"></a>
-<span class="sourceLineNo">560</span> List<Segment> segments = getSegments();<a name="line.560"></a>
-<span class="sourceLineNo">561</span> for (Segment segment : segments) {<a name="line.561"></a>
-<span class="sourceLineNo">562</span> if (lowest == null) {<a name="line.562"></a>
-<span class="sourceLineNo">563</span> lowest = getNextRow(cell, segment.getCellSet());<a name="line.563"></a>
-<span class="sourceLineNo">564</span> } else {<a name="line.564"></a>
-<span class="sourceLineNo">565</span> lowest = getLowest(lowest, getNextRow(cell, segment.getCellSet()));<a name="line.565"></a>
-<span class="sourceLineNo">566</span> }<a name="line.566"></a>
-<span class="sourceLineNo">567</span> }<a name="line.567"></a>
-<span class="sourceLineNo">568</span> return lowest;<a name="line.568"></a>
-<span class="sourceLineNo">569</span> }<a name="line.569"></a>
-<span class="sourceLineNo">570</span><a name="line.570"></a>
-<span class="sourceLineNo">571</span> @VisibleForTesting<a name="line.571"></a>
-<span class="sourceLineNo">572</span> long getInmemoryFlushSize() {<a name="line.572"></a>
-<span class="sourceLineNo">573</span> return inmemoryFlushSize;<a name="line.573"></a>
-<span class="sourceLineNo">574</span> }<a name="line.574"></a>
-<span class="sourceLineNo">575</span><a name="line.575"></a>
-<span class="sourceLineNo">576</span> // debug method<a name="line.576"></a>
-<span class="sourceLineNo">577</span> public void debug() {<a name="line.577"></a>
-<span class="sourceLineNo">578</span> String msg = "active size=" + this.active.keySize();<a name="line.578"></a>
-<span class="sourceLineNo">579</span> msg += " in-memory flush size is "+ inmemoryFlushSize;<a name="line.579"></a>
-<span class="sourceLineNo">580</span> msg += " allow compaction is "+ (allowCompaction.get() ? "true" : "false");<a name="line.580"></a>
-<span class="sourceLineNo">581</span> msg += " inMemoryFlushInProgress is "+ (inMemoryFlushInProgress.get() ? "true" : "false");<a name="line.581"></a>
-<span class="sourceLineNo">582</span> LOG.debug(msg);<a name="line.582"></a>
-<span class="sourceLineNo">583</span> }<a name="line.583"></a>
-<span class="sourceLineNo">584</span><a name="line.584"></a>
-<span class="sourceLineNo">585</span>}<a name="line.585"></a>
+<span class="sourceLineNo">524</span> /**<a name="line.524"></a>
+<span class="sourceLineNo">525</span> * The in-memory-flusher thread performs the flush asynchronously.<a name="line.525"></a>
+<span class="sourceLineNo">526</span> * There is at most one thread per memstore instance.<a name="line.526"></a>
+<span class="sourceLineNo">527</span> * It takes the updatesLock exclusively, pushes active into the pipeline, releases updatesLock<a name="line.527"></a>
+<span class="sourceLineNo">528</span> * and compacts the pipeline.<a name="line.528"></a>
+<span class="sourceLineNo">529</span> */<a name="line.529"></a>
+<span class="sourceLineNo">530</span> private class InMemoryFlushRunnable implements Runnable {<a name="line.530"></a>
+<span class="sourceLineNo">531</span><a name="line.531"></a>
+<span class="sourceLineNo">532</span> @Override<a name="line.532"></a>
+<span class="sourceLineNo">533</span> public void run() {<a name="line.533"></a>
+<span class="sourceLineNo">534</span> try {<a name="line.534"></a>
+<span class="sourceLineNo">535</span> flushInMemory();<a name="line.535"></a>
+<span class="sourceLineNo">536</span> } catch (IOException e) {<a name="line.536"></a>
+<span class="sourceLineNo">537</span> LOG.warn("Unable to run memstore compaction. region "<a name="line.537"></a>
+<span class="sourceLineNo">538</span> + getRegionServices().getRegionInfo().getRegionNameAsString()<a name="line.538"></a>
+<span class="sourceLineNo">539</span> + "store: "+ getFamilyName(), e);<a name="line.539"></a>
+<span class="sourceLineNo">540</span> }<a name="line.540"></a>
+<span class="sourceLineNo">541</span> }<a name="line.541"></a>
+<span class="sourceLineNo">542</span> }<a name="line.542"></a>
+<span class="sourceLineNo">543</span><a name="line.543"></a>
+<span class="sourceLineNo">544</span> @VisibleForTesting<a name="line.544"></a>
+<span class="sourceLineNo">545</span> boolean isMemStoreFlushingInMemory() {<a name="line.545"></a>
+<span class="sourceLineNo">546</span> return inMemoryFlushInProgress.get();<a name="line.546"></a>
+<span class="sourceLineNo">547</span> }<a name="line.547"></a>
+<span class="sourceLineNo">548</span><a name="line.548"></a>
+<span class="sourceLineNo">549</span> /**<a name="line.549"></a>
+<span class="sourceLineNo">550</span> * @param cell Find the row that comes after this one. If null, we return the<a name="line.550"></a>
+<span class="sourceLineNo">551</span> * first.<a name="line.551"></a>
+<span class="sourceLineNo">552</span> * @return Next row or null if none found.<a name="line.552"></a>
+<span class="sourceLineNo">553</span> */<a name="line.553"></a>
+<span class="sourceLineNo">554</span> Cell getNextRow(final Cell cell) {<a name="line.554"></a>
+<span class="sourceLineNo">555</span> Cell lowest = null;<a name="line.555"></a>
+<span class="sourceLineNo">556</span> List<Segment> segments = getSegments();<a name="line.556"></a>
+<span class="sourceLineNo">557</span> for (Segment segment : segments) {<a name="line.557"></a>
+<span class="sourceLineNo">558</span> if (lowest == null) {<a name="line.558"></a>
+<span class="sourceLineNo">559</span> lowest = getNextRow(cell, segment.getCellSet());<a name="line.559"></a>
+<span class="sourceLineNo">560</span> } else {<a name="line.560"></a>
+<span class="sourceLineNo">561</span> lowest = getLowest(lowest, getNextRow(cell, segment.getCellSet()));<a name="line.561"></a>
+<span class="sourceLineNo">562</span> }<a name="line.562"></a>
+<span class="sourceLineNo">563</span> }<a name="line.563"></a>
+<span class="sourceLineNo">564</span> return lowest;<a name="line.564"></a>
+<span class="sourceLineNo">565</span> }<a name="line.565"></a>
+<span class="sourceLineNo">566</span><a name="line.566"></a>
+<span class="sourceLineNo">567</span> @VisibleForTesting<a name="line.567"></a>
+<span class="sourceLineNo">568</span> long getInmemoryFlushSize() {<a name="line.568"></a>
+<span class="sourceLineNo">569</span> return inmemoryFlushSize;<a name="line.569"></a>
+<span class="sourceLineNo">570</span> }<a name="line.570"></a>
+<span class="sourceLineNo">571</span><a name="line.571"></a>
+<span class="sourceLineNo">572</span> // debug method<a name="line.572"></a>
+<span class="sourceLineNo">573</span> public void debug() {<a name="line.573"></a>
+<span class="sourceLineNo">574</span> String msg = "active size=" + this.active.keySize();<a name="line.574"></a>
+<span class="sourceLineNo">575</span> msg += " in-memory flush size is "+ inmemoryFlushSize;<a name="line.575"></a>
+<span class="sourceLineNo">576</span> msg += " allow compaction is "+ (allowCompaction.get() ? "true" : "false");<a name="line.576"></a>
+<span class="sourceLineNo">577</span> msg += " inMemoryFlushInProgress is "+ (inMemoryFlushInProgress.get() ? "true" : "false");<a name="line.577"></a>
+<span class="sourceLineNo">578</span> LOG.debug(msg);<a name="line.578"></a>
+<span class="sourceLineNo">579</span> }<a name="line.579"></a>
+<span class="sourceLineNo">580</span><a name="line.580"></a>
+<span class="sourceLineNo">581</span>}<a name="line.581"></a>