You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/02/24 10:15:42 UTC
Review Request 43938: Required jsonifying of generic protobuf to be
explicit opt-in [stout].
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43938/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Bugs: MESOS-4754
https://issues.apache.org/jira/browse/MESOS-4754
Repository: mesos
Description
-------
See JIRA ticket.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp eb5502c4987da5593169a86b21f60c01aa5b5170
3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp 22f70f7536c6f5d24ff59228d8ba7bf41319fd4a
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 8dd9cfd3e7d1e3ab4ace87066a43a3094b776d82
Diff: https://reviews.apache.org/r/43938/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 43938: Required jsonifying of generic protobuf to
be explicit opt-in [stout].
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43938/#review120476
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (lines 536 - 540)
<https://reviews.apache.org/r/43938/#comment181936>
With this change, we can no longer simply rely on the generic `json` for iterable (`void json(JSON::ArrayWriter* writer, const Iterable& iterable);`) anymore.
But this is no worse than other lambda + manual loops we have currently. The plan is to consider mitigating the plan with `boost::adaptors::transform`.
- Michael Park
On Feb. 24, 2016, 9:15 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43938/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 9:15 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Bugs: MESOS-4754
> https://issues.apache.org/jira/browse/MESOS-4754
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See JIRA ticket.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp eb5502c4987da5593169a86b21f60c01aa5b5170
> 3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp 22f70f7536c6f5d24ff59228d8ba7bf41319fd4a
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 8dd9cfd3e7d1e3ab4ace87066a43a3094b776d82
>
> Diff: https://reviews.apache.org/r/43938/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>