You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/22 06:30:34 UTC

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17387: [TVM][Windows] TVM Ops windows build

hzfan commented on a change in pull request #17387: [TVM][Windows] TVM Ops windows build
URL: https://github.com/apache/incubator-mxnet/pull/17387#discussion_r369388634
 
 

 ##########
 File path: python/mxnet/space.py
 ##########
 @@ -1 +1,214 @@
-../../contrib/tvmop/space.py
 
 Review comment:
   I think copying the file at compile time is good. Why not remove this `python/mxnet/space.py` since it will be generated by your workaround? This way we can avoid duplication.
   
   Also, just FYI, if we go with copying, we may have to make some extra modification to ci. Now ci separates the compiling phase and the testing phase. CI will copy the output of compilation (like libmxnet.so) to the testing phase. In our case, `python/mxnet/space.py` becomes part of the compilation output and must be copied.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services