You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/05 15:50:31 UTC

[GitHub] [airflow] ashb commented on a change in pull request #4880: [AIRFLOW-3735] Separate dag parsing from checking

ashb commented on a change in pull request #4880: [AIRFLOW-3735] Separate dag parsing from checking
URL: https://github.com/apache/airflow/pull/4880#discussion_r272646343
 
 

 ##########
 File path: airflow/models/__init__.py
 ##########
 @@ -1739,7 +1669,7 @@ def email_alert(self, exception):
         jinja_context.update(dict(
             exception=exception,
             exception_html=exception_html,
-            try_number=self.try_number - 1,
+            try_number=self.try_number,
 
 Review comment:
   About all I remember of this code now was it was a hack on top of a hack :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services