You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Xuefu Zhang <xz...@cloudera.com> on 2014/03/16 18:25:52 UTC
Review Request 19265: HIVE-6677: HBaseSerDe needs to be refactored
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19265/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-6677
https://issues.apache.org/jira/browse/HIVE-6677
Repository: hive-git
Description
-------
Pure refactoring. For the purpose of what is described in the JIRA. Mostly, separating key serialization from column serialization. When possible, static methods are used. Some code cleanup is made. All serde properties, including those dedicated for HBaseSerde, is captured in class HBaseSerDeParameters.
Diffs
-----
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 2cd65cb
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDeParameters.java PRE-CREATION
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 29e5da5
hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java db69ae5
Diff: https://reviews.apache.org/r/19265/diff/
Testing
-------
No new tests. Test suite passed successfully.
Thanks,
Xuefu Zhang
Re: Review Request 19265: HIVE-6677: HBaseSerDe needs to be refactored
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19265/#review37516
-----------------------------------------------------------
Looks fine to me.
A minor formatting nits, feel free to ignore.
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java
<https://reviews.apache.org/r/19265/#comment69059>
Nit: whitespace
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java
<https://reviews.apache.org/r/19265/#comment69060>
Nit: indentation
- Prasad Mujumdar
On March 16, 2014, 5:33 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19265/
> -----------------------------------------------------------
>
> (Updated March 16, 2014, 5:33 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6677
> https://issues.apache.org/jira/browse/HIVE-6677
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Pure refactoring. For the purpose of what is described in the JIRA. Mostly, separating key serialization from column serialization. When possible, static methods are used. Some code cleanup is made. All serde properties, including those dedicated for HBaseSerde, is captured in class HBaseSerDeParameters.
>
>
> Diffs
> -----
>
> hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 2cd65cb
> hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDeParameters.java PRE-CREATION
> hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 29e5da5
> hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java db69ae5
>
> Diff: https://reviews.apache.org/r/19265/diff/
>
>
> Testing
> -------
>
> No new tests. Test suite passed successfully.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 19265: HIVE-6677: HBaseSerDe needs to be refactored
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19265/#review37502
-----------------------------------------------------------
hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java
<https://reviews.apache.org/r/19265/#comment69048>
Yes, but parseColumnsMapping(String, boolean) is removed from HiveSerde and mainly needed here. Thus, I think it makes sense to move that to this test class. It just makes the production code cleaner.
- Xuefu Zhang
On March 16, 2014, 5:33 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19265/
> -----------------------------------------------------------
>
> (Updated March 16, 2014, 5:33 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6677
> https://issues.apache.org/jira/browse/HIVE-6677
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Pure refactoring. For the purpose of what is described in the JIRA. Mostly, separating key serialization from column serialization. When possible, static methods are used. Some code cleanup is made. All serde properties, including those dedicated for HBaseSerde, is captured in class HBaseSerDeParameters.
>
>
> Diffs
> -----
>
> hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 2cd65cb
> hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDeParameters.java PRE-CREATION
> hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 29e5da5
> hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java db69ae5
>
> Diff: https://reviews.apache.org/r/19265/diff/
>
>
> Testing
> -------
>
> No new tests. Test suite passed successfully.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 19265: HIVE-6677: HBaseSerDe needs to be refactored
Posted by Swarnim Kulkarni <ku...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19265/#review37500
-----------------------------------------------------------
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDeParameters.java
<https://reviews.apache.org/r/19265/#comment69040>
Javadoc on this class would be nice.
hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java
<https://reviews.apache.org/r/19265/#comment69039>
Nit: Could do a static import of HBaseSerDe#parseColumnMapping to avoid the redundancy.
- Swarnim Kulkarni
On March 16, 2014, 5:33 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19265/
> -----------------------------------------------------------
>
> (Updated March 16, 2014, 5:33 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6677
> https://issues.apache.org/jira/browse/HIVE-6677
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Pure refactoring. For the purpose of what is described in the JIRA. Mostly, separating key serialization from column serialization. When possible, static methods are used. Some code cleanup is made. All serde properties, including those dedicated for HBaseSerde, is captured in class HBaseSerDeParameters.
>
>
> Diffs
> -----
>
> hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 2cd65cb
> hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDeParameters.java PRE-CREATION
> hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 29e5da5
> hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java db69ae5
>
> Diff: https://reviews.apache.org/r/19265/diff/
>
>
> Testing
> -------
>
> No new tests. Test suite passed successfully.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 19265: HIVE-6677: HBaseSerDe needs to be refactored
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19265/
-----------------------------------------------------------
(Updated March 18, 2014, 3:53 a.m.)
Review request for hive.
Bugs: HIVE-6677
https://issues.apache.org/jira/browse/HIVE-6677
Repository: hive-git
Description
-------
Pure refactoring. For the purpose of what is described in the JIRA. Mostly, separating key serialization from column serialization. When possible, static methods are used. Some code cleanup is made. All serde properties, including those dedicated for HBaseSerde, is captured in class HBaseSerDeParameters.
Diffs (updated)
-----
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 2cd65cb
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDeParameters.java PRE-CREATION
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 29e5da5
hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java db69ae5
Diff: https://reviews.apache.org/r/19265/diff/
Testing
-------
No new tests. Test suite passed successfully.
Thanks,
Xuefu Zhang
Re: Review Request 19265: HIVE-6677: HBaseSerDe needs to be refactored
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19265/
-----------------------------------------------------------
(Updated March 16, 2014, 5:33 p.m.)
Review request for hive.
Bugs: HIVE-6677
https://issues.apache.org/jira/browse/HIVE-6677
Repository: hive-git
Description
-------
Pure refactoring. For the purpose of what is described in the JIRA. Mostly, separating key serialization from column serialization. When possible, static methods are used. Some code cleanup is made. All serde properties, including those dedicated for HBaseSerde, is captured in class HBaseSerDeParameters.
Diffs (updated)
-----
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 2cd65cb
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDeParameters.java PRE-CREATION
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 29e5da5
hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java db69ae5
Diff: https://reviews.apache.org/r/19265/diff/
Testing
-------
No new tests. Test suite passed successfully.
Thanks,
Xuefu Zhang