You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2022/10/05 09:48:18 UTC
Re: Review Request 74148: Roles deletion Takes time in Apache Ranger when there are more users, groups, roles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74148/#review224746
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java
Lines 46 (patched)
<https://reviews.apache.org/r/74148/#comment313524>
This change overlaps with the changes in another patch - https://reviews.apache.org/r/74138/, for RANGER-3929. Can you please review and consolidate these two patches? Thanks!
- Madhan Neethiraj
On Sept. 28, 2022, 3:32 p.m., Ramachandran Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74148/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2022, 3:32 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3900
> https://issues.apache.org/jira/browse/RANGER-3900
>
>
> Repository: ranger
>
>
> Description
> -------
>
> We used DB batch write call instead of 1 DB write call for every user,role,group deference
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 56f7ec4c8
> security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java fc56ff88b
> security-admin/src/main/java/org/apache/ranger/db/XXRoleRefGroupDao.java eb470f260
> security-admin/src/main/java/org/apache/ranger/db/XXRoleRefRoleDao.java 8f6fc8cfa
> security-admin/src/main/java/org/apache/ranger/db/XXRoleRefUserDao.java ba9fb494b
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml e4a2354b0
>
>
> Diff: https://reviews.apache.org/r/74148/diff/1/
>
>
> Testing
> -------
>
> test with 1 Role contains 1k other roles and 1k groups
> while deleting the role it took 11.577 seconds
> After fix
> it took 1.021 seconds
>
>
> Thanks,
>
> Ramachandran Krishnan
>
>
Re: Review Request 74148: Roles deletion Takes time in Apache Ranger when there are more users, groups, roles
Posted by Ramachandran Krishnan <ra...@gmail.com>.
> On Oct. 5, 2022, 9:48 a.m., Madhan Neethiraj wrote:
> > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java
> > Lines 46 (patched)
> > <https://reviews.apache.org/r/74148/diff/1/?file=2270261#file2270261line46>
> >
> > This change overlaps with the changes in another patch - https://reviews.apache.org/r/74138/, for RANGER-3929. Can you please review and consolidate these two patches? Thanks!
Sure we will consolidate this change with along with https://reviews.apache.org/r/74138 in this patch itself
- Ramachandran
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74148/#review224746
-----------------------------------------------------------
On Sept. 28, 2022, 3:32 p.m., Ramachandran Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74148/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2022, 3:32 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3900
> https://issues.apache.org/jira/browse/RANGER-3900
>
>
> Repository: ranger
>
>
> Description
> -------
>
> We used DB batch write call instead of 1 DB write call for every user,role,group deference
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 56f7ec4c8
> security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java fc56ff88b
> security-admin/src/main/java/org/apache/ranger/db/XXRoleRefGroupDao.java eb470f260
> security-admin/src/main/java/org/apache/ranger/db/XXRoleRefRoleDao.java 8f6fc8cfa
> security-admin/src/main/java/org/apache/ranger/db/XXRoleRefUserDao.java ba9fb494b
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml e4a2354b0
>
>
> Diff: https://reviews.apache.org/r/74148/diff/1/
>
>
> Testing
> -------
>
> test with 1 Role contains 1k other roles and 1k groups
> while deleting the role it took 11.577 seconds
> After fix
> it took 1.021 seconds
>
>
> Thanks,
>
> Ramachandran Krishnan
>
>