[GitHub] [flink] KarmaGYZ commented on a change in pull request #13311: [FLINK-18721] Migrate YarnResourceManager to the new YarnResourceManagerDriver

[GitBox <gi...@apache.org>]

KarmaGYZ commented on a change in pull request #13311:
URL: https://github.com/apache/flink/pull/13311#discussion_r502152387



##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java
##########
@@ -385,14 +385,14 @@ public void testStopWorkerAfterRegistration() throws Exception {
 			final CompletableFuture<Void> startContainerAsyncFuture = new CompletableFuture<>();
 			final CompletableFuture<Void> stopContainerAsyncFuture = new CompletableFuture<>();
 
-			testingYarnAMRMClientAsync.setGetMatchingRequestsFunction(ignored ->
+			testingYarnAMRMClientAsyncBuilder.setGetMatchingRequestsFunction(ignored ->

Review comment:
       From my understanding, we are sure about that. The `build` function is triggered when the ResourceManager is started, to be specific, in `Context#runTest`. As we now set the builders and trigger `Context#runTest` sequentially in the testing main thread, we could ensure the builders and `containerResource` will always be seen by `ResourceManager`. Do I understand it correctly?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org