[GitHub] [skywalking] dmsolr commented on a change in pull request #7032: kafka transporter code polish

[GitBox <gi...@apache.org>]

dmsolr commented on a change in pull request #7032:
URL: https://github.com/apache/skywalking/pull/7032#discussion_r641147024



##########
File path: apm-sniffer/optional-reporter-plugins/kafka-reporter-plugin/src/main/java/org/apache/skywalking/apm/agent/core/kafka/KafkaProducerManager.java
##########
@@ -142,16 +142,6 @@ private void notifyListeners(KafkaConnectionStatus status) {
         }
     }
 
-    private void closeAdminClient(AdminClient adminClient) {
-        if (adminClient != null) {
-            try {
-                adminClient.close();
-            } catch (Exception e) {
-                LOGGER.error("close kafka admin client failed", e);
-            }
-        }
-    }
-

Review comment:
       `adminClient.close()` has moved to L121  
   Directly close before the operation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org