You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by runseb <gi...@git.apache.org> on 2014/12/22 13:46:57 UTC
[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...
GitHub user runseb opened a pull request:
https://github.com/apache/cloudstack/pull/62
NGUI: Added more functionalities, final patch for angular based UI
This was a patch from Shiva Teja that handed up in my inbox because review board could not handle it.
It adds some functionalities to the angular js UI that lives under /tools
I also removed the comments in the html file.
Edit the config.py file with your cloudstack endpoint and keys
then: python ./app.py and open browser to http://localhost:5000
It can be merged anywhere really…but it's rebased on 4.4
Signed-off-by: Sebastien Goasguen <ru...@gmail.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/runseb/cloudstack 4.4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/62.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #62
----
commit 73842654e33fb3078b49c42e714b0c16f2ada4c2
Author: Shiva Teja Reddy <sh...@gmail.com>
Date: 2013-09-24T21:29:48Z
NGUI: Added more functionalities, final patch for angular based UI
Signed-off-by: Sebastien Goasguen <ru...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...
Posted by runseb <gi...@git.apache.org>.
Github user runseb closed the pull request at:
https://github.com/apache/cloudstack/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...
Posted by runseb <gi...@git.apache.org>.
GitHub user runseb reopened a pull request:
https://github.com/apache/cloudstack/pull/62
NGUI: Added more functionalities, final patch for angular based UI
This was a patch from Shiva Teja that handed up in my inbox because review board could not handle it.
It adds some functionalities to the angular js UI that lives under /tools
I also removed the comments in the html file.
Edit the config.py file with your cloudstack endpoint and keys
then: python ./app.py and open browser to http://localhost:5000
It can be merged anywhere really…but it's rebased on 4.4
Signed-off-by: Sebastien Goasguen <ru...@gmail.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/runseb/cloudstack 4.4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/62.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #62
----
commit 3f292489b548f9ebf62380ed5e39b64eb3c25cb0
Author: Shiva Teja Reddy <sh...@gmail.com>
Date: 2013-09-24T21:29:48Z
NGUI: Added more functionalities, final patch for angular based UI
Signed-off-by: Sebastien Goasguen <ru...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...
Posted by runseb <gi...@git.apache.org>.
Github user runseb closed the pull request at:
https://github.com/apache/cloudstack/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...
Posted by shivateja <gi...@git.apache.org>.
Github user shivateja commented on the pull request:
https://github.com/apache/cloudstack/pull/62#issuecomment-67856339
I'd love to take this up but I'm currently at Amazon and I legally can't touch this.
+1 for adding bower for package management and gulp as the build tool. Bower wasn't documented much when I was working on the project and gulp didn't even exist AFAIK.
The Flask part is just a mirror to ACS and to serve this project files. So the UI should work with it directly. I just didn't want to touch ACS to serve these files and complicate stuff. Project is not directly dependant of Flask.
I'm not sure about the state of ACS and the API changes that have been made. If there were major changes to the API, rewriting would be better. If not, many parts can be reused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/62#issuecomment-67833967
Don't bother, I messed up the commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/62#issuecomment-67858405
the Flask stuff is just old inheritance from us trying to RESTify the cloudstack API….
I do like the idea of having a client side UI. Just like ec2stack which can be run on your own machine.
That way you are not dependent on the choices of the provider.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...
Posted by imduffy15 <gi...@git.apache.org>.
Github user imduffy15 commented on the pull request:
https://github.com/apache/cloudstack/pull/62#issuecomment-67850765
I'm out.... cramming for exams like crazy over the christmas.
Would probably start this from scratch to be honest. I dislike the flask part of it, angularjs should communicate directly with the cloudstack api imho.
My favourite way for front end at the moment is:
build tool gulp
javascript framework angularjs
UI framework bootstrap
Pick up angular-* ng-* and bootstrap-* addons.
Don't copy any external frameworks into source, use bower for everything.
I'm going this route at the moment for a college project. Its not perfect but its a nice start: http://carcloud.ianduffy.ie/
source at https://github.com/imduffy15/carcloud-api files of interest are bower.json, gulpfile.js and src/main/webapp.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/62#issuecomment-67836369
Ok corrected my commit. Again this is from Shiva during the GSoC 2013 program.
Someone should check exactly how it works, check the RAT is passing etc
This has much more functionalities than what is currently there but it seems to use username/password auth to get in…
@shivateja @imduffy15 @BroganD1993 maybe a little christmas fun to get this back on track…:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: NGUI: Added more functionalities,
final p...
Posted by Rohit Yadav <ro...@shapeblue.com>.
In that case, only Sebastien can close it since he created the PR.
Regards.
On Friday 23 January 2015 09:09 PM, Ian Duffy wrote:
> second message from seb says he messed up the commit so I'd imagine
> its safe to close Rohit.
>
> On 23 January 2015 at 15:01, bhaisaab <gi...@git.apache.org> wrote:
> > Github user bhaisaab commented on the pull request:
> >
> > https://github.com/apache/cloudstack/pull/62#issuecomment-71205228
> >
> > If it's in good state, let's merge? If it's old and junk, let's close?
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have your
> > reply appear on GitHub as well. If your project does not have this feature
> > enabled and wishes so, or if the feature is enabled but not working, please
> > contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> > with INFRA.
> > ---
--
Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +91 8826230892 | rohit.yadav@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab
PS. If you see any footer below, I did not add it :)
Find out more about ShapeBlue and our range of CloudStack related services
IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//>
CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/>
CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
CloudStack Software Engineering<http://shapeblue.com/cloudstack-software-engineering/>
CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/>
CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-training/>
This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: [GitHub] cloudstack pull request: NGUI: Added more
functionalities, final p...
Posted by Ian Duffy <ia...@ianduffy.ie>.
second message from seb says he messed up the commit so I'd imagine
its safe to close Rohit.
On 23 January 2015 at 15:01, bhaisaab <gi...@git.apache.org> wrote:
> Github user bhaisaab commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/62#issuecomment-71205228
>
> If it's in good state, let's merge? If it's old and junk, let's close?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/62#issuecomment-71205228
If it's in good state, let's merge? If it's old and junk, let's close?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---