[jira] [Commented] (STORM-1404) Mockito test failures in storm-kafka

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086665#comment-15086665 ] 

ASF GitHub Bot commented on STORM-1404:
---------------------------------------

GitHub user haohui opened a pull request:

    https://github.com/apache/storm/pull/993

    STORM-1404. Mockito test failures in storm-kafka.

    This PR fixes the failed test reported in STORM-1404. It replaces the unreliable `Thread.sleep()` with comprehensive mocking to make sure the tests are reliable.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/haohui/storm STORM-1404

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/993.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #993
    
----
commit de90b185c4976522562dc6f161ed88dbedd2a0fa
Author: Haohui Mai <wh...@apache.org>
Date:   2016-01-07T02:04:13Z

    STORM-1404. Mockito test failures in storm-kafka.

----


> Mockito test failures in storm-kafka
> ------------------------------------
>
>                 Key: STORM-1404
>                 URL: https://issues.apache.org/jira/browse/STORM-1404
>             Project: Apache Storm
>          Issue Type: Sub-task
>          Components: storm-core
>            Reporter: Derek Dagit
>            Assignee: Haohui Mai
>            Priority: Minor
>
> {noformat}
> Tests run: 8, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 17.194 sec <<< FAILURE! - in storm.kafka.bolt.KafkaBoltTest
> executeWithByteArrayKeyAndMessageAsync(storm.kafka.bolt.KafkaBoltTest)  Time elapsed: 3.526 sec  <<< FAILURE!
> org.mockito.exceptions.verification.WantedButNotInvoked: 
> Wanted but not invoked:
> collector.ack(
>     source: null:1, stream: , id: {}, [[B@29e2aabd, [B@603773c6]
> );
> -> at storm.kafka.bolt.KafkaBoltTest.executeWithByteArrayKeyAndMessageAsync(KafkaBoltTest.java:144)
> However, there were other interactions with this mock:
> -> at backtype.storm.task.OutputCollector.reportError(OutputCollector.java:223)
> -> at backtype.storm.task.OutputCollector.fail(OutputCollector.java:218)
> 	at storm.kafka.bolt.KafkaBoltTest.executeWithByteArrayKeyAndMessageAsync(KafkaBoltTest.java:144)
> {noformat}
> Seen [here|https://travis-ci.org/apache/storm/jobs/97734764#L352]
> Not sure about how often this happens, but it is definitely not 100% of the time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)