You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/08/16 20:02:18 UTC

[GitHub] mrutkows commented on a change in pull request #2619: Fix Illegal Header Warnings (WIP)

mrutkows commented on a change in pull request #2619: Fix Illegal Header Warnings (WIP)
URL: https://github.com/apache/incubator-openwhisk/pull/2619#discussion_r133551933
 
 

 ##########
 File path: tests/dat/actions/base64Web.js
 ##########
 @@ -0,0 +1,9 @@
+function main() {
+	  return {
+		  headers: {
+			  "content-type": "application/json"
+		  },
+		  statusCode: 200,
+		  body: new Buffer(JSON.stringify({'status': 'success'})).toString('base64')
+	  }
+}
 
 Review comment:
   @markusthoemmes Currently (and historically), the "tests" directory and its subdirs are listed in the "exclusions" section of the default scancode.cfg file.  Messaged Rodric that I would be happy to remove (and want to remove ALL exclusions), but have been waiting for dozens of PRs to merge to allow even considering this.  I will work to see what impact removing the "tests" folder exclusion and see if I can submit a PR.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services