You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/30 02:16:32 UTC

[GitHub] [apisix] RocFang opened a new issue #2568: bug: uri-blocker's code and doc are confusing

RocFang opened a new issue #2568:
URL: https://github.com/apache/apisix/issues/2568


   ### Issue description
   
   In uri-blocker's doc, we can get every block rule is a independent regular expression.
   But in the code, we can find that every rule is concated into a single regular expression, so `^` and `$` may not work as expected.
   
   I guess the concating operation instead of literate rule array is for performance consideration?
   If so, I think the doc may need some updates for the cenarios mentioned above. thanks. @membphis 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] idbeta commented on issue #2568: bug: uri-blocker's code and doc are confusing

Posted by GitBox <gi...@apache.org>.
idbeta commented on issue #2568:
URL: https://github.com/apache/apisix/issues/2568#issuecomment-719145049


   Can you write more details about regular expressions that go wrong? That would be very helpful


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] RocFang closed issue #2568: bug: uri-blocker's code and doc are confusing

Posted by GitBox <gi...@apache.org>.
RocFang closed issue #2568:
URL: https://github.com/apache/apisix/issues/2568


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] RocFang commented on issue #2568: bug: uri-blocker's code and doc are confusing

Posted by GitBox <gi...@apache.org>.
RocFang commented on issue #2568:
URL: https://github.com/apache/apisix/issues/2568#issuecomment-719148739


   @idbeta sorry, my mistake, ignore it:)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org