[jira] [Commented] (PHOENIX-5253) Use Maven provided resource transformers for Apache LICENSE and NOTICE files

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823337#comment-16823337 ] 

Hadoop QA commented on PHOENIX-5253:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12966635/PHOENIX-5253.patch
  against master branch at commit b4697afc3f23ca29ddd87c8708097cd68f91286d.
  ATTACHMENT ID: 12966635

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 6 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +                    implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer">
+                    implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer">
+                    implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer">
+                    implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer">
+                        implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer">
+                        implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer">

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TenantSpecificViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2523//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2523//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2523//console

This message is automatically generated.

> Use Maven provided resource transformers for Apache LICENSE and NOTICE files
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-5253
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5253
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Andrew Purtell
>            Priority: Major
>         Attachments: PHOENIX-5253.patch
>
>
> Maven ships with resource transformers that do the right thing with respect to Apache LICENSE and NOTICE files. I found that some local build problems during the shading phase were resolved by using these transformers instead of the current approach.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)