You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2013/06/21 04:53:33 UTC
[jclouds] Add Swift-specific MD5 checksum header (#42)
Tested against cloudfiles-us, hpcloud-objectstorage, and
swift-keystone. Reference for ETag:
https://answers.launchpad.net/swift/+question/157064
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds swift-md5
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/42
-- Commit Summary --
* Add Swift-specific MD5 checksum header
-- File Changes --
M apis/swift/src/main/java/org/jclouds/openstack/swift/binders/BindSwiftObjectMetadataToRequest.java (14)
M apis/swift/src/test/java/org/jclouds/openstack/swift/blobstore/SwiftBlobSignerExpectTest.java (1)
M apis/swift/src/test/java/org/jclouds/openstack/swift/blobstore/SwiftKeystoneBlobSignerExpectTest.java (1)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/42.patch
https://github.com/jclouds/jclouds/pull/42.diff
Re: [jclouds] Add Swift-specific MD5 checksum header (#42)
Posted by Andrew Gaul <no...@github.com>.
@demobox I opened JCLOUDS-180 to track your suggestion since this generally applies to all providers. I tested this commit with the integration tests against cloudfiles-us.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/42#issuecomment-20721151
Re: [jclouds] Add Swift-specific MD5 checksum header (#42)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #124](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/124/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/42#issuecomment-19799988
Re: [jclouds] Add Swift-specific MD5 checksum header (#42)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #3](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/3/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/42#issuecomment-19799209
Re: [jclouds] Add Swift-specific MD5 checksum header (#42)
Posted by Andrew Gaul <no...@github.com>.
Closed #42.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/42
Re: [jclouds] Add Swift-specific MD5 checksum header (#42)
Posted by Andrew Phillips <no...@github.com>.
Do we need to verify anywhere that the hash is _not_ set? Otherwise, is there any need for the line that explicitly sets the hash to `null`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/42#issuecomment-19862633
Re: [jclouds] Add Swift-specific MD5 checksum header (#42)
Posted by Andrew Gaul <no...@github.com>.
Pushed to master and 1.6.x.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/42#issuecomment-20722174
Re: [jclouds] Add Swift-specific MD5 checksum header (#42)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #122](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/122/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/42#issuecomment-19796805
Re: [jclouds] Add Swift-specific MD5 checksum header (#42)
Posted by Andrew Bayer <no...@github.com>.
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/42#issuecomment-19832943
Re: [jclouds] Add Swift-specific MD5 checksum header (#42)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #463](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/463/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/42#issuecomment-19799447
Re: [jclouds] Add Swift-specific MD5 checksum header (#42)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #462](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/462/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/42#issuecomment-19796775
Re: [jclouds] Add Swift-specific MD5 checksum header (#42)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #123](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/123/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/42#issuecomment-19798743
Re: [jclouds] Add Swift-specific MD5 checksum header (#42)
Posted by Andrew Gaul <no...@github.com>.
Last commit should be good, I missed some of the provider-specific tests in earlier commits.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/42#issuecomment-19829179
Re: [jclouds] Add Swift-specific MD5 checksum header (#42)
Posted by Andrew Phillips <no...@github.com>.
> I opened JCLOUDS-180 to track your suggestion
Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/42#issuecomment-20726215