[jira] [Commented] (GEODE-1754) InternalLocator.startLocator needs to be cleaned up

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763169#comment-15763169 ] 

ASF GitHub Bot commented on GEODE-1754:
---------------------------------------

GitHub user ameybarve15 opened a pull request:

    https://github.com/apache/geode/pull/323

    GEODE-1754: Cleaned up loadSharedConfigFromDir argument from InternalLocator.startLocator and its associated code calls.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ameybarve15/incubator-geode feature/GEODE-1754

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/323.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #323
    
----
commit fee76f25f96bd01760880141ec642dba3097db1c
Author: Amey Barve <ab...@apache.org>
Date:   2016-12-19T09:17:55Z

    GEODE-1754: Cleaned up loadSharedConfigFromDir argument from
    InternalLocator.startLocator and its associated code calls.

----


> InternalLocator.startLocator needs to be cleaned up
> ---------------------------------------------------
>
>                 Key: GEODE-1754
>                 URL: https://issues.apache.org/jira/browse/GEODE-1754
>             Project: Geode
>          Issue Type: Task
>          Components: management
>            Reporter: Bruce Schuchardt
>            Assignee: Amey Barve
>
> InternalLocator.startLocator was modified to have a loadSharedConfigFromDir parameter that is never used.  It should be removed.
> {noformat}
>   /**
>    * Creates a distribution locator that runs in this VM on the given
>    * port and bind address.
>    * 
>    * This is for internal use only as it does not create a distributed
>    * system unless told to do so.
>    * 
>    * @param port
>    *    the tcp/ip port to listen on
>    * @param logFile
>    *    the file that log messages should be written to
>    * @param logger
>    *    a log writer that should be used (logFile parameter is ignored)
>    * @param securityLogger
>    *    the logger to be used for security related log messages
>    * @param startDistributedSystem
>    *    if true, a distributed system is started
>    * @param dsProperties
>    *    optional properties to configure the distributed system (e.g., mcast addr/port, other locators)
>    * @param peerLocator
>    *    enable peer location services
>    * @param enableServerLocator
>    *    enable server location services
>    * @param hostnameForClients
>    *    the name to give to clients for connecting to this locator
>    * @param loadSharedConfigFromDir TODO:CONFIG
>    * @throws IOException 
>    */
>   public static InternalLocator startLocator(
>     int port,
>     File logFile,
>     File stateFile,
>     InternalLogWriter logger,
>     InternalLogWriter securityLogger,
>     InetAddress bindAddress,
>     boolean startDistributedSystem,
>     java.util.Properties dsProperties,
>     boolean peerLocator, 
>     boolean enableServerLocator, 
>     String hostnameForClients, 
>     boolean loadSharedConfigFromDir
>     )
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)