You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/06/24 09:28:09 UTC
[GitHub] [libcloud] dimgal1 opened a new pull request, #1718: Fix openstack identity bug when auth url contains a path, closes #1717
dimgal1 opened a new pull request, #1718:
URL: https://github.com/apache/libcloud/pull/1718
## Fix Openstack Identity connection issue
### Description
See issue #1717 for more info
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] asfgit merged pull request #1718: Fix openstack identity bug when auth url contains a path, closes #1717
Posted by GitBox <gi...@apache.org>.
asfgit merged PR #1718:
URL: https://github.com/apache/libcloud/pull/1718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1718: Fix openstack identity bug when auth url contains a path, closes #1717
Posted by GitBox <gi...@apache.org>.
Kami commented on PR #1718:
URL: https://github.com/apache/libcloud/pull/1718#issuecomment-1193113741
@dimgal1 Merged into trunk, thanks.
@ZuluPro Would you mind opening a PR which deletes drivers for providers which are not active anymore? And if you could provide any references to those providers not providing services anymore / being offline, that would be great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] dimgal1 commented on pull request #1718: Fix openstack identity bug when auth url contains a path, closes #1717
Posted by GitBox <gi...@apache.org>.
dimgal1 commented on PR #1718:
URL: https://github.com/apache/libcloud/pull/1718#issuecomment-1165762579
It seems that this change broke the `kili` and `cloudwatt` drivers. The cloudwatt is pretty straight forward to fix, however I do not have an account on either of these providers so I will not be able to manually test any of these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] ZuluPro commented on pull request #1718: Fix openstack identity bug when auth url contains a path, closes #1717
Posted by GitBox <gi...@apache.org>.
ZuluPro commented on PR #1718:
URL: https://github.com/apache/libcloud/pull/1718#issuecomment-1193198165
Of course, just need free time!
Le sam. 23 juil. 2022 à 12:58, Tomaz Muraus ***@***.***> a
écrit :
> @dimgal1 <https://github.com/dimgal1> Merged into trunk, thanks.
>
> @ZuluPro <https://github.com/ZuluPro> Would you mind opening a PR which
> deletes drivers for providers which are not active anymore? And if you
> could provide any references to those providers not providing services
> anymore / being offline, that would be great.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/libcloud/pull/1718#issuecomment-1193113741>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAPPM7BJA5CW4XEUD2RJZPDVVPM7JANCNFSM5ZXHWOYQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter commented on pull request #1718: Fix openstack identity bug when auth url contains a path, closes #1717
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1718:
URL: https://github.com/apache/libcloud/pull/1718#issuecomment-1193113716
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1718?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1718](https://codecov.io/gh/apache/libcloud/pull/1718?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c9a38b1) into [trunk](https://codecov.io/gh/apache/libcloud/commit/7a0d7b37f6a4588776a5786894cad8d984618839?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a0d7b3) will **decrease** coverage by `0.00%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/libcloud/pull/1718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1718 +/- ##
==========================================
- Coverage 83.29% 83.29% -0.01%
==========================================
Files 400 400
Lines 87768 87770 +2
Branches 9331 9331
==========================================
Hits 73104 73104
- Misses 11485 11486 +1
- Partials 3179 3180 +1
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/drivers/cloudwatt.py](https://codecov.io/gh/apache/libcloud/pull/1718/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL2Nsb3Vkd2F0dC5weQ==) | `81.35% <60.00%> (-1.98%)` | :arrow_down: |
| [libcloud/common/openstack\_identity.py](https://codecov.io/gh/apache/libcloud/pull/1718/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL29wZW5zdGFja19pZGVudGl0eS5weQ==) | `84.42% <100.00%> (ø)` | |
| [libcloud/compute/drivers/kili.py](https://codecov.io/gh/apache/libcloud/pull/1718/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL2tpbGkucHk=) | `67.64% <100.00%> (ø)` | |
| [libcloud/test/common/test\_openstack\_identity.py](https://codecov.io/gh/apache/libcloud/pull/1718/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21tb24vdGVzdF9vcGVuc3RhY2tfaWRlbnRpdHkucHk=) | `97.09% <100.00%> (-0.02%)` | :arrow_down: |
| [libcloud/test/compute/test\_kili.py](https://codecov.io/gh/apache/libcloud/pull/1718/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfa2lsaS5weQ==) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1718?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1718?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7a0d7b3...c9a38b1](https://codecov.io/gh/apache/libcloud/pull/1718?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] ZuluPro commented on pull request #1718: Fix openstack identity bug when auth url contains a path, closes #1717
Posted by GitBox <gi...@apache.org>.
ZuluPro commented on PR #1718:
URL: https://github.com/apache/libcloud/pull/1718#issuecomment-1170568981
Hi @dimgal1
You can delete CloudWatt, they aren't in service anymore.
For kili, I don't know, but their API is off too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1718: Fix openstack identity bug when auth url contains a path, closes #1717
Posted by GitBox <gi...@apache.org>.
Kami commented on PR #1718:
URL: https://github.com/apache/libcloud/pull/1718#issuecomment-1169184984
Thanks for contributing this bug fix.
I also don't have credentials for those providers handy right now so I can't verify the fix either.
Perhaps original contributor to that drivers (Cloudwatt) may be able to help - @ZuluPro. It looks like I contributed the Kili driver, but that was 8 years ago...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org