You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Xinran Tinney <yu...@gmail.com> on 2018/01/29 16:51:45 UTC
Review Request 65388: SENTRY-2124 LeaderStatusMonitor.toString()
throws IllegalFormatConversionException with AtomicLong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65388/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, Arjun Mishra, Colm O hEigeartaigh, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
Repository: sentry
Description
-------
When I start Sentry, I noticed an exception on the console due to an illegal format string in LeaderStatusMonitor.toString()
java.util.IllegalFormatConversionException: d != java.util.concurrent.atomic.AtomicLong
at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4302)
at java.util.Formatter$FormatSpecifier.printInteger(Formatter.java:2793)
at java.util.Formatter$FormatSpecifier.print(Formatter.java:2747)
at java.util.Formatter.format(Formatter.java:2520)
at java.util.Formatter.format(Formatter.java:2455)
at java.lang.String.format(String.java:2940)
at org.apache.sentry.provider.db.service.persistent.LeaderStatusMonitor.toString(LeaderStatusMonitor.java:282)
at org.slf4j.helpers.MessageFormatter.safeObjectAppend(MessageFormatter.java:297)
at org.slf4j.helpers.MessageFormatter.deeplyAppendParameter(MessageFormatter.java:269)
at org.slf4j.helpers.MessageFormatter.arrayFormat(MessageFormatter.java:227)
at org.slf4j.helpers.MessageFormatter.format(MessageFormatter.java:124)
at org.slf4j.impl.Log4jLoggerAdapter.info(Log4jLoggerAdapter.java:322)
at org.apache.sentry.provider.db.service.persistent.LeaderStatusMonitor.takeLeadership(LeaderStatusMonitor.java:251)
at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$WrappedListener.takeLeadership(LeaderSelector.java:537)
at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.doWork(LeaderSelector.java:399)
at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.doWorkLoop(LeaderSelector.java:444)
at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.access$100(LeaderSelector.java:64)
at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$2.call(LeaderSelector.java:245)
at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$2.call(LeaderSelector.java:239)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/LeaderStatusMonitor.java 25a70bda
Diff: https://reviews.apache.org/r/65388/diff/1/
Testing
-------
mvn clean install
Thanks,
Xinran Tinney
Re: Review Request 65388: SENTRY-2124 LeaderStatusMonitor.toString()
throws IllegalFormatConversionException with AtomicLong
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65388/#review196438
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On Jan. 29, 2018, 4:51 p.m., Xinran Tinney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65388/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 4:51 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Arjun Mishra, Colm O hEigeartaigh, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> When I start Sentry, I noticed an exception on the console due to an illegal format string in LeaderStatusMonitor.toString()
> java.util.IllegalFormatConversionException: d != java.util.concurrent.atomic.AtomicLong
> at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4302)
> at java.util.Formatter$FormatSpecifier.printInteger(Formatter.java:2793)
> at java.util.Formatter$FormatSpecifier.print(Formatter.java:2747)
> at java.util.Formatter.format(Formatter.java:2520)
> at java.util.Formatter.format(Formatter.java:2455)
> at java.lang.String.format(String.java:2940)
> at org.apache.sentry.provider.db.service.persistent.LeaderStatusMonitor.toString(LeaderStatusMonitor.java:282)
> at org.slf4j.helpers.MessageFormatter.safeObjectAppend(MessageFormatter.java:297)
> at org.slf4j.helpers.MessageFormatter.deeplyAppendParameter(MessageFormatter.java:269)
> at org.slf4j.helpers.MessageFormatter.arrayFormat(MessageFormatter.java:227)
> at org.slf4j.helpers.MessageFormatter.format(MessageFormatter.java:124)
> at org.slf4j.impl.Log4jLoggerAdapter.info(Log4jLoggerAdapter.java:322)
> at org.apache.sentry.provider.db.service.persistent.LeaderStatusMonitor.takeLeadership(LeaderStatusMonitor.java:251)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$WrappedListener.takeLeadership(LeaderSelector.java:537)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.doWork(LeaderSelector.java:399)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.doWorkLoop(LeaderSelector.java:444)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.access$100(LeaderSelector.java:64)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$2.call(LeaderSelector.java:245)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$2.call(LeaderSelector.java:239)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/LeaderStatusMonitor.java 25a70bda
>
>
> Diff: https://reviews.apache.org/r/65388/diff/1/
>
>
> Testing
> -------
>
> mvn clean install
>
>
> Thanks,
>
> Xinran Tinney
>
>
Re: Review Request 65388: SENTRY-2124 LeaderStatusMonitor.toString()
throws IllegalFormatConversionException with AtomicLong
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65388/#review196461
-----------------------------------------------------------
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Jan. 29, 2018, 4:51 p.m., Xinran Tinney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65388/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 4:51 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Arjun Mishra, Colm O hEigeartaigh, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> When I start Sentry, I noticed an exception on the console due to an illegal format string in LeaderStatusMonitor.toString()
> java.util.IllegalFormatConversionException: d != java.util.concurrent.atomic.AtomicLong
> at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4302)
> at java.util.Formatter$FormatSpecifier.printInteger(Formatter.java:2793)
> at java.util.Formatter$FormatSpecifier.print(Formatter.java:2747)
> at java.util.Formatter.format(Formatter.java:2520)
> at java.util.Formatter.format(Formatter.java:2455)
> at java.lang.String.format(String.java:2940)
> at org.apache.sentry.provider.db.service.persistent.LeaderStatusMonitor.toString(LeaderStatusMonitor.java:282)
> at org.slf4j.helpers.MessageFormatter.safeObjectAppend(MessageFormatter.java:297)
> at org.slf4j.helpers.MessageFormatter.deeplyAppendParameter(MessageFormatter.java:269)
> at org.slf4j.helpers.MessageFormatter.arrayFormat(MessageFormatter.java:227)
> at org.slf4j.helpers.MessageFormatter.format(MessageFormatter.java:124)
> at org.slf4j.impl.Log4jLoggerAdapter.info(Log4jLoggerAdapter.java:322)
> at org.apache.sentry.provider.db.service.persistent.LeaderStatusMonitor.takeLeadership(LeaderStatusMonitor.java:251)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$WrappedListener.takeLeadership(LeaderSelector.java:537)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.doWork(LeaderSelector.java:399)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.doWorkLoop(LeaderSelector.java:444)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.access$100(LeaderSelector.java:64)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$2.call(LeaderSelector.java:245)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$2.call(LeaderSelector.java:239)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/LeaderStatusMonitor.java 25a70bda
>
>
> Diff: https://reviews.apache.org/r/65388/diff/1/
>
>
> Testing
> -------
>
> mvn clean install
>
>
> Thanks,
>
> Xinran Tinney
>
>
Re: Review Request 65388: SENTRY-2124 LeaderStatusMonitor.toString()
throws IllegalFormatConversionException with AtomicLong
Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65388/#review196439
-----------------------------------------------------------
Ship it!
- Arjun Mishra
On Jan. 29, 2018, 4:51 p.m., Xinran Tinney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65388/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 4:51 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Arjun Mishra, Colm O hEigeartaigh, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> When I start Sentry, I noticed an exception on the console due to an illegal format string in LeaderStatusMonitor.toString()
> java.util.IllegalFormatConversionException: d != java.util.concurrent.atomic.AtomicLong
> at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4302)
> at java.util.Formatter$FormatSpecifier.printInteger(Formatter.java:2793)
> at java.util.Formatter$FormatSpecifier.print(Formatter.java:2747)
> at java.util.Formatter.format(Formatter.java:2520)
> at java.util.Formatter.format(Formatter.java:2455)
> at java.lang.String.format(String.java:2940)
> at org.apache.sentry.provider.db.service.persistent.LeaderStatusMonitor.toString(LeaderStatusMonitor.java:282)
> at org.slf4j.helpers.MessageFormatter.safeObjectAppend(MessageFormatter.java:297)
> at org.slf4j.helpers.MessageFormatter.deeplyAppendParameter(MessageFormatter.java:269)
> at org.slf4j.helpers.MessageFormatter.arrayFormat(MessageFormatter.java:227)
> at org.slf4j.helpers.MessageFormatter.format(MessageFormatter.java:124)
> at org.slf4j.impl.Log4jLoggerAdapter.info(Log4jLoggerAdapter.java:322)
> at org.apache.sentry.provider.db.service.persistent.LeaderStatusMonitor.takeLeadership(LeaderStatusMonitor.java:251)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$WrappedListener.takeLeadership(LeaderSelector.java:537)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.doWork(LeaderSelector.java:399)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.doWorkLoop(LeaderSelector.java:444)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.access$100(LeaderSelector.java:64)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$2.call(LeaderSelector.java:245)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$2.call(LeaderSelector.java:239)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/LeaderStatusMonitor.java 25a70bda
>
>
> Diff: https://reviews.apache.org/r/65388/diff/1/
>
>
> Testing
> -------
>
> mvn clean install
>
>
> Thanks,
>
> Xinran Tinney
>
>
Re: Review Request 65388: SENTRY-2124 LeaderStatusMonitor.toString()
throws IllegalFormatConversionException with AtomicLong
Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65388/#review196460
-----------------------------------------------------------
Ship it!
Ship It!
- Steve Moist
On Jan. 29, 2018, 4:51 p.m., Xinran Tinney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65388/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 4:51 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Arjun Mishra, Colm O hEigeartaigh, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> When I start Sentry, I noticed an exception on the console due to an illegal format string in LeaderStatusMonitor.toString()
> java.util.IllegalFormatConversionException: d != java.util.concurrent.atomic.AtomicLong
> at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4302)
> at java.util.Formatter$FormatSpecifier.printInteger(Formatter.java:2793)
> at java.util.Formatter$FormatSpecifier.print(Formatter.java:2747)
> at java.util.Formatter.format(Formatter.java:2520)
> at java.util.Formatter.format(Formatter.java:2455)
> at java.lang.String.format(String.java:2940)
> at org.apache.sentry.provider.db.service.persistent.LeaderStatusMonitor.toString(LeaderStatusMonitor.java:282)
> at org.slf4j.helpers.MessageFormatter.safeObjectAppend(MessageFormatter.java:297)
> at org.slf4j.helpers.MessageFormatter.deeplyAppendParameter(MessageFormatter.java:269)
> at org.slf4j.helpers.MessageFormatter.arrayFormat(MessageFormatter.java:227)
> at org.slf4j.helpers.MessageFormatter.format(MessageFormatter.java:124)
> at org.slf4j.impl.Log4jLoggerAdapter.info(Log4jLoggerAdapter.java:322)
> at org.apache.sentry.provider.db.service.persistent.LeaderStatusMonitor.takeLeadership(LeaderStatusMonitor.java:251)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$WrappedListener.takeLeadership(LeaderSelector.java:537)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.doWork(LeaderSelector.java:399)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.doWorkLoop(LeaderSelector.java:444)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector.access$100(LeaderSelector.java:64)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$2.call(LeaderSelector.java:245)
> at sentry.org.apache.curator.framework.recipes.leader.LeaderSelector$2.call(LeaderSelector.java:239)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/LeaderStatusMonitor.java 25a70bda
>
>
> Diff: https://reviews.apache.org/r/65388/diff/1/
>
>
> Testing
> -------
>
> mvn clean install
>
>
> Thanks,
>
> Xinran Tinney
>
>