You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Brock Noland <br...@cloudera.com> on 2014/03/17 20:36:44 UTC

Review Request 19314: SENTRY-134 - Use BoneCP, add unique constraint to GROUP_NAME, and expose jdo/datanucleus properties

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19314/
-----------------------------------------------------------

Review request for sentry, Prasad Mujumdar and Shreepadma Venugopalan.


Bugs: SENTRY-134
    https://issues.apache.org/jira/browse/SENTRY-134


Repository: sentry


Description
-------

Fairly straightforward patch to do the three items describe in the description.


Diffs
-----

  pom.xml 9725102 
  sentry-provider/sentry-provider-db/pom.xml d82a564 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 5c87d95 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 29df4c4 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.4.0.sql 85d5085 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.4.0.sql 0508d45 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.4.0.sql 7298923 

Diff: https://reviews.apache.org/r/19314/diff/


Testing
-------

Tests pass.


Thanks,

Brock Noland


Re: Review Request 19314: SENTRY-134 - Use BoneCP, add unique constraint to GROUP_NAME, and expose jdo/datanucleus properties

Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19314/#review37458
-----------------------------------------------------------

Ship it!


Ship It!

- Shreepadma Venugopalan


On March 17, 2014, 7:36 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19314/
> -----------------------------------------------------------
> 
> (Updated March 17, 2014, 7:36 p.m.)
> 
> 
> Review request for sentry, Prasad Mujumdar and Shreepadma Venugopalan.
> 
> 
> Bugs: SENTRY-134
>     https://issues.apache.org/jira/browse/SENTRY-134
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Fairly straightforward patch to do the three items describe in the description.
> 
> 
> Diffs
> -----
> 
>   pom.xml 9725102 
>   sentry-provider/sentry-provider-db/pom.xml d82a564 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 5c87d95 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 29df4c4 
>   sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.4.0.sql 85d5085 
>   sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.4.0.sql 0508d45 
>   sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.4.0.sql 7298923 
> 
> Diff: https://reviews.apache.org/r/19314/diff/
> 
> 
> Testing
> -------
> 
> Tests pass.
> 
> 
> Thanks,
> 
> Brock Noland
> 
>