You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/12/22 16:41:50 UTC
Review Request 54983: Fixed the CMake test target in stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54983/
-----------------------------------------------------------
Review request for mesos, Alex Clemmer and Joseph Wu.
Repository: mesos
Description
-------
See https://reviews.apache.org/r/54985/.
Diffs
-----
3rdparty/stout/tests/CMakeLists.txt e52aa62479a345bbcee70047109ebd80b8f9813d
Diff: https://reviews.apache.org/r/54983/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 54983: Fixed the CMake test target in stout.
Posted by Michael Park <mp...@apache.org>.
> On Dec. 22, 2016, 10:41 a.m., Joseph Wu wrote:
> > I thought you were also going to rename the `stout_tests` target to `stout-tests`?
I will :)
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54983/#review159991
-----------------------------------------------------------
On Dec. 22, 2016, 8:41 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54983/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 8:41 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See https://reviews.apache.org/r/54985/.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/CMakeLists.txt e52aa62479a345bbcee70047109ebd80b8f9813d
>
> Diff: https://reviews.apache.org/r/54983/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 54983: Fixed the CMake test target in stout.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54983/#review159991
-----------------------------------------------------------
Ship it!
I thought you were also going to rename the `stout_tests` target to `stout-tests`?
- Joseph Wu
On Dec. 22, 2016, 8:41 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54983/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 8:41 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See https://reviews.apache.org/r/54985/.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/CMakeLists.txt e52aa62479a345bbcee70047109ebd80b8f9813d
>
> Diff: https://reviews.apache.org/r/54983/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>