[GitHub] [bigtop] iwasakims commented on a diff in pull request #1095: BIGTOP-3921: Add ZSTD Codec Support for hadoop

["iwasakims (via GitHub)" <gi...@apache.org>]

iwasakims commented on code in PR #1095:
URL: https://github.com/apache/bigtop/pull/1095#discussion_r1150654839


##########
bigtop-packages/src/common/hadoop/do-component-build:
##########
@@ -120,6 +120,12 @@ if [ -z "$BUNDLE_SNAPPY" ] ; then
   [ -f /usr/lib/${HOSTTYPE}-linux-gnu/libsnappy.so ] && BUNDLE_SNAPPY="-Dsnappy.prefix=x -Dbundle.snappy=true -Dsnappy.lib=/usr/lib/${HOSTTYPE}-linux-gnu"
 fi
 
+if [ -z "$BUNDLE_ZSTD" ] ; then
+  [ -f /usr/lib/libzstd.so ] && BUNDLE_ZSTD="-Dbundle.zstd=true -Dzstd.lib=/usr/lib"
+  [ -f /usr/lib64/libzstd.so ] && BUNDLE_ZSTD="-Dbundle.zstd=true -Dzstd.lib=/usr/lib64"
+  [ -f /usr/lib/${HOSTTYPE}-linux-gnu/libzstd.so ] && BUNDLE_ZSTD="-Dbundle.zstd=true -Dzstd.lib=/usr/lib/${HOSTTYPE}-linux-gnu"

Review Comment:
   Can we expect all supported distro/platform have libzstd.so? We can add package dependency on libzstd to make it certain that the required library is installed to runtime environment if so.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org