You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Antoine Pitrou <an...@python.org> on 2018/12/12 18:24:02 UTC
Reviewing PRs (was: Re: Arrow sync call)
Hi,
Now that we have a lot of different implementations and a growing number
of assorted topics, it becomes hard to know whether a PR or issue has a
dedicated expert or would benefit from an outsider look.
In Python we have what we call the "experts" list which is a per-topic
(or per-library module) contributors who are generally interested in and
competent on such topic (*). So it's possible to cc such a person, or
if no expert is available on a given topic, perhaps for someone else to
try and have a look anyway. Perhaps we need something similar for Arrow?
(*) https://devguide.python.org/experts/
Regards
Antoine.
Le 12/12/2018 à 19:13, Ravindra Pindikura a écrit :
> Attendees : Wes, Sidd, Bryan, Francois, Hatem, Nick, Shyam, Ravindra, Matt
>
> Wes:
> - do not rush the 0.12 release before the holidays, instead target the release for early next year
> - request everyone to look at PRs in the queue, and help by doing reviews
>
> Wes/Nick
> - queried about Interest in developing a "dataset abstraction" as a layer above file readers that arrow now supports (parquet, csv, json)
>
> Sidd
> - agreed to be the release manager for 0.12
> - things to keep in mind for release managers :
> 1. We now use crossbow to automate the building of binaries with CI
> 2. From this release, the binary artifacts will be hosted in bintray instead of apache dist since the size has increased significantly
>
> Hatem
> - Asked about documentation regarding IDE for setup/debug of arrow libraries
> - Wes pointed out the developer wiki on confluence. Hatem offered to help with documentation.
>
> Thanks and regards,
> Ravindra.
>
> On 2018/12/12 16:54:21, Wes McKinney <w....@gmail.com> wrote:
>> All are welcome to join -- call notes will be posted after>
>>
>> https://meet.google.com/vtm-teks-phx>
Re: Reviewing PRs (was: Re: Arrow sync call)
Posted by Krisztián Szűcs <sz...@gmail.com>.
We now have nightly docs build:
https://github.com/kszucs/crossbow/branches/all?utf8=%E2%9C%93&query=docs
If We decide where to upload it, We can publish nightly dev docs.
On Wed, Dec 19, 2018 at 3:12 PM Wes McKinney <we...@gmail.com> wrote:
> Indeed. I had opened an issue about this some time ago
>
> https://issues.apache.org/jira/browse/ARROW-1299
>
> On Wed, Dec 19, 2018 at 8:10 AM Antoine Pitrou <an...@python.org> wrote:
> >
> >
> > Le 19/12/2018 à 15:07, Wes McKinney a écrit :
> > > +1 also. The C++ README has grown quite long, for example. Probably to
> > > put all of that in the Sphinx project.
> > >
> > > One downside of Sphinx is that some things can grow out of date on the
> > > website in between releases. Within the codebase itself, we can remedy
> > > this by directing people to the .rst files rather than the website
> >
> > Ideally we would provide a "dev" (i.e. git master) doc build in addition
> > to the doc build for the latest release.
> >
> > Regards
> >
> > Antoine.
>
Re: Reviewing PRs (was: Re: Arrow sync call)
Posted by Wes McKinney <we...@gmail.com>.
Indeed. I had opened an issue about this some time ago
https://issues.apache.org/jira/browse/ARROW-1299
On Wed, Dec 19, 2018 at 8:10 AM Antoine Pitrou <an...@python.org> wrote:
>
>
> Le 19/12/2018 à 15:07, Wes McKinney a écrit :
> > +1 also. The C++ README has grown quite long, for example. Probably to
> > put all of that in the Sphinx project.
> >
> > One downside of Sphinx is that some things can grow out of date on the
> > website in between releases. Within the codebase itself, we can remedy
> > this by directing people to the .rst files rather than the website
>
> Ideally we would provide a "dev" (i.e. git master) doc build in addition
> to the doc build for the latest release.
>
> Regards
>
> Antoine.
Re: Reviewing PRs (was: Re: Arrow sync call)
Posted by Antoine Pitrou <an...@python.org>.
Le 19/12/2018 à 15:07, Wes McKinney a écrit :
> +1 also. The C++ README has grown quite long, for example. Probably to
> put all of that in the Sphinx project.
>
> One downside of Sphinx is that some things can grow out of date on the
> website in between releases. Within the codebase itself, we can remedy
> this by directing people to the .rst files rather than the website
Ideally we would provide a "dev" (i.e. git master) doc build in addition
to the doc build for the latest release.
Regards
Antoine.
Re: Reviewing PRs (was: Re: Arrow sync call)
Posted by Wes McKinney <we...@gmail.com>.
+1 also. The C++ README has grown quite long, for example. Probably to
put all of that in the Sphinx project.
One downside of Sphinx is that some things can grow out of date on the
website in between releases. Within the codebase itself, we can remedy
this by directing people to the .rst files rather than the website
On Wed, Dec 19, 2018 at 5:36 AM Uwe L. Korn <uw...@xhochy.com> wrote:
>
> +1, I would also like to see them in Sphinx.
>
> Uwe
>
> > Am 19.12.2018 um 11:13 schrieb Antoine Pitrou <an...@python.org>:
> >
> >
> > We should decide where we want to put developer docs.
> >
> > I would favour putting them in the Sphinx docs, personally.
> >
> > Regards
> >
> > Antoine.
> >
> >
> >> Le 19/12/2018 à 02:20, Wes McKinney a écrit :
> >> Some projects have a REVIEWERS.md file
> >>
> >> https://github.com/apache/parquet-mr/blob/master/parquet-common/REVIEWERS.md
> >>
> >> We could do the same, or keep the file on the project wiki so it's
> >> lighter-weight to change (no pull request required)
> >>
> >> https://cwiki.apache.org/confluence/display/ARROW
> >>
> >> +1 for adding labels to PRs in any case. We use the [COMPONENT] naming
> >> in the title so people can set up e-mail filters (the GitHub labels
> >> don't come through in their e-mail notification AFAICT)
> >>
> >>> On Tue, Dec 18, 2018 at 1:10 AM Chao Sun <su...@apache.org> wrote:
> >>>
> >>> +1 on adding labels for languages, review states, components, etc. This
> >>> makes it much easier to filter PRs.
> >>>
> >>> Chao
> >>>
> >>> On Wed, Dec 12, 2018 at 11:54 AM Krisztián Szűcs <sz...@gmail.com>
> >>> wrote:
> >>>
> >>>> Create a new one and set arrow-xxx as parent:
> >>>> [image: image.png]
> >>>>
> >>>>> On Wed, Dec 12, 2018 at 7:46 PM Antoine Pitrou <an...@python.org> wrote:
> >>>>>
> >>>>>
> >>>>> Apparently it's possible to create GitHub teams inside the Apache
> >>>>> organization ourselves. I've just created a dummy one:
> >>>>> https://github.com/orgs/apache/teams/arrow-xxx/members
> >>>>>
> >>>>> However, I cannot create a child team inside of the arrow-committers
> >>>>> team. The button "Add a team" here is grayed out:
> >>>>> https://github.com/orgs/apache/teams/arrow-committers/teams
> >>>>>
> >>>>> Regards
> >>>>>
> >>>>> Antoine.
> >>>>>
> >>>>>
> >>>>>> Le 12/12/2018 à 19:40, Krisztián Szűcs a écrit :
> >>>>>> I like the GitHub teams approach. Do We need to ask INFRA to create
> >>>>> them?
> >>>>>>
> >>>>>>> On Wed, Dec 12, 2018, 7:28 PM Sebastien Binet <binet@cern.ch wrote:
> >>>>>>>
> >>>>>>> On Wed, Dec 12, 2018 at 7:25 PM Antoine Pitrou <an...@python.org>
> >>>>> wrote:
> >>>>>>>
> >>>>>>>>
> >>>>>>>> Hi,
> >>>>>>>>
> >>>>>>>> Now that we have a lot of different implementations and a growing
> >>>>> number
> >>>>>>>> of assorted topics, it becomes hard to know whether a PR or issue has
> >>>>> a
> >>>>>>>> dedicated expert or would benefit from an outsider look.
> >>>>>>>>
> >>>>>>>> In Python we have what we call the "experts" list which is a per-topic
> >>>>>>>> (or per-library module) contributors who are generally interested in
> >>>>> and
> >>>>>>>> competent on such topic (*). So it's possible to cc such a person, or
> >>>>>>>> if no expert is available on a given topic, perhaps for someone else
> >>>>> to
> >>>>>>>> try and have a look anyway. Perhaps we need something similar for
> >>>>> Arrow?
> >>>>>>>>
> >>>>>>>
> >>>>>>> with github, one can also create "teams" and "@" them.
> >>>>>>> we could perhaps create @arrow-py, @arrow-cxx, @arrow-go, ...
> >>>>>>> this dilutes a bit responsibilities but also reduces a bit the net
> >>>>> that's
> >>>>>>> cast.
> >>>>>>>
> >>>>>>> -s
> >>>>>>>
> >>>>>>>
> >>>>>>>> (*) https://devguide.python.org/experts/
> >>>>>>>>
> >>>>>>>> Regards
> >>>>>>>>
> >>>>>>>> Antoine.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> Le 12/12/2018 à 19:13, Ravindra Pindikura a écrit :
> >>>>>>>>> Attendees : Wes, Sidd, Bryan, Francois, Hatem, Nick, Shyam, Ravindra,
> >>>>>>>> Matt
> >>>>>>>>>
> >>>>>>>>> Wes:
> >>>>>>>>> - do not rush the 0.12 release before the holidays, instead target
> >>>>> the
> >>>>>>>> release for early next year
> >>>>>>>>> - request everyone to look at PRs in the queue, and help by doing
> >>>>>>> reviews
> >>>>>>>>>
> >>>>>>>>> Wes/Nick
> >>>>>>>>> - queried about Interest in developing a "dataset abstraction" as a
> >>>>>>>> layer above file readers that arrow now supports (parquet, csv, json)
> >>>>>>>>>
> >>>>>>>>> Sidd
> >>>>>>>>> - agreed to be the release manager for 0.12
> >>>>>>>>> - things to keep in mind for release managers :
> >>>>>>>>> 1. We now use crossbow to automate the building of binaries with CI
> >>>>>>>>> 2. From this release, the binary artifacts will be hosted in bintray
> >>>>>>>> instead of apache dist since the size has increased significantly
> >>>>>>>>>
> >>>>>>>>> Hatem
> >>>>>>>>> - Asked about documentation regarding IDE for setup/debug of arrow
> >>>>>>>> libraries
> >>>>>>>>> - Wes pointed out the developer wiki on confluence. Hatem offered to
> >>>>>>>> help with documentation.
> >>>>>>>>>
> >>>>>>>>> Thanks and regards,
> >>>>>>>>> Ravindra.
> >>>>>>>>>
> >>>>>>>>>> On 2018/12/12 16:54:21, Wes McKinney <w....@gmail.com> wrote:
> >>>>>>>>>> All are welcome to join -- call notes will be posted after>
> >>>>>>>>>>
> >>>>>>>>>> https://meet.google.com/vtm-teks-phx>
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
>
Re: Reviewing PRs (was: Re: Arrow sync call)
Posted by "Uwe L. Korn" <uw...@xhochy.com>.
+1, I would also like to see them in Sphinx.
Uwe
> Am 19.12.2018 um 11:13 schrieb Antoine Pitrou <an...@python.org>:
>
>
> We should decide where we want to put developer docs.
>
> I would favour putting them in the Sphinx docs, personally.
>
> Regards
>
> Antoine.
>
>
>> Le 19/12/2018 à 02:20, Wes McKinney a écrit :
>> Some projects have a REVIEWERS.md file
>>
>> https://github.com/apache/parquet-mr/blob/master/parquet-common/REVIEWERS.md
>>
>> We could do the same, or keep the file on the project wiki so it's
>> lighter-weight to change (no pull request required)
>>
>> https://cwiki.apache.org/confluence/display/ARROW
>>
>> +1 for adding labels to PRs in any case. We use the [COMPONENT] naming
>> in the title so people can set up e-mail filters (the GitHub labels
>> don't come through in their e-mail notification AFAICT)
>>
>>> On Tue, Dec 18, 2018 at 1:10 AM Chao Sun <su...@apache.org> wrote:
>>>
>>> +1 on adding labels for languages, review states, components, etc. This
>>> makes it much easier to filter PRs.
>>>
>>> Chao
>>>
>>> On Wed, Dec 12, 2018 at 11:54 AM Krisztián Szűcs <sz...@gmail.com>
>>> wrote:
>>>
>>>> Create a new one and set arrow-xxx as parent:
>>>> [image: image.png]
>>>>
>>>>> On Wed, Dec 12, 2018 at 7:46 PM Antoine Pitrou <an...@python.org> wrote:
>>>>>
>>>>>
>>>>> Apparently it's possible to create GitHub teams inside the Apache
>>>>> organization ourselves. I've just created a dummy one:
>>>>> https://github.com/orgs/apache/teams/arrow-xxx/members
>>>>>
>>>>> However, I cannot create a child team inside of the arrow-committers
>>>>> team. The button "Add a team" here is grayed out:
>>>>> https://github.com/orgs/apache/teams/arrow-committers/teams
>>>>>
>>>>> Regards
>>>>>
>>>>> Antoine.
>>>>>
>>>>>
>>>>>> Le 12/12/2018 à 19:40, Krisztián Szűcs a écrit :
>>>>>> I like the GitHub teams approach. Do We need to ask INFRA to create
>>>>> them?
>>>>>>
>>>>>>> On Wed, Dec 12, 2018, 7:28 PM Sebastien Binet <binet@cern.ch wrote:
>>>>>>>
>>>>>>> On Wed, Dec 12, 2018 at 7:25 PM Antoine Pitrou <an...@python.org>
>>>>> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Now that we have a lot of different implementations and a growing
>>>>> number
>>>>>>>> of assorted topics, it becomes hard to know whether a PR or issue has
>>>>> a
>>>>>>>> dedicated expert or would benefit from an outsider look.
>>>>>>>>
>>>>>>>> In Python we have what we call the "experts" list which is a per-topic
>>>>>>>> (or per-library module) contributors who are generally interested in
>>>>> and
>>>>>>>> competent on such topic (*). So it's possible to cc such a person, or
>>>>>>>> if no expert is available on a given topic, perhaps for someone else
>>>>> to
>>>>>>>> try and have a look anyway. Perhaps we need something similar for
>>>>> Arrow?
>>>>>>>>
>>>>>>>
>>>>>>> with github, one can also create "teams" and "@" them.
>>>>>>> we could perhaps create @arrow-py, @arrow-cxx, @arrow-go, ...
>>>>>>> this dilutes a bit responsibilities but also reduces a bit the net
>>>>> that's
>>>>>>> cast.
>>>>>>>
>>>>>>> -s
>>>>>>>
>>>>>>>
>>>>>>>> (*) https://devguide.python.org/experts/
>>>>>>>>
>>>>>>>> Regards
>>>>>>>>
>>>>>>>> Antoine.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Le 12/12/2018 à 19:13, Ravindra Pindikura a écrit :
>>>>>>>>> Attendees : Wes, Sidd, Bryan, Francois, Hatem, Nick, Shyam, Ravindra,
>>>>>>>> Matt
>>>>>>>>>
>>>>>>>>> Wes:
>>>>>>>>> - do not rush the 0.12 release before the holidays, instead target
>>>>> the
>>>>>>>> release for early next year
>>>>>>>>> - request everyone to look at PRs in the queue, and help by doing
>>>>>>> reviews
>>>>>>>>>
>>>>>>>>> Wes/Nick
>>>>>>>>> - queried about Interest in developing a "dataset abstraction" as a
>>>>>>>> layer above file readers that arrow now supports (parquet, csv, json)
>>>>>>>>>
>>>>>>>>> Sidd
>>>>>>>>> - agreed to be the release manager for 0.12
>>>>>>>>> - things to keep in mind for release managers :
>>>>>>>>> 1. We now use crossbow to automate the building of binaries with CI
>>>>>>>>> 2. From this release, the binary artifacts will be hosted in bintray
>>>>>>>> instead of apache dist since the size has increased significantly
>>>>>>>>>
>>>>>>>>> Hatem
>>>>>>>>> - Asked about documentation regarding IDE for setup/debug of arrow
>>>>>>>> libraries
>>>>>>>>> - Wes pointed out the developer wiki on confluence. Hatem offered to
>>>>>>>> help with documentation.
>>>>>>>>>
>>>>>>>>> Thanks and regards,
>>>>>>>>> Ravindra.
>>>>>>>>>
>>>>>>>>>> On 2018/12/12 16:54:21, Wes McKinney <w....@gmail.com> wrote:
>>>>>>>>>> All are welcome to join -- call notes will be posted after>
>>>>>>>>>>
>>>>>>>>>> https://meet.google.com/vtm-teks-phx>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
Re: Reviewing PRs (was: Re: Arrow sync call)
Posted by Antoine Pitrou <an...@python.org>.
We should decide where we want to put developer docs.
I would favour putting them in the Sphinx docs, personally.
Regards
Antoine.
Le 19/12/2018 à 02:20, Wes McKinney a écrit :
> Some projects have a REVIEWERS.md file
>
> https://github.com/apache/parquet-mr/blob/master/parquet-common/REVIEWERS.md
>
> We could do the same, or keep the file on the project wiki so it's
> lighter-weight to change (no pull request required)
>
> https://cwiki.apache.org/confluence/display/ARROW
>
> +1 for adding labels to PRs in any case. We use the [COMPONENT] naming
> in the title so people can set up e-mail filters (the GitHub labels
> don't come through in their e-mail notification AFAICT)
>
> On Tue, Dec 18, 2018 at 1:10 AM Chao Sun <su...@apache.org> wrote:
>>
>> +1 on adding labels for languages, review states, components, etc. This
>> makes it much easier to filter PRs.
>>
>> Chao
>>
>> On Wed, Dec 12, 2018 at 11:54 AM Krisztián Szűcs <sz...@gmail.com>
>> wrote:
>>
>>> Create a new one and set arrow-xxx as parent:
>>> [image: image.png]
>>>
>>> On Wed, Dec 12, 2018 at 7:46 PM Antoine Pitrou <an...@python.org> wrote:
>>>
>>>>
>>>> Apparently it's possible to create GitHub teams inside the Apache
>>>> organization ourselves. I've just created a dummy one:
>>>> https://github.com/orgs/apache/teams/arrow-xxx/members
>>>>
>>>> However, I cannot create a child team inside of the arrow-committers
>>>> team. The button "Add a team" here is grayed out:
>>>> https://github.com/orgs/apache/teams/arrow-committers/teams
>>>>
>>>> Regards
>>>>
>>>> Antoine.
>>>>
>>>>
>>>> Le 12/12/2018 à 19:40, Krisztián Szűcs a écrit :
>>>>> I like the GitHub teams approach. Do We need to ask INFRA to create
>>>> them?
>>>>>
>>>>> On Wed, Dec 12, 2018, 7:28 PM Sebastien Binet <binet@cern.ch wrote:
>>>>>
>>>>>> On Wed, Dec 12, 2018 at 7:25 PM Antoine Pitrou <an...@python.org>
>>>> wrote:
>>>>>>
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Now that we have a lot of different implementations and a growing
>>>> number
>>>>>>> of assorted topics, it becomes hard to know whether a PR or issue has
>>>> a
>>>>>>> dedicated expert or would benefit from an outsider look.
>>>>>>>
>>>>>>> In Python we have what we call the "experts" list which is a per-topic
>>>>>>> (or per-library module) contributors who are generally interested in
>>>> and
>>>>>>> competent on such topic (*). So it's possible to cc such a person, or
>>>>>>> if no expert is available on a given topic, perhaps for someone else
>>>> to
>>>>>>> try and have a look anyway. Perhaps we need something similar for
>>>> Arrow?
>>>>>>>
>>>>>>
>>>>>> with github, one can also create "teams" and "@" them.
>>>>>> we could perhaps create @arrow-py, @arrow-cxx, @arrow-go, ...
>>>>>> this dilutes a bit responsibilities but also reduces a bit the net
>>>> that's
>>>>>> cast.
>>>>>>
>>>>>> -s
>>>>>>
>>>>>>
>>>>>>> (*) https://devguide.python.org/experts/
>>>>>>>
>>>>>>> Regards
>>>>>>>
>>>>>>> Antoine.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Le 12/12/2018 à 19:13, Ravindra Pindikura a écrit :
>>>>>>>> Attendees : Wes, Sidd, Bryan, Francois, Hatem, Nick, Shyam, Ravindra,
>>>>>>> Matt
>>>>>>>>
>>>>>>>> Wes:
>>>>>>>> - do not rush the 0.12 release before the holidays, instead target
>>>> the
>>>>>>> release for early next year
>>>>>>>> - request everyone to look at PRs in the queue, and help by doing
>>>>>> reviews
>>>>>>>>
>>>>>>>> Wes/Nick
>>>>>>>> - queried about Interest in developing a "dataset abstraction" as a
>>>>>>> layer above file readers that arrow now supports (parquet, csv, json)
>>>>>>>>
>>>>>>>> Sidd
>>>>>>>> - agreed to be the release manager for 0.12
>>>>>>>> - things to keep in mind for release managers :
>>>>>>>> 1. We now use crossbow to automate the building of binaries with CI
>>>>>>>> 2. From this release, the binary artifacts will be hosted in bintray
>>>>>>> instead of apache dist since the size has increased significantly
>>>>>>>>
>>>>>>>> Hatem
>>>>>>>> - Asked about documentation regarding IDE for setup/debug of arrow
>>>>>>> libraries
>>>>>>>> - Wes pointed out the developer wiki on confluence. Hatem offered to
>>>>>>> help with documentation.
>>>>>>>>
>>>>>>>> Thanks and regards,
>>>>>>>> Ravindra.
>>>>>>>>
>>>>>>>> On 2018/12/12 16:54:21, Wes McKinney <w....@gmail.com> wrote:
>>>>>>>>> All are welcome to join -- call notes will be posted after>
>>>>>>>>>
>>>>>>>>> https://meet.google.com/vtm-teks-phx>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
Re: Reviewing PRs (was: Re: Arrow sync call)
Posted by Wes McKinney <we...@gmail.com>.
Some projects have a REVIEWERS.md file
https://github.com/apache/parquet-mr/blob/master/parquet-common/REVIEWERS.md
We could do the same, or keep the file on the project wiki so it's
lighter-weight to change (no pull request required)
https://cwiki.apache.org/confluence/display/ARROW
+1 for adding labels to PRs in any case. We use the [COMPONENT] naming
in the title so people can set up e-mail filters (the GitHub labels
don't come through in their e-mail notification AFAICT)
On Tue, Dec 18, 2018 at 1:10 AM Chao Sun <su...@apache.org> wrote:
>
> +1 on adding labels for languages, review states, components, etc. This
> makes it much easier to filter PRs.
>
> Chao
>
> On Wed, Dec 12, 2018 at 11:54 AM Krisztián Szűcs <sz...@gmail.com>
> wrote:
>
> > Create a new one and set arrow-xxx as parent:
> > [image: image.png]
> >
> > On Wed, Dec 12, 2018 at 7:46 PM Antoine Pitrou <an...@python.org> wrote:
> >
> >>
> >> Apparently it's possible to create GitHub teams inside the Apache
> >> organization ourselves. I've just created a dummy one:
> >> https://github.com/orgs/apache/teams/arrow-xxx/members
> >>
> >> However, I cannot create a child team inside of the arrow-committers
> >> team. The button "Add a team" here is grayed out:
> >> https://github.com/orgs/apache/teams/arrow-committers/teams
> >>
> >> Regards
> >>
> >> Antoine.
> >>
> >>
> >> Le 12/12/2018 à 19:40, Krisztián Szűcs a écrit :
> >> > I like the GitHub teams approach. Do We need to ask INFRA to create
> >> them?
> >> >
> >> > On Wed, Dec 12, 2018, 7:28 PM Sebastien Binet <binet@cern.ch wrote:
> >> >
> >> >> On Wed, Dec 12, 2018 at 7:25 PM Antoine Pitrou <an...@python.org>
> >> wrote:
> >> >>
> >> >>>
> >> >>> Hi,
> >> >>>
> >> >>> Now that we have a lot of different implementations and a growing
> >> number
> >> >>> of assorted topics, it becomes hard to know whether a PR or issue has
> >> a
> >> >>> dedicated expert or would benefit from an outsider look.
> >> >>>
> >> >>> In Python we have what we call the "experts" list which is a per-topic
> >> >>> (or per-library module) contributors who are generally interested in
> >> and
> >> >>> competent on such topic (*). So it's possible to cc such a person, or
> >> >>> if no expert is available on a given topic, perhaps for someone else
> >> to
> >> >>> try and have a look anyway. Perhaps we need something similar for
> >> Arrow?
> >> >>>
> >> >>
> >> >> with github, one can also create "teams" and "@" them.
> >> >> we could perhaps create @arrow-py, @arrow-cxx, @arrow-go, ...
> >> >> this dilutes a bit responsibilities but also reduces a bit the net
> >> that's
> >> >> cast.
> >> >>
> >> >> -s
> >> >>
> >> >>
> >> >>> (*) https://devguide.python.org/experts/
> >> >>>
> >> >>> Regards
> >> >>>
> >> >>> Antoine.
> >> >>>
> >> >>>
> >> >>>
> >> >>> Le 12/12/2018 à 19:13, Ravindra Pindikura a écrit :
> >> >>>> Attendees : Wes, Sidd, Bryan, Francois, Hatem, Nick, Shyam, Ravindra,
> >> >>> Matt
> >> >>>>
> >> >>>> Wes:
> >> >>>> - do not rush the 0.12 release before the holidays, instead target
> >> the
> >> >>> release for early next year
> >> >>>> - request everyone to look at PRs in the queue, and help by doing
> >> >> reviews
> >> >>>>
> >> >>>> Wes/Nick
> >> >>>> - queried about Interest in developing a "dataset abstraction" as a
> >> >>> layer above file readers that arrow now supports (parquet, csv, json)
> >> >>>>
> >> >>>> Sidd
> >> >>>> - agreed to be the release manager for 0.12
> >> >>>> - things to keep in mind for release managers :
> >> >>>> 1. We now use crossbow to automate the building of binaries with CI
> >> >>>> 2. From this release, the binary artifacts will be hosted in bintray
> >> >>> instead of apache dist since the size has increased significantly
> >> >>>>
> >> >>>> Hatem
> >> >>>> - Asked about documentation regarding IDE for setup/debug of arrow
> >> >>> libraries
> >> >>>> - Wes pointed out the developer wiki on confluence. Hatem offered to
> >> >>> help with documentation.
> >> >>>>
> >> >>>> Thanks and regards,
> >> >>>> Ravindra.
> >> >>>>
> >> >>>> On 2018/12/12 16:54:21, Wes McKinney <w....@gmail.com> wrote:
> >> >>>>> All are welcome to join -- call notes will be posted after>
> >> >>>>>
> >> >>>>> https://meet.google.com/vtm-teks-phx>
> >> >>>
> >> >>
> >> >
> >>
> >
Re: Reviewing PRs (was: Re: Arrow sync call)
Posted by Chao Sun <su...@apache.org>.
+1 on adding labels for languages, review states, components, etc. This
makes it much easier to filter PRs.
Chao
On Wed, Dec 12, 2018 at 11:54 AM Krisztián Szűcs <sz...@gmail.com>
wrote:
> Create a new one and set arrow-xxx as parent:
> [image: image.png]
>
> On Wed, Dec 12, 2018 at 7:46 PM Antoine Pitrou <an...@python.org> wrote:
>
>>
>> Apparently it's possible to create GitHub teams inside the Apache
>> organization ourselves. I've just created a dummy one:
>> https://github.com/orgs/apache/teams/arrow-xxx/members
>>
>> However, I cannot create a child team inside of the arrow-committers
>> team. The button "Add a team" here is grayed out:
>> https://github.com/orgs/apache/teams/arrow-committers/teams
>>
>> Regards
>>
>> Antoine.
>>
>>
>> Le 12/12/2018 à 19:40, Krisztián Szűcs a écrit :
>> > I like the GitHub teams approach. Do We need to ask INFRA to create
>> them?
>> >
>> > On Wed, Dec 12, 2018, 7:28 PM Sebastien Binet <binet@cern.ch wrote:
>> >
>> >> On Wed, Dec 12, 2018 at 7:25 PM Antoine Pitrou <an...@python.org>
>> wrote:
>> >>
>> >>>
>> >>> Hi,
>> >>>
>> >>> Now that we have a lot of different implementations and a growing
>> number
>> >>> of assorted topics, it becomes hard to know whether a PR or issue has
>> a
>> >>> dedicated expert or would benefit from an outsider look.
>> >>>
>> >>> In Python we have what we call the "experts" list which is a per-topic
>> >>> (or per-library module) contributors who are generally interested in
>> and
>> >>> competent on such topic (*). So it's possible to cc such a person, or
>> >>> if no expert is available on a given topic, perhaps for someone else
>> to
>> >>> try and have a look anyway. Perhaps we need something similar for
>> Arrow?
>> >>>
>> >>
>> >> with github, one can also create "teams" and "@" them.
>> >> we could perhaps create @arrow-py, @arrow-cxx, @arrow-go, ...
>> >> this dilutes a bit responsibilities but also reduces a bit the net
>> that's
>> >> cast.
>> >>
>> >> -s
>> >>
>> >>
>> >>> (*) https://devguide.python.org/experts/
>> >>>
>> >>> Regards
>> >>>
>> >>> Antoine.
>> >>>
>> >>>
>> >>>
>> >>> Le 12/12/2018 à 19:13, Ravindra Pindikura a écrit :
>> >>>> Attendees : Wes, Sidd, Bryan, Francois, Hatem, Nick, Shyam, Ravindra,
>> >>> Matt
>> >>>>
>> >>>> Wes:
>> >>>> - do not rush the 0.12 release before the holidays, instead target
>> the
>> >>> release for early next year
>> >>>> - request everyone to look at PRs in the queue, and help by doing
>> >> reviews
>> >>>>
>> >>>> Wes/Nick
>> >>>> - queried about Interest in developing a "dataset abstraction" as a
>> >>> layer above file readers that arrow now supports (parquet, csv, json)
>> >>>>
>> >>>> Sidd
>> >>>> - agreed to be the release manager for 0.12
>> >>>> - things to keep in mind for release managers :
>> >>>> 1. We now use crossbow to automate the building of binaries with CI
>> >>>> 2. From this release, the binary artifacts will be hosted in bintray
>> >>> instead of apache dist since the size has increased significantly
>> >>>>
>> >>>> Hatem
>> >>>> - Asked about documentation regarding IDE for setup/debug of arrow
>> >>> libraries
>> >>>> - Wes pointed out the developer wiki on confluence. Hatem offered to
>> >>> help with documentation.
>> >>>>
>> >>>> Thanks and regards,
>> >>>> Ravindra.
>> >>>>
>> >>>> On 2018/12/12 16:54:21, Wes McKinney <w....@gmail.com> wrote:
>> >>>>> All are welcome to join -- call notes will be posted after>
>> >>>>>
>> >>>>> https://meet.google.com/vtm-teks-phx>
>> >>>
>> >>
>> >
>>
>
Re: Reviewing PRs (was: Re: Arrow sync call)
Posted by Krisztián Szűcs <sz...@gmail.com>.
Create a new one and set arrow-xxx as parent:
[image: image.png]
On Wed, Dec 12, 2018 at 7:46 PM Antoine Pitrou <an...@python.org> wrote:
>
> Apparently it's possible to create GitHub teams inside the Apache
> organization ourselves. I've just created a dummy one:
> https://github.com/orgs/apache/teams/arrow-xxx/members
>
> However, I cannot create a child team inside of the arrow-committers
> team. The button "Add a team" here is grayed out:
> https://github.com/orgs/apache/teams/arrow-committers/teams
>
> Regards
>
> Antoine.
>
>
> Le 12/12/2018 à 19:40, Krisztián Szűcs a écrit :
> > I like the GitHub teams approach. Do We need to ask INFRA to create them?
> >
> > On Wed, Dec 12, 2018, 7:28 PM Sebastien Binet <binet@cern.ch wrote:
> >
> >> On Wed, Dec 12, 2018 at 7:25 PM Antoine Pitrou <an...@python.org>
> wrote:
> >>
> >>>
> >>> Hi,
> >>>
> >>> Now that we have a lot of different implementations and a growing
> number
> >>> of assorted topics, it becomes hard to know whether a PR or issue has a
> >>> dedicated expert or would benefit from an outsider look.
> >>>
> >>> In Python we have what we call the "experts" list which is a per-topic
> >>> (or per-library module) contributors who are generally interested in
> and
> >>> competent on such topic (*). So it's possible to cc such a person, or
> >>> if no expert is available on a given topic, perhaps for someone else to
> >>> try and have a look anyway. Perhaps we need something similar for
> Arrow?
> >>>
> >>
> >> with github, one can also create "teams" and "@" them.
> >> we could perhaps create @arrow-py, @arrow-cxx, @arrow-go, ...
> >> this dilutes a bit responsibilities but also reduces a bit the net
> that's
> >> cast.
> >>
> >> -s
> >>
> >>
> >>> (*) https://devguide.python.org/experts/
> >>>
> >>> Regards
> >>>
> >>> Antoine.
> >>>
> >>>
> >>>
> >>> Le 12/12/2018 à 19:13, Ravindra Pindikura a écrit :
> >>>> Attendees : Wes, Sidd, Bryan, Francois, Hatem, Nick, Shyam, Ravindra,
> >>> Matt
> >>>>
> >>>> Wes:
> >>>> - do not rush the 0.12 release before the holidays, instead target the
> >>> release for early next year
> >>>> - request everyone to look at PRs in the queue, and help by doing
> >> reviews
> >>>>
> >>>> Wes/Nick
> >>>> - queried about Interest in developing a "dataset abstraction" as a
> >>> layer above file readers that arrow now supports (parquet, csv, json)
> >>>>
> >>>> Sidd
> >>>> - agreed to be the release manager for 0.12
> >>>> - things to keep in mind for release managers :
> >>>> 1. We now use crossbow to automate the building of binaries with CI
> >>>> 2. From this release, the binary artifacts will be hosted in bintray
> >>> instead of apache dist since the size has increased significantly
> >>>>
> >>>> Hatem
> >>>> - Asked about documentation regarding IDE for setup/debug of arrow
> >>> libraries
> >>>> - Wes pointed out the developer wiki on confluence. Hatem offered to
> >>> help with documentation.
> >>>>
> >>>> Thanks and regards,
> >>>> Ravindra.
> >>>>
> >>>> On 2018/12/12 16:54:21, Wes McKinney <w....@gmail.com> wrote:
> >>>>> All are welcome to join -- call notes will be posted after>
> >>>>>
> >>>>> https://meet.google.com/vtm-teks-phx>
> >>>
> >>
> >
>
Re: Reviewing PRs (was: Re: Arrow sync call)
Posted by Antoine Pitrou <an...@python.org>.
Apparently it's possible to create GitHub teams inside the Apache
organization ourselves. I've just created a dummy one:
https://github.com/orgs/apache/teams/arrow-xxx/members
However, I cannot create a child team inside of the arrow-committers
team. The button "Add a team" here is grayed out:
https://github.com/orgs/apache/teams/arrow-committers/teams
Regards
Antoine.
Le 12/12/2018 à 19:40, Krisztián Szűcs a écrit :
> I like the GitHub teams approach. Do We need to ask INFRA to create them?
>
> On Wed, Dec 12, 2018, 7:28 PM Sebastien Binet <binet@cern.ch wrote:
>
>> On Wed, Dec 12, 2018 at 7:25 PM Antoine Pitrou <an...@python.org> wrote:
>>
>>>
>>> Hi,
>>>
>>> Now that we have a lot of different implementations and a growing number
>>> of assorted topics, it becomes hard to know whether a PR or issue has a
>>> dedicated expert or would benefit from an outsider look.
>>>
>>> In Python we have what we call the "experts" list which is a per-topic
>>> (or per-library module) contributors who are generally interested in and
>>> competent on such topic (*). So it's possible to cc such a person, or
>>> if no expert is available on a given topic, perhaps for someone else to
>>> try and have a look anyway. Perhaps we need something similar for Arrow?
>>>
>>
>> with github, one can also create "teams" and "@" them.
>> we could perhaps create @arrow-py, @arrow-cxx, @arrow-go, ...
>> this dilutes a bit responsibilities but also reduces a bit the net that's
>> cast.
>>
>> -s
>>
>>
>>> (*) https://devguide.python.org/experts/
>>>
>>> Regards
>>>
>>> Antoine.
>>>
>>>
>>>
>>> Le 12/12/2018 à 19:13, Ravindra Pindikura a écrit :
>>>> Attendees : Wes, Sidd, Bryan, Francois, Hatem, Nick, Shyam, Ravindra,
>>> Matt
>>>>
>>>> Wes:
>>>> - do not rush the 0.12 release before the holidays, instead target the
>>> release for early next year
>>>> - request everyone to look at PRs in the queue, and help by doing
>> reviews
>>>>
>>>> Wes/Nick
>>>> - queried about Interest in developing a "dataset abstraction" as a
>>> layer above file readers that arrow now supports (parquet, csv, json)
>>>>
>>>> Sidd
>>>> - agreed to be the release manager for 0.12
>>>> - things to keep in mind for release managers :
>>>> 1. We now use crossbow to automate the building of binaries with CI
>>>> 2. From this release, the binary artifacts will be hosted in bintray
>>> instead of apache dist since the size has increased significantly
>>>>
>>>> Hatem
>>>> - Asked about documentation regarding IDE for setup/debug of arrow
>>> libraries
>>>> - Wes pointed out the developer wiki on confluence. Hatem offered to
>>> help with documentation.
>>>>
>>>> Thanks and regards,
>>>> Ravindra.
>>>>
>>>> On 2018/12/12 16:54:21, Wes McKinney <w....@gmail.com> wrote:
>>>>> All are welcome to join -- call notes will be posted after>
>>>>>
>>>>> https://meet.google.com/vtm-teks-phx>
>>>
>>
>
Re: Reviewing PRs (was: Re: Arrow sync call)
Posted by Francois Saint-Jacques <fr...@rstudio.com>.
I'd also suggest that we extend Romain's effort to add labels to all
languages, review states, and mabye. While the string labeling with [],
works, github search/filtering is not very good compared to filtering by
labels.
lang-{R,c++,py,java,...}
review-{wip,ready}
comp-{doc,gandiva,parquet,plasma}
There's a good chance this could be automated with Jira lookup + string
matching.
François
On Wed, Dec 12, 2018 at 1:40 PM Krisztián Szűcs <sz...@gmail.com>
wrote:
> I like the GitHub teams approach. Do We need to ask INFRA to create them?
>
> On Wed, Dec 12, 2018, 7:28 PM Sebastien Binet <binet@cern.ch wrote:
>
> > On Wed, Dec 12, 2018 at 7:25 PM Antoine Pitrou <an...@python.org>
> wrote:
> >
> > >
> > > Hi,
> > >
> > > Now that we have a lot of different implementations and a growing
> number
> > > of assorted topics, it becomes hard to know whether a PR or issue has a
> > > dedicated expert or would benefit from an outsider look.
> > >
> > > In Python we have what we call the "experts" list which is a per-topic
> > > (or per-library module) contributors who are generally interested in
> and
> > > competent on such topic (*). So it's possible to cc such a person, or
> > > if no expert is available on a given topic, perhaps for someone else to
> > > try and have a look anyway. Perhaps we need something similar for
> Arrow?
> > >
> >
> > with github, one can also create "teams" and "@" them.
> > we could perhaps create @arrow-py, @arrow-cxx, @arrow-go, ...
> > this dilutes a bit responsibilities but also reduces a bit the net that's
> > cast.
> >
> > -s
> >
> >
> > > (*) https://devguide.python.org/experts/
> > >
> > > Regards
> > >
> > > Antoine.
> > >
> > >
> > >
> > > Le 12/12/2018 à 19:13, Ravindra Pindikura a écrit :
> > > > Attendees : Wes, Sidd, Bryan, Francois, Hatem, Nick, Shyam, Ravindra,
> > > Matt
> > > >
> > > > Wes:
> > > > - do not rush the 0.12 release before the holidays, instead target
> the
> > > release for early next year
> > > > - request everyone to look at PRs in the queue, and help by doing
> > reviews
> > > >
> > > > Wes/Nick
> > > > - queried about Interest in developing a "dataset abstraction" as a
> > > layer above file readers that arrow now supports (parquet, csv, json)
> > > >
> > > > Sidd
> > > > - agreed to be the release manager for 0.12
> > > > - things to keep in mind for release managers :
> > > > 1. We now use crossbow to automate the building of binaries with CI
> > > > 2. From this release, the binary artifacts will be hosted in bintray
> > > instead of apache dist since the size has increased significantly
> > > >
> > > > Hatem
> > > > - Asked about documentation regarding IDE for setup/debug of arrow
> > > libraries
> > > > - Wes pointed out the developer wiki on confluence. Hatem offered to
> > > help with documentation.
> > > >
> > > > Thanks and regards,
> > > > Ravindra.
> > > >
> > > > On 2018/12/12 16:54:21, Wes McKinney <w....@gmail.com> wrote:
> > > >> All are welcome to join -- call notes will be posted after>
> > > >>
> > > >> https://meet.google.com/vtm-teks-phx>
> > >
> >
>
Re: Reviewing PRs (was: Re: Arrow sync call)
Posted by Krisztián Szűcs <sz...@gmail.com>.
I like the GitHub teams approach. Do We need to ask INFRA to create them?
On Wed, Dec 12, 2018, 7:28 PM Sebastien Binet <binet@cern.ch wrote:
> On Wed, Dec 12, 2018 at 7:25 PM Antoine Pitrou <an...@python.org> wrote:
>
> >
> > Hi,
> >
> > Now that we have a lot of different implementations and a growing number
> > of assorted topics, it becomes hard to know whether a PR or issue has a
> > dedicated expert or would benefit from an outsider look.
> >
> > In Python we have what we call the "experts" list which is a per-topic
> > (or per-library module) contributors who are generally interested in and
> > competent on such topic (*). So it's possible to cc such a person, or
> > if no expert is available on a given topic, perhaps for someone else to
> > try and have a look anyway. Perhaps we need something similar for Arrow?
> >
>
> with github, one can also create "teams" and "@" them.
> we could perhaps create @arrow-py, @arrow-cxx, @arrow-go, ...
> this dilutes a bit responsibilities but also reduces a bit the net that's
> cast.
>
> -s
>
>
> > (*) https://devguide.python.org/experts/
> >
> > Regards
> >
> > Antoine.
> >
> >
> >
> > Le 12/12/2018 à 19:13, Ravindra Pindikura a écrit :
> > > Attendees : Wes, Sidd, Bryan, Francois, Hatem, Nick, Shyam, Ravindra,
> > Matt
> > >
> > > Wes:
> > > - do not rush the 0.12 release before the holidays, instead target the
> > release for early next year
> > > - request everyone to look at PRs in the queue, and help by doing
> reviews
> > >
> > > Wes/Nick
> > > - queried about Interest in developing a "dataset abstraction" as a
> > layer above file readers that arrow now supports (parquet, csv, json)
> > >
> > > Sidd
> > > - agreed to be the release manager for 0.12
> > > - things to keep in mind for release managers :
> > > 1. We now use crossbow to automate the building of binaries with CI
> > > 2. From this release, the binary artifacts will be hosted in bintray
> > instead of apache dist since the size has increased significantly
> > >
> > > Hatem
> > > - Asked about documentation regarding IDE for setup/debug of arrow
> > libraries
> > > - Wes pointed out the developer wiki on confluence. Hatem offered to
> > help with documentation.
> > >
> > > Thanks and regards,
> > > Ravindra.
> > >
> > > On 2018/12/12 16:54:21, Wes McKinney <w....@gmail.com> wrote:
> > >> All are welcome to join -- call notes will be posted after>
> > >>
> > >> https://meet.google.com/vtm-teks-phx>
> >
>
Re: Reviewing PRs (was: Re: Arrow sync call)
Posted by Sebastien Binet <bi...@cern.ch>.
On Wed, Dec 12, 2018 at 7:25 PM Antoine Pitrou <an...@python.org> wrote:
>
> Hi,
>
> Now that we have a lot of different implementations and a growing number
> of assorted topics, it becomes hard to know whether a PR or issue has a
> dedicated expert or would benefit from an outsider look.
>
> In Python we have what we call the "experts" list which is a per-topic
> (or per-library module) contributors who are generally interested in and
> competent on such topic (*). So it's possible to cc such a person, or
> if no expert is available on a given topic, perhaps for someone else to
> try and have a look anyway. Perhaps we need something similar for Arrow?
>
with github, one can also create "teams" and "@" them.
we could perhaps create @arrow-py, @arrow-cxx, @arrow-go, ...
this dilutes a bit responsibilities but also reduces a bit the net that's
cast.
-s
> (*) https://devguide.python.org/experts/
>
> Regards
>
> Antoine.
>
>
>
> Le 12/12/2018 à 19:13, Ravindra Pindikura a écrit :
> > Attendees : Wes, Sidd, Bryan, Francois, Hatem, Nick, Shyam, Ravindra,
> Matt
> >
> > Wes:
> > - do not rush the 0.12 release before the holidays, instead target the
> release for early next year
> > - request everyone to look at PRs in the queue, and help by doing reviews
> >
> > Wes/Nick
> > - queried about Interest in developing a "dataset abstraction" as a
> layer above file readers that arrow now supports (parquet, csv, json)
> >
> > Sidd
> > - agreed to be the release manager for 0.12
> > - things to keep in mind for release managers :
> > 1. We now use crossbow to automate the building of binaries with CI
> > 2. From this release, the binary artifacts will be hosted in bintray
> instead of apache dist since the size has increased significantly
> >
> > Hatem
> > - Asked about documentation regarding IDE for setup/debug of arrow
> libraries
> > - Wes pointed out the developer wiki on confluence. Hatem offered to
> help with documentation.
> >
> > Thanks and regards,
> > Ravindra.
> >
> > On 2018/12/12 16:54:21, Wes McKinney <w....@gmail.com> wrote:
> >> All are welcome to join -- call notes will be posted after>
> >>
> >> https://meet.google.com/vtm-teks-phx>
>