You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/21 07:21:33 UTC
[GitHub] [incubator-dolphinscheduler] lenboo opened a new pull request #4828: [Feature][JsonSplit]refactor remove the json in process instance and definition
lenboo opened a new pull request #4828:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4828
close #4417
refactor remove the json in process instance and definition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] JinyLeeChina commented on pull request #4828: [Feature][JsonSplit]refactor remove the json in process instance and definition
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on pull request #4828:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4828#issuecomment-782984320
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] simon824 commented on a change in pull request #4828: [Feature][JsonSplit]refactor remove the json in process instance and definition
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #4828:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4828#discussion_r579902366
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
##########
@@ -427,9 +427,6 @@ private String getResourceIds(ProcessData processData) {
return result;
}
}
- // get the processdefinitionjson before saving,and then save the name and taskid
- String oldJson = processDefinition.getProcessDefinitionJson();
- processDefinitionJson = processService.changeJson(processData, oldJson);
ProcessData newProcessData = JSONUtils.parseObject(processDefinitionJson, ProcessData.class);
Review comment:
parse processDefinitionJson to ProcessData is duplicated with line405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] lenboo merged pull request #4828: [Feature][JsonSplit]refactor remove the json in process instance and definition
Posted by GitBox <gi...@apache.org>.
lenboo merged pull request #4828:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org