You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "access2rohit (GitHub)" <gi...@apache.org> on 2018/08/21 18:51:51 UTC
[GitHub] [incubator-mxnet] access2rohit opened pull request #12279:
Revert "Disable kvstore test (#11798)"
## Description ##
Re-enbling KVstore test. Since its no longer reproducible. Will have to observe whether it still fails after enabling it or not.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12279 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on issue #12279:
Revert "Disable kvstore test (#11798)"
Posted by "marcoabreu (GitHub)" <gi...@apache.org>.
Okay, seems like this is a different KVStore issue than the one I'm talking about.
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12279 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on issue #12279:
Revert "Disable kvstore test (#11798)"
Posted by "marcoabreu (GitHub)" <gi...@apache.org>.
Please explain how you tried to reproduce it.
Did you check out the matching commit of the linked run? We know for sure that with that commit it hang, so it's a matter of being able to reproduce it with that commit first, finding the pattern that causes it and then checking with the current state if it still happens.
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12279 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] KellenSunderland commented on issue
#12279: Revert "Disable kvstore test (#11798)"
Posted by "KellenSunderland (GitHub)" <gi...@apache.org>.
Fixes https://github.com/apache/incubator-mxnet/issues/11801
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12279 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on issue #12279:
Revert "Disable kvstore test (#11798)"
Posted by "access2rohit (GitHub)" <gi...@apache.org>.
@marcoabreu These changes are non-reproducible now
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12279 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on issue #12279:
Revert "Disable kvstore test (#11798)"
Posted by "access2rohit (GitHub)" <gi...@apache.org>.
@marcoabreu I have sent you the link to the ticket with all the findings and steps taken to reproduce it and why it would take a significant amount of time now to reproduce or even isolate the fix that might have fixed it. Could you please take a look at that
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12279 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu closed pull request #12279:
Revert "Disable kvstore test (#11798)"
Posted by "marcoabreu (GitHub)" <gi...@apache.org>.
[ pull request closed by marcoabreu ]
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12279 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on issue #12279:
Revert "Disable kvstore test (#11798)"
Posted by "access2rohit (GitHub)" <gi...@apache.org>.
@samskalicky @anirudh2290
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12279 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] KellenSunderland commented on issue
#12279: Revert "Disable kvstore test (#11798)"
Posted by "KellenSunderland (GitHub)" <gi...@apache.org>.
I checked out this history and hadn't seen a any regressions reported
previously on this Marco. There were related issues but not this one
exactly. I'd suggest closely monitoring the test after it's reenabled.
On Wed, Aug 22, 2018, 6:14 PM access2rohit <no...@github.com> wrote:
> @marcoabreu <https://github.com/marcoabreu> These changes are
> non-reproducible now
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-mxnet/pull/12279#issuecomment-415089704>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AHGTE123RU64tsZs6IuBTg5lNKnk7ORcks5uTYNxgaJpZM4WGZS6>
> .
>
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12279 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on issue #12279:
Revert "Disable kvstore test (#11798)"
Posted by "access2rohit (GitHub)" <gi...@apache.org>.
@anirudh2290 @sandeep-krishnamurthy can you please merge it
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12279 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org