You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2017/05/18 19:23:38 UTC
[kudu-CR] docs: revise security doc based on KUDU-1875 and add release notes for 1.4
Hao Hao has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6922
Change subject: docs: revise security doc based on KUDU-1875 and add release notes for 1.4
......................................................................
docs: revise security doc based on KUDU-1875 and
add release notes for 1.4
Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
---
M docs/prior_release_notes.adoc
M docs/release_notes.adoc
M docs/security.adoc
3 files changed, 208 insertions(+), 162 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/6922/1
--
To view, visit http://gerrit.cloudera.org:8080/6922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] docs: revise security doc based on KUDU-1875 and add release notes for 1.4
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6922
to look at the new patch set (#4).
Change subject: docs: revise security doc based on KUDU-1875 and add release notes for 1.4
......................................................................
docs: revise security doc based on KUDU-1875 and
add release notes for 1.4
Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
---
M docs/prior_release_notes.adoc
M docs/release_notes.adoc
M docs/security.adoc
3 files changed, 210 insertions(+), 162 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/6922/4
--
To view, visit http://gerrit.cloudera.org:8080/6922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: revise security doc based on KUDU-1875 and add release notes for 1.4
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: docs: revise security doc based on KUDU-1875 and add release notes for 1.4
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6922/2/docs/prior_release_notes.adoc
File docs/prior_release_notes.adoc:
Line 40: [[rn_1.3.0]]
> Todd, do we also need to bring over 1.3.1 release notes, or do those remain
I think in the past we just put them in the 1.3.x branch and tried to keep the "past versions" to be the minor releases and not bugfix releases.
Would be interested to hear the opinion of Ambreen or John on this, though, what the best practice is.
--
To view, visit http://gerrit.cloudera.org:8080/6922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] docs: revise security doc based on KUDU-1875 and add release notes for 1.4
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: docs: revise security doc based on KUDU-1875 and add release notes for 1.4
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6922/4/docs/security.adoc
File docs/security.adoc:
Line 54: any unauthenticated connections from publicly routable IPs.
Reword as 'Unauthenticated connections from publicly routable IPs will be rejected.' here and in the release notes.
--
To view, visit http://gerrit.cloudera.org:8080/6922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] docs: revise security doc based on KUDU-1875 and add release notes for 1.4
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change.
Change subject: docs: revise security doc based on KUDU-1875 and add release notes for 1.4
......................................................................
Patch Set 3:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/6922/2/docs/release_notes.adoc
File docs/release_notes.adoc:
PS2, Line 41: s. But
> I think this will read better if you break the sentence into two after 'int
Done
PS2, Line 48: e restricted by a firewall
> I would also add that it can be safe if authentication and encryption are c
Done
http://gerrit.cloudera.org:8080/#/c/6922/2/docs/security.adoc
File docs/security.adoc:
PS2, Line 50: Kudu
> uppercase Kudu
Done
PS2, Line 53: . B
> Same comment about splitting this sentence in two.
Done
PS2, Line 56: using the `--t
> nit: configured using the
Done
PS2, Line 58: to all
> to allow
Done
PS2, Line 59: erwise restricted by a firewall,
: malicious users may be able to gain una
> same thing about clarifying the role of required authentication and encrypt
Done
PS2, Line 119: . Sa
> Kudu
Done
--
To view, visit http://gerrit.cloudera.org:8080/6922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] docs: revise security doc based on KUDU-1875 and add release notes for 1.4
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: docs: revise security doc based on KUDU-1875 and add release notes for 1.4
......................................................................
Patch Set 2:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/6922/2/docs/prior_release_notes.adoc
File docs/prior_release_notes.adoc:
Line 40: [[rn_1.3.0]]
Todd, do we also need to bring over 1.3.1 release notes, or do those remain only on the 1.3.x branch?
http://gerrit.cloudera.org:8080/#/c/6922/2/docs/release_notes.adoc
File docs/release_notes.adoc:
PS2, Line 41: s, but
I think this will read better if you break the sentence into two after 'interfaces'.
PS2, Line 48: e restricted by a firewall
I would also add that it can be safe if authentication and encryption are configured to be required, just so people don't get worried.
http://gerrit.cloudera.org:8080/#/c/6922/2/docs/security.adoc
File docs/security.adoc:
PS2, Line 50: kudu
uppercase Kudu
PS2, Line 53: , b
Same comment about splitting this sentence in two.
PS2, Line 56: using '--trust
nit: configured using the
PS2, Line 58: allows
to allow
PS2, Line 59: erwise restricted by a firewall,
: malicious users may be able to gain una
same thing about clarifying the role of required authentication and encryption here.
PS2, Line 119: kudu
Kudu
--
To view, visit http://gerrit.cloudera.org:8080/6922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] docs: revise security doc based on KUDU-1875 and add release notes for 1.4
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: docs: revise security doc based on KUDU-1875 and add release notes for 1.4
......................................................................
Patch Set 5: Code-Review+2 Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] docs: revise security doc based on KUDU-1875 and add release notes for 1.4
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change.
Change subject: docs: revise security doc based on KUDU-1875 and add release notes for 1.4
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6922/4/docs/security.adoc
File docs/security.adoc:
Line 54: connections from publicly routable IPs will be rejected.
> Reword as 'Unauthenticated connections from publicly routable IPs will be r
Done
--
To view, visit http://gerrit.cloudera.org:8080/6922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] docs: revise security doc based on KUDU-1875 and add release notes for 1.4
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: docs: revise security doc based on KUDU-1875 and add release notes for 1.4
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] docs: revise security doc based on KUDU-1875 and add release notes for 1.4
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6922
to look at the new patch set (#3).
Change subject: docs: revise security doc based on KUDU-1875 and add release notes for 1.4
......................................................................
docs: revise security doc based on KUDU-1875 and
add release notes for 1.4
Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
---
M docs/prior_release_notes.adoc
M docs/release_notes.adoc
M docs/security.adoc
3 files changed, 210 insertions(+), 162 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/6922/3
--
To view, visit http://gerrit.cloudera.org:8080/6922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: revise security doc based on KUDU-1875 and add release notes for 1.4
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: docs: revise security doc based on KUDU-1875 and add release notes for 1.4
......................................................................
docs: revise security doc based on KUDU-1875 and
add release notes for 1.4
Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Reviewed-on: http://gerrit.cloudera.org:8080/6922
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Dan Burkert <da...@apache.org>
---
M docs/prior_release_notes.adoc
M docs/release_notes.adoc
M docs/security.adoc
3 files changed, 210 insertions(+), 162 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/6922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: revise security doc based on KUDU-1875 and add release notes for 1.4
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6922
to look at the new patch set (#2).
Change subject: docs: revise security doc based on KUDU-1875 and add release notes for 1.4
......................................................................
docs: revise security doc based on KUDU-1875 and
add release notes for 1.4
Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
---
M docs/prior_release_notes.adoc
M docs/release_notes.adoc
M docs/security.adoc
3 files changed, 208 insertions(+), 162 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/6922/2
--
To view, visit http://gerrit.cloudera.org:8080/6922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: revise security doc based on KUDU-1875 and add release notes for 1.4
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6922
to look at the new patch set (#5).
Change subject: docs: revise security doc based on KUDU-1875 and add release notes for 1.4
......................................................................
docs: revise security doc based on KUDU-1875 and
add release notes for 1.4
Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
---
M docs/prior_release_notes.adoc
M docs/release_notes.adoc
M docs/security.adoc
3 files changed, 210 insertions(+), 162 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/6922/5
--
To view, visit http://gerrit.cloudera.org:8080/6922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e386203f5ed3ef66e2ec136e67738b8c7eb8b1a
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>